1.17 branching - status update 3

Hi,
this is a quick summary of current 1.17 branching status. As before, feel free to correct/complete the information below.

The new version of turbolinks-classic (2.5.4) was released about 12 hours ago, and we work on adding it to tfm-ror51 [1].

Dynflowd deployment on Debian is almost ready to be merged [2].

OAuth fix for Rails 5 [3] did not receive much attention from OAuth maintainers. We plan to package a forked version with included fix until new gem version compatible with Rails 5 is released.

The plan is to move slowly forward with Rails 5.0 [4], then introduce incompatible changes to Rails 4.2 and move to 5.1

O.

[1] https://github.com/theforeman/tfm-ror51-packaging/pulls [2] https://github.com/theforeman/foreman-packaging/pull/1959 [3] https://github.com/oauth-xx/oauth-ruby/pull/150
[4] https://github.com/theforeman/foreman/pull/4867
Thanks for the weekly updates!

Do you forsee 1.17 working as:

1) Wait till the core codebase is updated to Rails 5.1 then branch and notify plugins
2) Branch soon at some stable point and backport the Rails 5.1 code changes

I believe also on the list of items is the update to fog 1.42 that has a pending PR given the current version of Fog requires JSON < 2 and Ruby 2.4 comes with JSON 2+.


··· On Dec 7, 2017 7:02 AM, "Ondrej Prazak" <oprazak@redhat.com> wrote:

Hi,
this is a quick summary of current 1.17 branching status. As before, feel
free to correct/complete the information below.

The new version of turbolinks-classic (2.5.4) was released about 12 hours
ago, and we work on adding it to tfm-ror51 [1].

Dynflowd deployment on Debian is almost ready to be merged [2].

OAuth fix for Rails 5 [3] did not receive much attention from OAuth
maintainers. We plan to package a forked version with included fix until
new gem version compatible with Rails 5 is released.

The plan is to move slowly forward with Rails 5.0 [4], then introduce
incompatible changes to Rails 4.2 and move to 5.1

O.

[1] https://github.com/theforeman/tfm-ror51-packaging/pulls
[2] https://github.com/theforeman/foreman-packaging/pull/1959
[3] https://github.com/oauth-xx/oauth-ruby/pull/150
[4] https://github.com/theforeman/foreman/pull/4867

--
You received this message because you are subscribed to the Google Groups
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

I would rather go with option 1 to avoid a large amount of cherry-picks. Thanks for pointing out the fog update.


··· On Thu, Dec 7, 2017 at 3:52 PM, Eric D Helms <eric.d.helms@gmail.com> wrote:

Thanks for the weekly updates!

Do you forsee 1.17 working as:

1) Wait till the core codebase is updated to Rails 5.1 then branch and
notify plugins
2) Branch soon at some stable point and backport the Rails 5.1 code
changes

I believe also on the list of items is the update to fog 1.42 that has a
pending PR given the current version of Fog requires JSON < 2 and Ruby 2.4
comes with JSON 2+.

On Dec 7, 2017 7:02 AM, "Ondrej Prazak" <oprazak@redhat.com> wrote:

Hi,
this is a quick summary of current 1.17 branching status. As before, feel
free to correct/complete the information below.

The new version of turbolinks-classic (2.5.4) was released about 12 hours
ago, and we work on adding it to tfm-ror51 [1].

Dynflowd deployment on Debian is almost ready to be merged [2].

OAuth fix for Rails 5 [3] did not receive much attention from OAuth
maintainers. We plan to package a forked version with included fix until
new gem version compatible with Rails 5 is released.

The plan is to move slowly forward with Rails 5.0 [4], then introduce
incompatible changes to Rails 4.2 and move to 5.1

O.

[1] https://github.com/theforeman/tfm-ror51-packaging/pulls
[2] https://github.com/theforeman/foreman-packaging/pull/1959
[3] https://github.com/oauth-xx/oauth-ruby/pull/150
[4] https://github.com/theforeman/foreman/pull/4867

--
You received this message because you are subscribed to the Google Groups
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Thanks for the weekly updates!
I'll echo that. Greatly appreciated.

Do you forsee 1.17 working as:

1) Wait till the core codebase is updated to Rails 5.1 then branch and
notify plugins
2) Branch soon at some stable point and backport the Rails 5.1 code changes
Option 1 sounds easier.

I believe also on the list of items is the update to fog 1.42 that has a
pending PR given the current version of Fog requires JSON < 2 and Ruby 2.4
comes with JSON 2+.
https://github.com/theforeman/foreman/pull/4869 was merged earlier this week. We now need to update fog in our packages.

https://github.com/theforeman/foreman-packaging/pull/1970 adds fog-ovirt https://github.com/theforeman/foreman-packaging/pull/1975 bumps fog. This needs json >= 2 and I think that's only available in the new SCL.


Hi,
this is a quick summary of current 1.17 branching status. As before, feel
free to correct/complete the information below.

The new version of turbolinks-classic (2.5.4) was released about 12 hours
ago, and we work on adding it to tfm-ror51 [1].

Dynflowd deployment on Debian is almost ready to be merged [2].

OAuth fix for Rails 5 [3] did not receive much attention from OAuth
maintainers. We plan to package a forked version with included fix until
new gem version compatible with Rails 5 is released.
In RPM packaging we could carry a patch since we've unbundled. In Debian packaging this doesn't work due to bundling so we might need to fork.

··· On Thu, Dec 07, 2017 at 09:52:21AM -0500, Eric D Helms wrote:
On Dec 7, 2017 7:02 AM, "Ondrej Prazak" <oprazak@redhat.com> wrote:
The plan is to move slowly forward with Rails 5.0 [4], then introduce
incompatible changes to Rails 4.2 and move to 5.1

O.

[1] https://github.com/theforeman/tfm-ror51-packaging/pulls
[2] https://github.com/theforeman/foreman-packaging/pull/1959
[3] https://github.com/oauth-xx/oauth-ruby/pull/150
[4] https://github.com/theforeman/foreman/pull/4867
The PR has been merged and version 0.5.4 has been released. Looks like we should test with this.


··· On Thu, Dec 07, 2017 at 01:02:00PM +0100, Ondrej Prazak wrote:
OAuth fix for Rails 5 [3] did not receive much attention from OAuth
maintainers. We plan to package a forked version with included fix until
new gem version compatible with Rails 5 is released.

[3] https://github.com/oauth-xx/oauth-ruby/pull/150
Hi,


··· On Sat, Dec 09, 2017 at 05:05:37PM +0100, Ewoud Kohl van Wijngaarden wrote:
On Thu, Dec 07, 2017 at 01:02:00PM +0100, Ondrej Prazak wrote:
OAuth fix for Rails 5 [3] did not receive much attention from OAuth
maintainers. We plan to package a forked version with included fix until
new gem version compatible with Rails 5 is released.

[3] https://github.com/oauth-xx/oauth-ruby/pull/150

The PR has been merged and version 0.5.4 has been released. Looks like we
should test with this.
Debian nightlies' systest indeed is green again now.

Regards
--
Michael Moll

I would like to bring one issue into attention for 1.17

This was one of the mistakes we did in 1.16, where we removed some code
from foreman-tasks that was supposed to be moved to the core, but it
was not resolved during the 1.16 release process. As a result, we have
been blocked on releasing new tasks on 1.16 for several months
and we in fact have now newer version of remote execution in 1.15 than in
1.16.

Therefore I think this needs to be resolved before we start branching, to
avoid
this situation to continue forward in 1.17

-- Ivan

···

On Sat, Dec 9, 2017 at 5:11 PM, Michael Moll <kvedulv@kvedulv.de> wrote:

Hi,

On Sat, Dec 09, 2017 at 05:05:37PM +0100, Ewoud Kohl van Wijngaarden wrote:
> On Thu, Dec 07, 2017 at 01:02:00PM +0100, Ondrej Prazak wrote:
> >OAuth fix for Rails 5 [3] did not receive much attention from OAuth
> >maintainers. We plan to package a forked version with included fix until
> >new gem version compatible with Rails 5 is released.
> >
> >[3] Fixes UnknownRequestType on Rails 5.1 for ActionDispatch::Request by xprazak2 · Pull Request #150 · oauth-xx/oauth-ruby · GitHub
>
> The PR has been merged and version 0.5.4 has been released. Looks like we
> should test with this.

Debian nightlies' systest indeed is green again now.

Regards
--
Michael Moll

--
You received this message because you are subscribed to the Google Groups
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout\.