New poster, long time Foreman user, and hopeful contributor here.
As I've decided to take the plunge into contributing to Foreman, I figured
#10089 might be a good newbie task to pick off:
http://projects.theforeman.org/issues/10089 - Use fixed-width font for
parameters
"""As some parameters are displayed as YAML, using a fixed-width font would
greatly ease reading and writing of such values.
Right now, indentation is too hard to get right and I usually have to edit
the parameter in an external editor then copy-paste the content in order to
avoid problems."""
···
---
My hunch is that this has been sitting open for two years now because
either it’s really this simple, or there’s some nuance here not documented
in the feature request.
The code below sets textarea.form-control fields to monospace. Since
is used in a lot of places next to controls that are styled as
Helvetica, modifying all places where .form-control is used would cause
cosmetic issues. Plus, the lack of fixed-width input today is mostly an
issue for multi-line input (AFAIK).
Example:
https://github.com/eanderton/foreman/commit/84657c11c0893b86b922dc0b700478639ea26217
I’m open to any additional suggestions on this one. Any feedback?
Thanks,
Tomer, Marek,
Thanks for the feedback! I'll be sure to open a PR when ready. 
In the meantime, I'll aim for side-effect free code with this and only
touch the fields that matter, when it matters (i.e. json/yaml input).
Hello,
thanks for your contribution! I'd recommend opening the PR on github with the
change, that way it will get attention of more reviewers. If you're not sure
about the process, please find a description at [1]. My opinion on the change
is that it should change the font only for text areas that contain the YAML/
JSON, therefore in this case only when parameter type is set to YAML/JSON.
Thanks
[1] https://www.theforeman.org/contribute.html#SubmitPatches
···
--
Marek
On neděle 25. června 2017 14:09:22 CEST Eric Anderton wrote:
New poster, long time Foreman user, and hopeful contributor here.
As I’ve decided to take the plunge into contributing to Foreman, I figured
#10089 might be a good newbie task to pick off:
Feature #10089: Use fixed-width font for parameters - Foreman - Use fixed-width font for
parameters
“”“As some parameters are displayed as YAML, using a fixed-width font would
greatly ease reading and writing of such values.
Right now, indentation is too hard to get right and I usually have to edit
the parameter in an external editor then copy-paste the content in order to
avoid problems.”""
My hunch is that this has been sitting open for two years now because
either it’s really this simple, or there’s some nuance here not documented
in the feature request.
The code below sets textarea.form-control fields to monospace. Since
is used in a lot of places next to controls that are styled as
Helvetica, modifying all places where .form-control is used would cause
cosmetic issues. Plus, the lack of fixed-width input today is mostly an
issue for multi-line input (AFAIK).
Example:
https://github.com/eanderton/foreman/commit/84657c11c0893b86b922dc0b70047863
9ea26217
I’m open to any additional suggestions on this one. Any feedback?
Thanks,
Welcome Eric!
The Foreman handbook[1] can be a useful resource for future contributions.
For this one - as Marek mentioned, it is best to open a PR where other
contributors can comment and review. I would suggest maybe adding a
"fixed-width" class to elements that should have a fixed-width font, that
way it could be set for any field that needs it easily.
[1] https://www.theforeman.org/handbook.html
···
On Mon, Jun 26, 2017 at 9:41 AM, Marek Hulán wrote:
Hello,
thanks for your contribution! I’d recommend opening the PR on github with
the
change, that way it will get attention of more reviewers. If you’re not
sure
about the process, please find a description at [1]. My opinion on the
change
is that it should change the font only for text areas that contain the
YAML/
JSON, therefore in this case only when parameter type is set to YAML/JSON.
Thanks
[1] https://www.theforeman.org/contribute.html#SubmitPatches
–
Marek
On neděle 25. června 2017 14:09:22 CEST Eric Anderton wrote:
New poster, long time Foreman user, and hopeful contributor here.
As I’ve decided to take the plunge into contributing to Foreman, I
figured
#10089 might be a good newbie task to pick off:
Feature #10089: Use fixed-width font for parameters - Foreman - Use fixed-width font for
parameters
“”“As some parameters are displayed as YAML, using a fixed-width font
would
greatly ease reading and writing of such values.
Right now, indentation is too hard to get right and I usually have to
edit
the parameter in an external editor then copy-paste the content in order
to
avoid problems.”""
My hunch is that this has been sitting open for two years now because
either it’s really this simple, or there’s some nuance here not
documented
in the feature request.
The code below sets textarea.form-control fields to monospace. Since
is used in a lot of places next to controls that are styled as
Helvetica, modifying all places where .form-control is used would cause
cosmetic issues. Plus, the lack of fixed-width input today is mostly an
issue for multi-line input (AFAIK).
Example:
https://github.com/eanderton/foreman/commit/84657c11c0893b86
b922dc0b70047863
9ea26217
I’m open to any additional suggestions on this one. Any feedback?
Thanks,
–
You received this message because you are subscribed to the Google Groups
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
–
Have a nice day,
Tomer Brisker
Red Hat Engineering
