Hi,
Attaching a patch to make $subject work. I saw that vshpere pubkeyy
hash was a hardcoded value in the code. Have made it a configurable
item. Please test for any problems.
0001-Add-support-for-changing-vsphere-pubkey-hash-on-per-.patch (2.54 KB)
···
--
---
Thanks
Saurabh Bathe
+91 9422785635
> Hi,
>
> Attaching a patch to make $subject work. I saw that vshpere pubkeyy
> hash was a hardcoded value in the code. Have made it a configurable
> item. Please test for any problems.
>
> –
> —
> Thanks
> Saurabh Bathe
> +91 9422785635
> <0001-Add-support-for-changing-vsphere-pubkey-hash-on-per-.patch>
Hi,
Thanks for the patch!
two comments:
-
I think it would be better to have a general purpose field that
would be used for such extra infro that a provider might require, I
guess having a vmware specific entry in the db is possible, but might
be annoying to create db migrations all the time as we add more
functionality.
I was thinking of adding similar serialized support, similar to how vm
attributes are currently saved in a hostgroup.
-
I would guess a user don't how to fetch the uuid (besides the error
message), maybe as a small improvement step, we could add auto
assignment of that field as part of the test connection (or if that
field is blank etc?)
Ohad
> 1. I think it would be better to have a general purpose field that
> would be used for such extra infro that a provider might require, I
> guess having a vmware specific entry in the db is possible, but might
> be annoying to create db migrations all the time as we add more
> functionality.
> I was thinking of adding similar serialized support, similar to how vm
> attributes are currently saved in a hostgroup.
Thanks for the review. I'm new to foreman and have not yet looked at
all sections of the code. I will take a look at how you do it in
hostgroups and will try to come up with something similar here.
> 2. I would guess a user don't how to fetch the uuid (besides the error
> message), maybe as a small improvement step, we could add auto
> assignment of that field as part of the test connection (or if that
> field is blank etc?)
Yes. That would definitely be a required enhancement.
···
On Mon, Apr 23, 2012 at 11:21 PM, Ohad Levy wrote:
–
Thanks
Saurabh Bathe
+91 9422785635