AW: Merge permission for theforemen/foreman-ansible-modules

Thank you all! Especially for the encouraging words.

··· -----Ursprüngliche Nachricht----- > Von:Eric D Helms > Gesendet: Mittwoch 1 November 2017 20:29 > An: foreman-dev > Betreff: Re: [foreman-dev] Merge permission for theforemen/foreman-ansible-modules > > +1 from me as well (Ill aim to add you in the requisite 5 more days depending on the further outcome) > > On Wed, Nov 1, 2017 at 3:24 PM, Ewoud Kohl van Wijngaarden <ewoud@kohlvanwijngaarden.nl > wrote: > +1 while I havent looked at his ansible work that closely I have seen that hes already behaving like an excellent maintainer: good reviews, active and generally a good and friendly person to have around. > > On Mon, Oct 30, 2017 at 11:46:34AM -0400, Andrew Kofink wrote: > +1 from me! We have benefited greatly from Matthias contributions in > foreman-ansible-modules. If youd like to see some of his work, here are > his merged PRs > <https://github.com/search?utf8=%E2%9C%93&q=author%3Amdellweg+repo%3Atheforeman%2Fforeman-ansible-modules+is%3Amerged&type=Issues >, > and here are all the PRs he has helped to review > <https://github.com/search?utf8=%E2%9C%93&q=commenter%3Amdellweg+-author%3Aakofink+repo%3Atheforeman%2Fforeman-ansible-modules+is%3Amerged&type= > > . > > On Mon, Oct 30, 2017 at 11:34 AM, Matthias Dellweg <dellweg@atix.de > wrote: > > Hello, > i was just encouraged, to ask for merge/push permission in > theforeman/foreman-ansible-modules. > I have contributed to this repository almost since the beginning (yes, > its a very young one), > and did a hand full of reviews that lead to constructive discussions. The > collaboration with > Andrew, Eric and Evgeni have always been very fruitful from my perspective. > For co-inventing the DRY glue layer cement (with fobheb), github > classifies me as the top > garbage collector with by far the most removed lines. > > I ask you kindly to vote, whether i shall be entrusted with the power of > the merge. > Thanks for considering, > Matthias > > -- > You received this message because you are subscribed to the Google Groups "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscribe@googlegroups.com . > For more options, visit https://groups.google.com/d/optout . > >
> -- > Eric D. Helms > Red Hat Engineering > -- > You received this message because you are subscribed to the Google Groups "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscribe@googlegroups.com . > For more options, visit https://groups.google.com/d/optout .