Bug: Orgs and Locs + Job Templates are broken in 3.18 (probably 3.17 as well)

[ekohl]

@pablomh

If you have an environment that reproduces the original issue, it would be very helpful if you could test pablomh/foreman#10 and report back with results. If it behaves well outside our setup too, that should give us enough confidence to start working on upstreaming it.

Can you please open a PR against Foreman itself instead of against your own fork?

[pablomh]

Of course. It was created only as a POC for me to easily test it.

[pablomh]

Now it’s Fixes #39323 - Optimize grouped authorization filter handling by pablomh · Pull Request #10988 · theforeman/foreman · GitHub upstream.

[singularity001]

Hi @singularity001. I dug into this further and put together a proposed fix here: pablomh/foreman#10

You are awesome. These look like some crazy huge improvements, which for someone with as large of a Foreman environment as us, is really important.

I should be able to test these changes out today.

[singularity001]

@pablomh

If you have an environment that reproduces the original issue, it would be very helpful if you could test pablomh/foreman#10 and report back with results.

I would say as of right now the results (on the /hosts) page are inconclusive. Pre patch load time for a user with all locations and orgs was 9-15 seconds (to load 25 hosts per page). After the patch it is still the same amount of time. It could just be that because this user has so many locations and orgs - thats just how long it takes..

[aruzicka]

I wouldn’t dismiss your original findings and what you had in the initializer patch. I borrowed some ideas from it and opened Fixes #39336 - Batch taxonomy subtree lookups to avoid N+1 queries by adamruzicka · Pull Request #10990 · theforeman/foreman · GitHub to address the “a user with all the org/locs” use case, which is slightly different than what Pablo’s fix was aiming at.