Config groups feature PR review

Hi all,

Can you please review the feature for config groups in the hope that it will be included in 1.5

As a reminder, config groups are "puppet class groups" that can be assigned to a hostgroup or host. This is for customers who requested assigning multiple hostgroups to a host. A hostgroup is a definition/template for a host, so there will only be one hostgroup per host, but now you can assign multiple config groups to a host (or hostgroup).

This feature went through several iterations regarding the UI as follows:

  1. used multi-select widget similar to what we use for locations/organizations
  2. re-write the whole form in AngularJS
  3. only implement #puppletclasses tab in AngularJS
  4. use jQuery similar to what we used for selecting puppetclasses

If this was a new project, then I would go with AngularJS for the whole form. However, since there is so much existing code that is affected by implementing config groups (when environment changes, loading puppet parameters, etc), it was decided to go with the jQuery solution.

You feedback is appreciated.

Joseph Magen
Red Hat Engineering

I updated https://github.com/theforeman/foreman/pull/1217

Any feedback is appreciated.

Thanks,

Joseph

··· ----- Original Message ----- > From: "Joseph Magen" > To: "foreman-dev" > Sent: Monday, April 7, 2014 1:58:51 PM > Subject: [foreman-dev] config groups feature PR review > > Hi all, > > Can you please review the feature for config groups in the hope that it will > be included in 1.5 > > https://github.com/theforeman/foreman/pull/1217 > > As a reminder, config groups are "puppet class groups" that can be assigned > to a hostgroup or host. This is for customers who requested assigning > multiple hostgroups to a host. A hostgroup is a definition/template for a > host, so there will only be one hostgroup per host, but now you can assign > multiple config groups to a host (or hostgroup). > > This feature went through several iterations regarding the UI as follows: > > 1) used multi-select widget similar to what we use for > locations/organizations > 2) re-write the whole form in AngularJS > 3) only implement #puppletclasses tab in AngularJS > 4) use jQuery similar to what we used for selecting puppetclasses > > If this was a new project, then I would go with AngularJS for the whole form. > However, since there is so much existing code that is affected by > implementing config groups (when environment changes, loading puppet > parameters, etc), it was decided to go with the jQuery solution. > > You feedback is appreciated. > > Joseph Magen > Red Hat Engineering > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscribe@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. >