Conversion of hammer tests in systest to forklift

ekohl · January 19, 2018, 4:26pm

I’m rewriting the hammer tests in the systest job to ansible for use in forklift. There is code to install additional dependencies but this appears to be unused. Would it be a problem if we left this out for now and just converted the actual hammer tests?

@Tomas_Strachota @mbacovsky @mmoll you might know this.

Relevant code:

github.com

theforeman/foreman-infra/blob/dac43a867c20814948113b646f4e61ade377eace/puppet/modules/jenkins_job_builder/files/theforeman.org/scripts/systest_foreman.sh#L75-L86


if [ $run_hammer_tests = true ]; then
if [ "x$hammer_deps" != "x" ]; then
  echo "cd ~/ && wget https://gist.githubusercontent.com/tstrachota/52b86d7ccf835a11dc99/raw/install_gems.sh" | vagrant ssh $os
  hammer_deps=$(echo -e $hammer_deps | tr "\n" " ")
  echo "Hammer deps: ${hammer_deps}"
  echo "bash ~/install_gems.sh ${hammer_deps}" | vagrant ssh $os
fi


hammer_test_args="HAMMER_TEST_BRANCH=${hammer_tests_branch}"
hammer_test_args="HAMMER_TEST_REPO=https://github.com/${hammer_tests_owner}/hammer-tests.git ${hammer_test_args}"
echo $hammer_test_args fb-hammer-tests.bats | vagrant ssh $os | tee fb-hammer-tests.bats.out
fi

Tomas_Strachota · January 23, 2018, 11:05am

The dependency installation script was meant to be used for pull requests when you want to test multiple dependent contributions together prior to merging them. It’s never been used widely. I’m ok with leaving it out, but I’d like to keep the hammer tests.

ekohl · January 23, 2018, 11:15am

The PR to add hammer tests to forklift is open, without the additional dependencies to keep it simple: