> Greetings,
>
> I'm working on sorting out which v1 controllers need to be converted to v2
> and which are no longer being.
>
> If you know that any of the following controllers are no longer being used
> please let me know.
>
> These v2 API controllers still inherit from v1:
>
> app/controllers/katello/api/v2/about_controller.rb
> app/controllers/katello/api/v2/custom_info_controller.rb
> app/controllers/katello/api/v2/distributors_controller.rb
> app/controllers/katello/api/v2/host_collection_errata_controller.rb
> app/controllers/katello/api/v2/host_collection_packages_controller.rb
> app/controllers/katello/api/v2/organization_default_info_controller.rb
> app/controllers/katello/api/v2/permissions_controller.rb
> app/controllers/katello/api/v2/role_ldap_groups_controller.rb
> app/controllers/katello/api/v2/roles_controller.rb
> Greetings,
>
> I'm working on sorting out which v1 controllers need to be converted to v2
> and which are no longer being.
>
> If you know that any of the following controllers are no longer being used
> please let me know.
>
> These v2 API controllers still inherit from v1:
>
> app/controllers/katello/api/v2/about_controller.rb
> app/controllers/katello/api/v2/custom_info_controller.rb
> app/controllers/katello/api/v2/distributors_controller.rb
> app/controllers/katello/api/v2/host_collection_errata_controller.rb
> app/controllers/katello/api/v2/host_collection_packages_controller.rb
> app/controllers/katello/api/v2/organization_default_info_controller.rb
> app/controllers/katello/api/v2/permissions_controller.rb
> app/controllers/katello/api/v2/role_ldap_groups_controller.rb
> app/controllers/katello/api/v2/roles_controller.rb
> app/controllers/katello/api/v2/root_controller.rb
> app/controllers/katello/api/v2/uebercerts_controller.rb
>
> These v1 API controllers have no v2 counterpart:
>
> app/controllers/katello/api/v1/candlepin_proxies_controller.rb
the candlepin_proxies_controller is technically outside of v1 or v2 because it is in place for compatibility with subscription-manager.
it needs to stay, but i'd argue moving it out of /api/v1/ into just /api/ if possible.
>
>
> > Greetings,
> >
> > I'm working on sorting out which v1 controllers need to be converted to
> v2
> > and which are no longer being.
> >
> > If you know that any of the following controllers are no longer being
> used
> > please let me know.
> >
> > These v2 API controllers still inherit from v1:
> >
> > app/controllers/katello/api/v2/about_controller.rb
> > app/controllers/katello/api/v2/custom_info_controller.rb
> > app/controllers/katello/api/v2/distributors_controller.rb
> > app/controllers/katello/api/v2/host_collection_errata_controller.rb
> > app/controllers/katello/api/v2/host_collection_packages_controller.rb
> > app/controllers/katello/api/v2/organization_default_info_controller.rb
>
> > app/controllers/katello/api/v2/root_controller.rb
> > app/controllers/katello/api/v2/uebercerts_controller.rb
> >
> > These v1 API controllers have no v2 counterpart:
> >
> > app/controllers/katello/api/v1/candlepin_proxies_controller.rb
>
> the candlepin_proxies_controller is technically outside of v1 or v2
> because it is in place for compatibility with subscription-manager.
> it needs to stay, but i'd argue moving it out of /api/v1/ into just /api/
> if possible.
>
> the candlepin_proxies_controller is technically outside of v1 or v2 because it is in place for compatibility with subscription-manager.
> it needs to stay, but i'd argue moving it out of /api/v1/ into just /api/ if possible.
I have never followed the logic for moving candlepin_proxies_controller outside of our v1/v2 APIs. What if we need to version it in the future?
Cheers,
Walden
···
----- Original Message -----
From: "Adam Price"
To: foreman-dev@googlegroups.com
Sent: Thursday, June 19, 2014 10:38:58 AM
Subject: Re: [foreman-dev] Converting remaining v2 API controllers to use Api::V2::ApiController
----- Original Message -----
Greetings,
I’m working on sorting out which v1 controllers need to be converted to v2
and which are no longer being.
If you know that any of the following controllers are no longer being used
please let me know.
the candlepin_proxies_controller is technically outside of v1 or v2 because it is in place for compatibility with subscription-manager.
it needs to stay, but i’d argue moving it out of /api/v1/ into just /api/ if possible.
>
>
>
>
>>
>>
>> > Greetings,
>> >
>> > I'm working on sorting out which v1 controllers need to be converted to
>> v2
>> > and which are no longer being.
>> >
>> > If you know that any of the following controllers are no longer being
>> used
>> > please let me know.
>> >
>> > These v2 API controllers still inherit from v1:
>> >
>> > app/controllers/katello/api/v2/about_controller.rb
>> > app/controllers/katello/api/v2/custom_info_controller.rb
>> > app/controllers/katello/api/v2/distributors_controller.rb
>> > app/controllers/katello/api/v2/host_collection_errata_controller.rb
>> > app/controllers/katello/api/v2/host_collection_packages_controller.rb
>> > app/controllers/katello/api/v2/organization_default_info_controller.rb
>>
>
> These 3:
>
> > app/controllers/katello/api/v2/permissions_controller.rb
>> > app/controllers/katello/api/v2/role_ldap_groups_controller.rb
>> > app/controllers/katello/api/v2/roles_controller.rb
>>
>
> to here can be removed.
>
>
>
>> > app/controllers/katello/api/v2/root_controller.rb
>>
>
I know that RHSM uses the root controller information as it returns a list
of resources. Not sure if anything else uses it or if Foreman provides
something similar and this functionality should be moved into the proxies
controller.
···
On Thu, Jun 19, 2014 at 10:41 AM, Eric D Helms wrote:
> On Thu, Jun 19, 2014 at 10:38 AM, Adam Price wrote:
>> ----- Original Message -----
the candlepin_proxies_controller is technically outside of v1 or v2
because it is in place for compatibility with subscription-manager.
it needs to stay, but i’d argue moving it out of /api/v1/ into just /api/
if possible.
However, using /rhsm/api/v1/ for candlepin_proxies_controller is fine with me.
Walden
···
----- Original Message -----
From: "Walden Raines"
To: foreman-dev@googlegroups.com
Sent: Thursday, June 19, 2014 10:44:30 AM
Subject: Re: [foreman-dev] Converting remaining v2 API controllers to use Api::V2::ApiController
the candlepin_proxies_controller is technically outside of v1 or v2 because it is in place for compatibility with subscription-manager.
it needs to stay, but i’d argue moving it out of /api/v1/ into just /api/ if possible.
I have never followed the logic for moving candlepin_proxies_controller outside of our v1/v2 APIs. What if we need to version it in the future?
Cheers,
Walden
----- Original Message -----
From: “Adam Price” adprice@redhat.com
To: foreman-dev@googlegroups.com
Sent: Thursday, June 19, 2014 10:38:58 AM
Subject: Re: [foreman-dev] Converting remaining v2 API controllers to use Api::V2::ApiController
----- Original Message -----
Greetings,
I’m working on sorting out which v1 controllers need to be converted to v2
and which are no longer being.
If you know that any of the following controllers are no longer being used
please let me know.
the candlepin_proxies_controller is technically outside of v1 or v2 because it is in place for compatibility with subscription-manager.
it needs to stay, but i’d argue moving it out of /api/v1/ into just /api/ if possible.
> > the candlepin_proxies_controller is technically outside of v1 or v2
> because it is in place for compatibility with subscription-manager.
> > it needs to stay, but i'd argue moving it out of /api/v1/ into just
> /api/ if possible.
>
> I have never followed the logic for moving candlepin_proxies_controller
> outside of our v1/v2 APIs. What if we need to version it in the future?
>
We might. But I'd argue that if we do, that versioning is outside our
defined API. As we aren't defining an API with the candlepin proxies, we
are mimicing a third party API that lives outside our API conventions.
Eric
···
On Thu, Jun 19, 2014 at 10:44 AM, Walden Raines wrote:
Cheers,
Walden
----- Original Message -----
From: “Adam Price” adprice@redhat.com
To: foreman-dev@googlegroups.com
Sent: Thursday, June 19, 2014 10:38:58 AM
Subject: Re: [foreman-dev] Converting remaining v2 API controllers to use
Api::V2::ApiController
----- Original Message -----
Greetings,
I’m working on sorting out which v1 controllers need to be converted to
v2
and which are no longer being.
If you know that any of the following controllers are no longer being
used
please let me know.
the candlepin_proxies_controller is technically outside of v1 or v2
because it is in place for compatibility with subscription-manager.
it needs to stay, but i’d argue moving it out of /api/v1/ into just /api/
if possible.
