Cosmetic yumrepo issue in foreman-infra causing large amount of cron mail

I'm getting a lot of mails from the slaves at the moment like the one below.
I'm not super-familiar with the 'yumrepo' puppet resource, but does it just
need a 'name' parameter added to this block?

https://github.com/theforeman/foreman-infra/blob/master/puppet/modules/slave/
manifests/init.pp#L226

Or is it more than that? Happy to send a trivial PR if thats all it is.

Greg

··· ---------- Forwarded Message ----------

Subject: Cron root@slave02 run-parts /etc/cron.hourly
Date: Thursday, 19 January 2017, 16:14:35 GMT
From: (Cron Daemon) root@slave02.rackspace.theforeman.org
To: root@slave02.rackspace.theforeman.org

/etc/cron.hourly/0yum-hourly.cron:

Repository ‘isimluk-openscap’ is missing name in configuration, using id



IRC / Twitter: gwmngilfen
Diaspora: gwmngilfen@joindiaspora.com

Pretty sure adding a name should be all. I'd recommend the same as the ID now to prevent duplicate resources

··· > On 19 Jan 2017, at 16:29, Greg Sutcliffe wrote: > > I'm getting a lot of mails from the slaves at the moment like the one below. > I'm not super-familiar with the 'yumrepo' puppet resource, but does it just > need a 'name' parameter added to this block? > > https://github.com/theforeman/foreman-infra/blob/master/puppet/modules/slave/ > manifests/init.pp#L226 > > Or is it more than that? Happy to send a trivial PR if thats all it is. > > Greg > > ---------- Forwarded Message ---------- > > Subject: Cron run-parts /etc/cron.hourly > Date: Thursday, 19 January 2017, 16:14:35 GMT > From: (Cron Daemon) > To: root@slave02.rackspace.theforeman.org > > /etc/cron.hourly/0yum-hourly.cron: > > Repository 'isimluk-openscap' is missing name in configuration, using id > > ----------------------------------------- > > -- > IRC / Twitter: gwmngilfen > Diaspora: gwmngilfen@joindiaspora.com > > -- > You received this message because you are subscribed to the Google Groups "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscribe@googlegroups.com. > For more options, visit https://groups.google.com/d/optout.

Thanks, https://github.com/theforeman/foreman-infra/pull/271 submitted.

Greg

··· On Thursday, 19 January 2017 16:45:00 GMT Ewoud Kohl van Wijngaarden wrote: > Pretty sure adding a name should be all. I'd recommend the same as the ID > now to prevent duplicate resources