Develop frozen until #812/##1070 lands

Development
1

The permissions branch from PR 1070 is approaching merge this week, so
other PRs won't be merged until this one lands to prevent any more
rebase work.

PRs I'm happy with otherwise will be labelled "ready to merge" and we'll
re-test and merge them after.

··· -- Dominic Cleal Red Hat Engineering
2

Dominic+++++++++++++++++++++++++++++++++++++

I'll look at broken tests (after last rebase) tomorrow. Not sure about katello
tests which were added recently.

··· On Tuesday 25 of February 2014 10:36:03 Dominic Cleal wrote: > The permissions branch from PR 1070 is approaching merge this week, so > other PRs won't be merged until this one lands to prevent any more > rebase work. > > PRs I'm happy with otherwise will be labelled "ready to merge" and we'll > re-test and merge them after.

–
Marek

3

The permissions changes have been merged into develop, so we're open for
business again.

If you have a PR open, please rebase it so we know the tests have run on
the current state of develop.

··· On 25/02/14 10:36, Dominic Cleal wrote: > The permissions branch from PR 1070 is approaching merge this week, so > other PRs won't be merged until this one lands to prevent any more > rebase work. > > PRs I'm happy with otherwise will be labelled "ready to merge" and we'll > re-test and merge them after.

–
Dominic Cleal
Red Hat Engineering

4

Perhaps somebody from the Katello project would be kind enough to fix
those before merge?

If anybody else has time over the next day or two to dedicate to testing
this PR, it'd be much appreciated. Check that the migration works,
check that combinations of permissions and filters work correctly, look
for edge cases etc and report back.

··· On 25/02/14 17:03, Marek Hulan wrote: > On Tuesday 25 of February 2014 10:36:03 Dominic Cleal wrote: >> The permissions branch from PR 1070 is approaching merge this week, so >> other PRs won't be merged until this one lands to prevent any more >> rebase work. >> >> PRs I'm happy with otherwise will be labelled "ready to merge" and we'll >> re-test and merge them after. > > Dominic+++++++++++++++++++++++++++++++++++++ > > I'll look at broken tests (after last rebase) tomorrow. Not sure about katello > tests which were added recently.

–
Dominic Cleal
Red Hat Engineering

5

Looks like a name clash on the Filter factory to which we could re-name the
Katello one to be namespaced which I can try out in an environment I have
set up.

-Eric

··· On Tue, Feb 25, 2014 at 1:28 PM, Dominic Cleal wrote:

On 25/02/14 17:03, Marek Hulan wrote:

On Tuesday 25 of February 2014 10:36:03 Dominic Cleal wrote:

The permissions branch from PR 1070 is approaching merge this week, so
other PRs won’t be merged until this one lands to prevent any more
rebase work.

PRs I’m happy with otherwise will be labelled “ready to merge” and we’ll
re-test and merge them after.

Dominic+++++++++++++++++++++++++++++++++++++

I’ll look at broken tests (after last rebase) tomorrow. Not sure about
katello
tests which were added recently.

Perhaps somebody from the Katello project would be kind enough to fix
those before merge?

If anybody else has time over the next day or two to dedicate to testing
this PR, it’d be much appreciated. Check that the migration works,
check that combinations of permissions and filters work correctly, look
for edge cases etc and report back.

https://github.com/theforeman/foreman/pull/1070

–
Dominic Cleal
Red Hat Engineering

–
You received this message because you are subscribed to the Google Groups
“foreman-dev” group.
To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.