DHCP filename option no longer honored

Development
1

Hey,

I noticed that DHCP filename option is no longer honored in
develop/1.17 branch anymore. This is regression from 1.15/1.16 series,
filed a blocker bug for 1.17:

http://projects.theforeman.org/issues/21975

This breaks UEFI provisioning. I git-bisected

commit e75df1dd3cc30bff2832d337b5bc20bd822e209a
Refs:
Author: Timo Goebel <mail@timogoebel.name>
AuthorDate: Wed Oct 25 16:26:01 2017 +0200
Commit: Dmitri Dolguikh <witlessbird@gmail.com>
CommitDate: Mon Nov 6 14:28:09 2017 -0800

But I cannot figure it out, help needed. Thanks.

···

--
Later,
  Lukas @lzap Zapletal

2

Hi,

Dimitri sent a patch that should fix the problem. It's just a one line change, so we just need to test it and it should be ready to merge.

However, we should check what change really introduced the problem to see if this needs backporting to 1.16. I have some doubts it was the change mentioned below.

Lukas, can you please confirm the patch fixes the issue for you?

Timo

···

Am 14.12.17 um 14:21 schrieb Lukas Zapletal:

Hey,

I noticed that DHCP filename option is no longer honored in
develop/1.17 branch anymore. This is regression from 1.15/1.16 series,
filed a blocker bug for 1.17:

Bug #21975: DHCP filename option is ignored - Smart Proxy - Foreman

This breaks UEFI provisioning. I git-bisected

commit e75df1dd3cc30bff2832d337b5bc20bd822e209a
Refs:
Author: Timo Goebel <mail@timogoebel.name>
AuthorDate: Wed Oct 25 16:26:01 2017 +0200
Commit: Dmitri Dolguikh <witlessbird@gmail.com>
CommitDate: Mon Nov 6 14:28:09 2017 -0800

But I cannot figure it out, help needed. Thanks.

3

Thanks a bunch, will test and merge.

I already checked 1.16/1.15 this is develop only.

LZ

···

On Fri, Dec 15, 2017 at 7:08 AM, Timo Goebel <mail@timogoebel.name> wrote:

Hi,

Dimitri sent a patch that should fix the problem. It's just a one line
change, so we just need to test it and it should be ready to merge.

However, we should check what change really introduced the problem to see if
this needs backporting to 1.16. I have some doubts it was the change
mentioned below.

Lukas, can you please confirm the patch fixes the issue for you?

Timo

Am 14.12.17 um 14:21 schrieb Lukas Zapletal:

Hey,

I noticed that DHCP filename option is no longer honored in
develop/1.17 branch anymore. This is regression from 1.15/1.16 series,
filed a blocker bug for 1.17:

Bug #21975: DHCP filename option is ignored - Smart Proxy - Foreman

This breaks UEFI provisioning. I git-bisected

commit e75df1dd3cc30bff2832d337b5bc20bd822e209a
Refs:
Author: Timo Goebel <mail@timogoebel.name>
AuthorDate: Wed Oct 25 16:26:01 2017 +0200
Commit: Dmitri Dolguikh <witlessbird@gmail.com>
CommitDate: Mon Nov 6 14:28:09 2017 -0800

But I cannot figure it out, help needed. Thanks.

--
You received this message because you are subscribed to the Google Groups
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
Later,
  Lukas @lzap Zapletal