Edit Locations Parameters for Non-Admin

Howdy,

Using Foreman 1.10.2-el7, I noticed that non-admins are unable to access
parameters within the "Edit Locations" section when adding all parameter
permissions from within the UI.
Reviewing the filter permissions for the Parameters category, it appears
the "view_params" permission does not show up which is needed for this
feature to be shown to non-admins.

I've added the view_params permission into the permissions table then added
the view_params permission to the role and everything worked as expected :slight_smile:
insert into permissions (name,resource_type,created_at,updated_at) values
('view_params','Parameter',NOW(),NOW());

I'm unsure if this permission has been deprecated and needs to be altered
within app/views/taxonomies/_form.html.erb or if we need to alter
the seeds.d/03-permissions.rb to include the perm.

Just giving a heads up!

Thanks,
James

Looks like a bug then, could you file it at
Foreman please?

It may also be linked or the same as #13164 but there's no info on that
about what the problem is exactly. The PR for that was closed, but it
could be revisited and used in the other forms too for consistency.

··· On 10/03/16 20:48, James Vess wrote: > Howdy, > > Using Foreman 1.10.2-el7, I noticed that non-admins are unable to access > parameters within the "Edit Locations" section when adding all parameter > permissions from within the UI. > Reviewing the filter permissions for the Parameters category, it appears > the "view_params" permission does not show up which is needed for this > feature to be shown to non-admins. > > I've added the view_params permission into the permissions table then > added the view_params permission to the role and everything worked as > expected :) > insert into permissions (name,resource_type,created_at,updated_at) > values ('view_params','Parameter',NOW(),NOW()); > > I'm unsure if this permission has been deprecated and needs to be > altered within app/views/taxonomies/_form.html.erb or if we need to > alter the seeds.d/03-permissions.rb to include the perm.


Dominic Cleal
dominic@cleal.org

>
> > Howdy,
> >
> > Using Foreman 1.10.2-el7, I noticed that non-admins are unable to access
> > parameters within the "Edit Locations" section when adding all parameter
> > permissions from within the UI.
> > Reviewing the filter permissions for the Parameters category, it appears
> > the "view_params" permission does not show up which is needed for this
> > feature to be shown to non-admins.
> >
> > I've added the view_params permission into the permissions table then
> > added the view_params permission to the role and everything worked as
> > expected :slight_smile:
> > insert into permissions (name,resource_type,created_at,updated_at)
> > values ('view_params','Parameter',NOW(),NOW());
> >
> > I'm unsure if this permission has been deprecated and needs to be
> > altered within app/views/taxonomies/_form.html.erb or if we need to
> > alter the seeds.d/03-permissions.rb to include the perm.
>
> Looks like a bug then, could you file it at
> Foreman please?
>
> It may also be linked or the same as #13164 but there's no info on that
> about what the problem is exactly.

Bug #13164: view_params is missing - Foreman is this exact issue -
view_params permission whilst referenced in a number of templates actually
had no entry. Details are
in https://bugzilla.redhat.com/show_bug.cgi?id=1296662

··· On Friday, March 11, 2016 at 4:11:13 AM UTC-5, Dominic Cleal wrote: > On 10/03/16 20:48, James Vess wrote:

The PR for that was closed, but it
could be revisited and used in the other forms too for consistency.


Dominic Cleal
dom...@cleal.org <javascript:>