Error "must be downcase"

In our production environment, some host use upper case hostname ,like
"", when edit this host ,submit change,error happen, "must
be downcase" show on the hostname felid.

Now,I change the file  /usr/share/foreman/app/models/host.rb. Add 

comment at line "validate :is_name_downcased?"
#validate :is_name_downcased?

Restart foreman instance ,Error don't happen again.

My question, Can I do this change.


Tim ding


it is very good idea to keep all your DNS records downcase, because DNS
is not case sensitive. What is the reason to have upper hostnames? Like
to warn you that this is a production system?

Anyway, it does not matter if you type or If you need to have some sticky information like flags
with your host records, raise a feature request for it.

> My question, Can I do this change.

Better to ask on the devel list, you can at least try to file a pull
request with that change and we can discuss it. For myself, I tend to
prefer sane defaults, but this could be optional (option in global
settings like "Allow upper case host names" could be fine.

··· -- Later,

Lukas “lzap” Zapletal
irc: lzap #theforeman