First let me say overall the UI looks great.
Two issues:
- I liked the red error icon for reports rather than grey, as the red
icon really stood out. Right now it is pretty similar to the grey "No
report" icon.
- It seems the dashboard "Good Host Reports in the last 30 minutes"
is off. It is including hosts in error state in the metric "N / X
hosts".
Can someone else confirm?
Thanks,
Brian
> First let me say overall the UI looks great.
>
> Two issues:
> 1) I liked the red error icon for reports rather than grey, as the red
> icon really stood out. Right now it is pretty similar to the grey "No
> report" icon.
thanks, was a typo – fixed.
> 2) It seems the dashboard "Good Host Reports in the last 30 minutes"
> is off. It is including hosts in error state in the metric "N / X
> hosts".
I can't reproduce this one, any screenshots etc? we did not change any
of that logic.
Thanks,
Ohad
···
On 04/29/2012 11:22 PM, Brian Gupta wrote:
OK take a look at "Good Host Reports in the last 30 minutes." It shows 51 / 72.
If I click on the "Good Host Reports in the last 30 minutes." It only
shows 28, which corresponds to the 28 "OK" hosts in the graph on the
dashboard.
I figured out that 51 / 72, is an actual aggregation of of "Active"
and "OK", which I think is ok, if it didn't exclude the "Active" hosts
when you click on the link.
Do you understand?
Thanks,
Brian
···
On Sun, Apr 29, 2012 at 4:49 PM, Ohad Levy wrote:
> On 04/29/2012 11:22 PM, Brian Gupta wrote:
>>
>> First let me say overall the UI looks great.
>>
>> Two issues:
>> 1) I liked the red error icon for reports rather than grey, as the red
>> icon really stood out. Right now it is pretty similar to the grey "No
>> report" icon.
>
> thanks, was a typo -- fixed.
>
>> 2) It seems the dashboard "Good Host Reports in the last 30 minutes"
>> is off. It is including hosts in error state in the metric "N / X
>> hosts".
>
> I can't reproduce this one, any screenshots etc? we did not change any of
> that logic.
>
> Thanks,
> Ohad
To clarify, I am not certain if the behavior has changed, or if I have
just noticed this. The "Good hosts in the past 30 mins" link generates
the search:
last_report > "30 minutes ago" and status.enabled = true and
status.interesting=false
The metric N / Z for "Good Host Reports in the last 30 minutes.",
seems to be including "Ok" hosts and "Active" hosts, but unfortunately
"Active" hosts that are in error state.
Thanks,
Brian
···
On Sun, Apr 29, 2012 at 5:06 PM, Brian Gupta wrote:
> OK take a look at "Good Host Reports in the last 30 minutes." It shows 51 / 72.
>
> If I click on the "Good Host Reports in the last 30 minutes." It only
> shows 28, which corresponds to the 28 "OK" hosts in the graph on the
> dashboard.
>
> I figured out that 51 / 72, is an actual aggregation of of "Active"
> and "OK", which I think is ok, if it didn't exclude the "Active" hosts
> when you click on the link.
>
> Do you understand?
>
> Thanks,
> Brian
>
>
> On Sun, Apr 29, 2012 at 4:49 PM, Ohad Levy wrote:
>> On 04/29/2012 11:22 PM, Brian Gupta wrote:
>>>
>>> First let me say overall the UI looks great.
>>>
>>> Two issues:
>>> 1) I liked the red error icon for reports rather than grey, as the red
>>> icon really stood out. Right now it is pretty similar to the grey "No
>>> report" icon.
>>
>> thanks, was a typo -- fixed.
>>
>>> 2) It seems the dashboard "Good Host Reports in the last 30 minutes"
>>> is off. It is including hosts in error state in the metric "N / X
>>> hosts".
>>
>> I can't reproduce this one, any screenshots etc? we did not change any of
>> that logic.
>>
>> Thanks,
>> Ohad
Also, now that I am looking at this with a fine toothed comb, I notice
the dashboard metric for hosts with no reports is wrong. It is showing
1 host in the metric, but if I drill down the following search come
back with a list of 9 hosts: not has last_report
Not sure where this discrepancy is coming from, but I am fairly
certain it is not new behavior.
Thanks,
Brain
···
On Sun, Apr 29, 2012 at 5:46 PM, Brian Gupta wrote:
> To clarify, I am not certain if the behavior has changed, or if I have
> just noticed this. The "Good hosts in the past 30 mins" link generates
> the search:
> last_report > "30 minutes ago" and status.enabled = true and
> status.interesting=false
>
> The metric N / Z for "Good Host Reports in the last 30 minutes.",
> seems to be including "Ok" hosts and "Active" hosts, but unfortunately
> "Active" hosts that are in error state.
>
> Thanks,
> Brian
>
> On Sun, Apr 29, 2012 at 5:06 PM, Brian Gupta wrote:
>> OK take a look at "Good Host Reports in the last 30 minutes." It shows 51 / 72.
>>
>> If I click on the "Good Host Reports in the last 30 minutes." It only
>> shows 28, which corresponds to the 28 "OK" hosts in the graph on the
>> dashboard.
>>
>> I figured out that 51 / 72, is an actual aggregation of of "Active"
>> and "OK", which I think is ok, if it didn't exclude the "Active" hosts
>> when you click on the link.
>>
>> Do you understand?
>>
>> Thanks,
>> Brian
>>
>>
>> On Sun, Apr 29, 2012 at 4:49 PM, Ohad Levy wrote:
>>> On 04/29/2012 11:22 PM, Brian Gupta wrote:
>>>>
>>>> First let me say overall the UI looks great.
>>>>
>>>> Two issues:
>>>> 1) I liked the red error icon for reports rather than grey, as the red
>>>> icon really stood out. Right now it is pretty similar to the grey "No
>>>> report" icon.
>>>
>>> thanks, was a typo -- fixed.
>>>
>>>> 2) It seems the dashboard "Good Host Reports in the last 30 minutes"
>>>> is off. It is including hosts in error state in the metric "N / X
>>>> hosts".
>>>
>>> I can't reproduce this one, any screenshots etc? we did not change any of
>>> that logic.
>>>
>>> Thanks,
>>> Ohad
Looking at the dashboard controller code I believe these two
discrepancies are related as:
@report[:reports_missing] = @report[:total_hosts] -
@report[:good_hosts] - @report[:bad_hosts] -
@report[:out_of_sync_hosts] - @report[:pending_hosts]
and
@report[:good_hosts] = @report[:ok_hosts] + @report[:active_hosts]
The fact that active_hosts also returns bad_hosts is the key to this
discrepancy in both dashboard metrics.
I'm not sure what the answer is but perhaps we want to fix active
hosts, so that it doesn't return hosts that are bad_hosts. Right now
it is just:
:active_hosts => @hosts.recent.with_changes.count,
Thanks,
Brian
···
On Sun, Apr 29, 2012 at 6:03 PM, Brian Gupta wrote:
> Also, now that I am looking at this with a fine toothed comb, I notice
> the dashboard metric for hosts with no reports is wrong. It is showing
> 1 host in the metric, but if I drill down the following search come
> back with a list of 9 hosts: not has last_report
>
> Not sure where this discrepancy is coming from, but I am fairly
> certain it is not new behavior.
>
> Thanks,
> Brain
>
>
> On Sun, Apr 29, 2012 at 5:46 PM, Brian Gupta wrote:
>> To clarify, I am not certain if the behavior has changed, or if I have
>> just noticed this. The "Good hosts in the past 30 mins" link generates
>> the search:
>> last_report > "30 minutes ago" and status.enabled = true and
>> status.interesting=false
>>
>> The metric N / Z for "Good Host Reports in the last 30 minutes.",
>> seems to be including "Ok" hosts and "Active" hosts, but unfortunately
>> "Active" hosts that are in error state.
>>
>> Thanks,
>> Brian
>>
>> On Sun, Apr 29, 2012 at 5:06 PM, Brian Gupta wrote:
>>> OK take a look at "Good Host Reports in the last 30 minutes." It shows 51 / 72.
>>>
>>> If I click on the "Good Host Reports in the last 30 minutes." It only
>>> shows 28, which corresponds to the 28 "OK" hosts in the graph on the
>>> dashboard.
>>>
>>> I figured out that 51 / 72, is an actual aggregation of of "Active"
>>> and "OK", which I think is ok, if it didn't exclude the "Active" hosts
>>> when you click on the link.
>>>
>>> Do you understand?
>>>
>>> Thanks,
>>> Brian
>>>
>>>
>>> On Sun, Apr 29, 2012 at 4:49 PM, Ohad Levy wrote:
>>>> On 04/29/2012 11:22 PM, Brian Gupta wrote:
>>>>>
>>>>> First let me say overall the UI looks great.
>>>>>
>>>>> Two issues:
>>>>> 1) I liked the red error icon for reports rather than grey, as the red
>>>>> icon really stood out. Right now it is pretty similar to the grey "No
>>>>> report" icon.
>>>>
>>>> thanks, was a typo -- fixed.
>>>>
>>>>> 2) It seems the dashboard "Good Host Reports in the last 30 minutes"
>>>>> is off. It is including hosts in error state in the metric "N / X
>>>>> hosts".
>>>>
>>>> I can't reproduce this one, any screenshots etc? we did not change any of
>>>> that logic.
>>>>
>>>> Thanks,
>>>> Ohad
