after import of community templates the list of provisioning templates
grows twice. This is because of our naming conventions, we prefix all
the community templates with "Community". The fact is the content is the
same (we merge community templates into the foreman git repo before each
release).
Are there any objections to synchronize names? I'd like to prepare a
patch that would read "name" header from the templates during database
seed.
We can either decide to keep the "Community" prefix or to rename those
in the community-templates git repo.
> Hey,
>
> after import of community templates the list of provisioning templates
> grows twice. This is because of our naming conventions, we prefix all
> the community templates with "Community". The fact is the content is the
> same (we merge community templates into the foreman git repo before each
> release).
>
> Are there any objections to synchronize names? I'd like to prepare a
> patch that would read "name" header from the templates during database
> seed.
I'd really rather this code was not in Foreman core, it's specific to
foreman_templates at the moment.
> We can either decide to keep the "Community" prefix or to rename those
> in the community-templates git repo.
Seems best to me to fix the community-template names so they're the same
(mea culpa, I meant to do this) and then either (optionally) remove the
prefix within foreman_templates or in the repo itself.
> Seems best to me to fix the community-template names so they're the same
> (mea culpa, I meant to do this) and then either (optionally) remove the
> prefix within foreman_templates or in the repo itself.
If there are no objections, I am gonna put this on my TODO.
If you change the default prefix to an empty string in
foreman_templates, that will probably do most of what you want. Then
it's just a few template renames.
···
On 5 March 2014 13:56, Lukas Zapletal wrote:
>> Seems best to me to fix the community-template names so they're the same
>> (mea culpa, I meant to do this) and then either (optionally) remove the
>> prefix within foreman_templates or in the repo itself.
>
> If there are no objections, I am gonna put this on my TODO.
Can't we add directories to differenciate templates' sources? Directories are
the usual way to organise files =)
I understand it is way more complex to code as just rename files.
Claer
···
On Wed, Mar 05 2014 at 42:16, Greg Sutcliffe wrote:
> On 5 March 2014 13:56, Lukas Zapletal wrote:
> >> Seems best to me to fix the community-template names so they're the same
> >> (mea culpa, I meant to do this) and then either (optionally) remove the
> >> prefix within foreman_templates or in the repo itself.
> >
> > If there are no objections, I am gonna put this on my TODO.
>
> If you change the default prefix to an empty string in
> foreman_templates, that will probably do most of what you want. Then
> it's just a few template renames.
> Can't we add directories to differenciate templates' sources? Directories are
> the usual way to organise files =)
> I understand it is way more complex to code as just rename files.
This is done already.
That would add complexity I guess, I like it how it works today. You can
always delete those templates you do not use. Import is now so easy with
Greg's rake task.
