Foreman_bootdisk ISO9660 generation

David_Schmitt · February 12, 2015, 2:14pm

Hi,

In [1], the iso_generator creates a file name that may have at most 30
characters by concatenating two strings, which can both be up to 30
chars in length. Which, as you might have guessed, fails to create a
consistent boot image on my system.

As a workaround I've reduced the max length in iso9660_filename to 10,
which, at least, led to a booting ISO.

Re-reading the code, it'd probably make more sense to first concatenate
f[0].to_s and suffix and then run it through iso9660_filename.

This is happening on foreman-1.6.2-1.el6 from the 1.6 repo and
ruby193-rubygem-foreman_bootdisk-3.2.1-1.el6 from foreman-plugins-1.6
repo, running on Scientific Linux release 6.5 (Carbon).

Regards, David

[1]

github.com

theforeman/foreman_bootdisk/blob/master/app/services/foreman_bootdisk/iso_generator.rb#L24


  raise ::Foreman::Exception.new(N_('Unable to generate disk template: %s'), host.errors.full_messages.to_sentence) if tmpl == false


  # pxe_files and filename conversion is utterly bizarre
  # aim to convert filenames to something usable under ISO 9660, update the template to match
  # and then still ensure that the fetch() process stores them under the same name
  files = host.operatingsystem.pxe_files(host.medium, host.architecture, host)
  files.map! do |bootfile_info|
    bootfile_info.map do |f|
      suffix = f[1].split('/').last
      iso_f0 = iso9660_filename(f[0].to_s + '_' + suffix)
      tmpl.gsub!(f[0].to_s + '-' + suffix, iso_f0)
      ForemanBootdisk.logger.debug("Boot file #{iso_f0}, source #{f[1]}")
      [iso_f0, f[1]]
    end
  end


  generate(opts.merge(:isolinux => tmpl, :files => files), &block)
end


def self.generate(opts = {}, &block)
  opts[:isolinux] = <<-EOS if opts[:isolinux].nil? && opts[:ipxe]

Dominic_Cleal · February 16, 2015, 8:15am

Could you file this in our bug tracker please?

http://projects.theforeman.org/projects/bootdisk/issues/new

···

On 12/02/15 14:14, David Schmitt wrote: > Hi, > > In [1], the iso_generator creates a file name that may have at most 30 > characters by concatenating two strings, which can both be up to 30 > chars in length. Which, as you might have guessed, fails to create a > consistent boot image on my system. > > As a workaround I've reduced the max length in iso9660_filename to 10, > which, at least, led to a booting ISO. > > > Re-reading the code, it'd probably make more sense to first concatenate > f[0].to_s and suffix and *then* run it through iso9660_filename.

–
Dominic Cleal
Red Hat Engineering