Foreman/develop has new results

Development
1

Would anyone find a service like this valuable? Or rather that's rubocop
/other ci task?

Thanks,
Ohad

··· ---------- Forwarded message ---------- From: "Codacy" Date: Feb 12, 2016 06:17 Subject: foreman/develop has new results To: Cc:

[image: Logo]
Not so good… This commit quality could be better.
See commit details
https://u778210.ct.sendgrid.net/wf/click?upn=liTJw24Vxo6SjoUA-2B0mVU5OGzs7RT5rrhwfKHv8TQUBlv8KNzp8rNOAj1CLZD9gW6SZeb7sX8fyCF1gwO7QcFf9Vfc85BnItBeDdSAhhuJBin8qRZOKy-2FWXH0T760jhS_io3OvfrFl4VUy8eM2pi4zPSM8XkD0W8o4l7Ncti-2F2WAhgT2A7jCautmO-2FTJNRAQ-2FY6eGVMDoK2hpUHhfxpBTHMFYfWNT1OhS-2FGtQQsETFr0d6t45eKeTWyTI1JDPwrsQVU7HcRO-2FKwsiHshFX-2B89d7iYEWHeyUsLAFfTDcSMsyqRVA8JGCnec1Skuh1ctaOtYup2zICXzaCFB23N5ceDJA-3D-3D"btn"
[image: Avatar] Timo Goebel commited 5131edb
https://u778210.ct.sendgrid.net/wf/click?upn=liTJw24Vxo6SjoUA-2B0mVU5OGzs7RT5rrhwfKHv8TQUBlv8KNzp8rNOAj1CLZD9gW6SZeb7sX8fyCF1gwO7QcFf9Vfc85BnItBeDdSAhhuJBin8qRZOKy-2FWXH0T760jhS_io3OvfrFl4VUy8eM2pi4zPSM8XkD0W8o4l7Ncti-2F2WAhgT2A7jCautmO-2FTJNRAQ-2FqeX-2B8E1-2F2hu82F10eb6GWtKpBbJeC2IIyV1xQsJzVKaJ6FpFqbFuPI0rcrWiKUEBPJgjEPDZViwak8UZC7vc-2FYH-2Bom08Uzq-2FuTZI1vrrWLVtlihkrLN5EKuCiolitJl0v1Q8rZH-2FYUir6Wkrrhh9hQ-3D-3D"link"
01 Feb 2016 - 1:09:42PM
fixes #13494 - change puppet proxy for several hosts at once
Evolution Project Grade
6
New Issues 4
Fixed Issues =
Coverage =
Complexity =
Duplication [image: Grade]

See commit details
https://u778210.ct.sendgrid.net/wf/click?upn=liTJw24Vxo6SjoUA-2B0mVU5OGzs7RT5rrhwfKHv8TQUBlv8KNzp8rNOAj1CLZD9gW6SZeb7sX8fyCF1gwO7QcFf9Vfc85BnItBeDdSAhhuJBin8qRZOKy-2FWXH0T760jhS_io3OvfrFl4VUy8eM2pi4zPSM8XkD0W8o4l7Ncti-2F2WAhgT2A7jCautmO-2FTJNRAQ-2FrnjQ10PgdCjjpbrq6qg0r76mPg9S0hoTSVJqNJpxrFG9HsWMHFD-2Fpeftx6tBTJxY1yxKH4x-2Bzhu3oFunIZMDcmvYZGOnBXkiuwhBwi9Utjis-2BeFTPQjGjSiInJFq14eNODGa-2FLzqyrv8GBnEPQDD9A-3D-3D"btn"
If you are no longer interested, you can unsubscribe here
https://u778210.ct.sendgrid.net/wf/click?upn=liTJw24Vxo6SjoUA-2B0mVUwaonsz723Ipl5EK7W65ijTmzMspImq8OGSPzPcPSuYBL-2BueHoMb1Tlhe1MFFK-2Ff4w-3D-3D_io3OvfrFl4VUy8eM2pi4zPSM8XkD0W8o4l7Ncti-2F2WAhgT2A7jCautmO-2FTJNRAQ-2FCy9dwv-2B7SdRMILgcnLy6lAl901UnMBB-2BazTNKFXmhVGRw99wj5xpW1-2FvjBuf8wognbzd-2BhK6iHyUVmkOQ6UWwXCegGp8v30NmfeKc7L0AZH1Bj4HR264skPKm0pCK8ocTtvTASEHbXRm7uxtj9bGag-3D-3D
.

2

It appears to be using rubocop and brakeman, but we already do run
rubocop (probably with different settings to that site).

You could easily add brakeman to the test tasks, so we're not reliant on
a third party service and also are able to get the results both locally
when developing and during code review, not after the fact.

··· On 12/02/16 08:23, Ohad Levy wrote: > Would anyone find a service like this valuable? Or rather that's rubocop > /other ci task?

–
Dominic Cleal
dominic@cleal.org

3

I would also stay away from automated code critique — my concern it
could be dispiriting for contributors who are trying their hand at it
for the first time, etc. Might be useful to track daily changes in
develop/master branch though.

-d

··· On Fri, Feb 12, 2016 at 8:28 AM, Dominic Cleal wrote: > On 12/02/16 08:23, Ohad Levy wrote: >> Would anyone find a service like this valuable? Or rather that's rubocop >> /other ci task? > > It appears to be using rubocop and brakeman, but we already do run > rubocop (probably with different settings to that site). > > You could easily add brakeman to the test tasks, so we're not reliant on > a third party service and also are able to get the results both locally > when developing and during code review, not after the fact. > > -- > Dominic Cleal > dominic@cleal.org > > -- > You received this message because you are subscribed to the Google Groups "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscribe@googlegroups.com. > For more options, visit https://groups.google.com/d/optout.
4

Not particularly - I tend to agree with Dominic just adding brakeman
should suffice.

I'd like to use http://coveralls.io/ though.

··· On 02/12, Ohad Levy wrote: > Would anyone find a service like this valuable? Or rather that's rubocop > /other ci task? >

–
Daniel Lobato Garcia

@dLobatog
blog.daniellobato.me
daniellobato.me

GPG: http://keys.gnupg.net/pks/lookup?op=get&search=0x7A92D6DD38D6DE30
Keybase: https://keybase.io/elobato

5

I kind of like code climate better than coveralls. It still uses simplecov
but it also has some additional checks like code duplication and
complexity. Plus it has graphs and trend information. Here’s the rubocop
project as an example which switched to code climate last year from
coveralls.

Code Climate
https://codeclimate.com/github/bbatsov/rubocop

Coveralls

David

··· On Fri, Feb 12, 2016 at 4:38 AM, Daniel Lobato Garcia wrote:

On 02/12, Ohad Levy wrote:

Would anyone find a service like this valuable? Or rather that’s rubocop
/other ci task?

Not particularly - I tend to agree with Dominic just adding brakeman
should suffice.

I’d like to use http://coveralls.io/ though.

–
Daniel Lobato Garcia

@dLobatog
blog.daniellobato.me
daniellobato.me

GPG: http://keys.gnupg.net/pks/lookup?op=get&search=0x7A92D6DD38D6DE30
Keybase: elobato (Daniel Lobato Garcia) | Keybase

–
You received this message because you are subscribed to the Google Groups
“foreman-dev” group.
To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.