foreman-develop-package-release 928 failed

Infra & CI
1

foreman package release pipeline failed:

https://ci.theforeman.org/job/foreman-develop-package-release/928/

2 
ModuleNotFoundError: Module not found: Error: Can't resolve '@patternfly/react-icons/dist/js/icons/exclamation-circle-icon' in '/builddir/build/BUILD/foreman-2.5.0-develop/webpack/assets/javascripts/react_app/routes/RegistrationCommands/RegistrationCommandsPage/components'

introduced here:

https://github.com/theforeman/foreman/commit/7f25f3941f2a96240841aeb0903c46c28da8b212#diff-eb353b3ca6d169929f510175e9121e4991db5d259bf1357a9c787c189d582febR11

3

ModuleNotFoundError: Module not found: Error: Can’t resolve ‘@patternfly/react-icons/dist/js/icons/exclamation-circle-icon’ in ‘/builddir/build/BUILD/foreman-2.5.0-develop/webpack/assets/javascripts/react_app/routes/RegistrationCommands/RegistrationCommandsPage/components’

maybe import { ExclamationCircleIcon } from '@patternfly/react-icons'; will fix it?

4

I remember we had a very similar issue with pf/react-icons before, but can’t remember what the fix was.

Might be worth searching history here and in git.

5

this one is a freshly new component, though if it happens a lot, we could explore adding a lint rule for it as @tbrisker suggested on the PR

6

And now that I searched for it, the old fix was similar:
https://github.com/theforeman/foreman/pull/8190/files

So let’s try your suggestion

7

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.