Foreman-develop-source-release 2291 failed

jenkins · August 2, 2024, 3:49pm

foreman source release pipeline failed:

https://ci.theforeman.org/job/foreman-develop-source-release/2291/

ekohl · August 2, 2024, 4:38pm

This test has been failing intermittently recently. This is using the nic_managed factory:

theforeman/foreman/blob/6aac916fb183f47596e8d543756faac27750a21e/test/factories/host_related.rb#L80-L92


      
          factory :nic_managed, :class => Nic::Managed, :parent => :nic_interface do
            type { 'Nic::Managed' }
            sequence(:mac) { |n| "00:33:45:ab:" + n.to_s(16).rjust(4, '0').insert(2, ':') }
            sequence(:ip) { |n| IPAddr.new((subnet.present? ? subnet.ipaddr.to_i : 0) + n, Socket::AF_INET).to_s }
          
            trait :without_ipv4 do
              ip { nil }
            end
          
            trait :with_ipv6 do
              sequence(:ip6) { |n| Array.new(4) { '%x' % rand(16**4) }.join(':') + '::' + n.to_s }
            end
          end

Critical line is that it tries to add an IP from a the subnet as a sequence. My theory is that we have enough tests that sometimes it creates an IP outside of the range. IP in question is 10.10.11.39 which is indeed outside of 10.10.10.0/24. It somehow needs to take that into account. Probably with a modulo.

This is something I already noticed in the past but never really submitted a proper PR for. I started with Refactor smart_proxy factories and tests by ekohl · Pull Request #10143 · theforeman/foreman · GitHub because the host factories are such a mess.

Now I’ve opened one: Fixes #37711 - Properly derive an IP from subnets in test factories by ekohl · Pull Request #10263 · theforeman/foreman · GitHub

system · August 9, 2024, 4:39pm

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.