foreman-develop-source-release 951 failed

jenkins · December 2, 2020, 11:11am

foreman source release pipeline failed:

tbrisker · December 2, 2020, 12:00pm

Looks like this change broke tests:

github.com/theforeman/foreman

Fixes #30670 - start dynflow client in report tasks

theforeman:develop ← ares:fix/30670

opened 10:11AM - 01 Dec 20 UTC

ares

+3 -3

As reported, a single foreman-rake reports:daily in fact triggers the rake task… twice. This is caused by plugins that need to extend this (and similar tasks) with their own logic and add other rake tasks dependencies. For that they need to `load` our core tasks, causing the duplication. `load` should be avoided entirely. In this specific case though, the need was to add dynflow:client dependecy to reports, since Katello plugin may schedule some dynflow job as part of that. Therefore it needs client connection to dynflow. This task does not start the executor. Instead of asking all plugins to add such dependency if their custom mail notification requires dynflow client, the Foreman core should offer this by default. The real fix needs to land in Katello, it should no longer load the core task definition, however in order for that to be possible, this PR needs to be merged first. What was tried: * modify the Katello in a way requiring the task does not cause duplicity * clearing the task after it's loaded - this helps but may have other consequences and does not solve the issue for other plugins

Not sure why PR testing didn’t catch it earlier

system · December 9, 2020, 12:00pm

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.