foreman-nightly-rpm-pipeline 54 failed


#1

Foreman RPM nightly pipeline failed:

https://ci.theforeman.org/job/foreman-nightly-rpm-pipeline/54/


#2

It’s failing to apply the NTP class, which is weird and unexpected. This test hasn’t failed in a long time so I’d be interested to know where the regression comes from. The same failure also shows up on Debian 9 and Ubuntu 18.04 so it’s unlikely to be packaging related.


#3

This appears to be a Hammer regression:

# hammer host update --puppet-class-ids 2 --name pipeline-foreman-1-22-centos7.wisse.example.com
Host updated.

Yet after that the Puppet class is not assigned. The debug output suggests it’s not parsing the parameter:

[ INFO 2019-04-26T15:16:49 API] PUT /api/hosts/1
[DEBUG 2019-04-26T15:16:49 API] Params: {
    "host" => {
                      "name" => "pipeline-foreman-1-22-centos7.wisse.example.com",
           "puppetclass_ids" => 2,
        "compute_attributes" => {}
    }
}

@cli could you have a look?


#4

Looks like the puppetclass_ids param should be an array but instead sends an integer, which is then dropped by strong params because it doesn’t match the expected type. Not sure why it started sending it that way.


#5

I can confirm it is regression in Hammer. It is tracked in Bug #26703: Hammer does not convert single value into an array for a list type option - Hammer CLI - Foreman and the PR is on its way.


closed #6

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.