Well, yes and no.
What you currently have is roughly an equvivalent of setting EXECUTORS_COUNT=4 in the pre-sidekiq dynflow. You have 4 independent executors. If you let them use the same redis instance, you would get a single executor with many workers. Both ways should work, but it is hard to say which one would perform better since we haven’t really compared the two approaches and we don’t know your workload.
In general, having a single executor with many workers should be a better choice up to the point where the dynflow-sidekiq@orchestrator stops being able to handle to load. When you reach this point, switching to multiple executors should help with handling the load.
And of course if connectivity between workers and the shared redis instance is limited/flaky then having local redis per executor would be better.
We will be grateful for any observations you’ll make