Formally requesting Foreman core commit access

Development
1

Ohai,

I do have commit rights to core due to the membership in @theforeman/packaging, but it always feels weird to actually approve/merge things based on that (especially as approval of PRs outside the packaging code ownership still gives a green checkmark and marks the PR as approved).

Thus, I’d like to ask y’all to formally give me “proper” commit rights to core :wink:

I did things: https://github.com/theforeman/foreman/commits?author=evgeni
I reviewed things: https://github.com/theforeman/foreman/pulls?q=is%3Apr+commenter%3Aevgeni (or maybe more precisely https://github.com/theforeman/foreman/pulls?q=is%3Apr+reviewed-by%3Aevgeni, not sure)

10 Likes
2

+1 * 1k^1k :slight_smile:

3

Definitelly +1, I’ve always considered that done deal and I believe others too and that’s the only reason you don’t have the rights yet :slight_smile:

4

I’ve added you to the core team on GH, please keep up the good work :slight_smile:

5

Damn, eh, I mean, thanks!