Later this month, we'll have interns and a potential new hire starting on Katello so I figure it's worth talking about how we handle Github permissions. For those not familiar, this is a topic we've talked about quite a bit as we've run into some problems over the past year. I've start an etherpad with a bunch of different ideas I've heard over time.
http://pad.engineering.redhat.com/katello-github-access-proposal
Feel free to add any ideas you have. Or indicate which ideas you like/hate with a +/- 1.
David
Sorry, I emailed the wrong list. Anyway, I'll just use this public etherpad now.
http://pad-katello.rhcloud.com/p/katello-github-access-proposal
David
···
----- Original Message -----
> From: "David Davis"
> To: "foreman-dev"
> Sent: Saturday, May 3, 2014 4:05:16 PM
> Subject: [foreman-dev] Github access for Katello repos
>
> Later this month, we'll have interns and a potential new hire starting on
> Katello so I figure it's worth talking about how we handle Github
> permissions. For those not familiar, this is a topic we've talked about
> quite a bit as we've run into some problems over the past year. I've start
> an etherpad with a bunch of different ideas I've heard over time.
>
> http://pad.engineering.redhat.com/katello-github-access-proposal
>
> Feel free to add any ideas you have. Or indicate which ideas you like/hate
> with a +/- 1.
>
> David
>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
Hi,
I wanted to make a small comment about:
> No one merges their own PR+1
- A PR would be merged by the person ACKing it? +1, reviewers can ask
for a 2nd ack if not 100% sure
Merging code isn't only about pressing "Merge" in GitHub. Even if the Pull
Request doesn't have other dependencies
(extra steps to follow - which should be described in the issue
description), one has to ensure the changes don't break the
production. If there is a problem one is responsible to fix it, or to ask
for help.
I don't think in code ownership, the code belongs to all contributors. Each
issue has to have an assignee which
knows the big picture, and is responsible for it end to end. Being
responsible doesn't mean one has to write code,
and do everything. He/she has to:
- describe the issue as best as possible, if someone reads the issue
then he/she can become an assignee and deliver it.
- manages resources so that the issue is delivered on time (it should
have an ETA)
- ensures the deliverables are met when the changes are in production
- fixes or redirects any problems which appear related with it after it
was merged for a week (or so).
That's it 
Maria
···
On 3 May 2014 23:37, David Davis wrote:
Sorry, I emailed the wrong list. Anyway, I’ll just use this public
etherpad now.
http://pad-katello.rhcloud.com/p/katello-github-access-proposal
David
----- Original Message -----
From: “David Davis” daviddavis@redhat.com
To: “foreman-dev” foreman-dev@googlegroups.com
Sent: Saturday, May 3, 2014 4:05:16 PM
Subject: [foreman-dev] Github access for Katello repos
Later this month, we’ll have interns and a potential new hire starting on
Katello so I figure it’s worth talking about how we handle Github
permissions. For those not familiar, this is a topic we’ve talked about
quite a bit as we’ve run into some problems over the past year. I’ve
start
an etherpad with a bunch of different ideas I’ve heard over time.
http://pad.engineering.redhat.com/katello-github-access-proposal
Feel free to add any ideas you have. Or indicate which ideas you
like/hate
with a +/- 1.
David
–
You received this message because you are subscribed to the Google Groups
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
–
You received this message because you are subscribed to the Google Groups
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Thanks everyone for the feedback on the etherpad and via email. Got some good responses!
Mike and I went through the etherpad and tried to sum up all the feedback and proposals. I'll try to create a developer document as well to outline our proposal.
It looks like there was overwhelming support for not giving contributors write access right away but rather waiting a period of time so they can work with a team member in learning our process. I think this is a good idea and will mitigate our problem. There was some debate about how to do this but we think the checklist idea makes sense. I think the checklist though should give all contributors a fair way to get write access.
We'd like to propose that a contributor would have to meet all three criteria.
- One month since first pull request
- Must have 3 merged pull requests
- Must have reviewed 3 pull requests
We can tweak this over time but I think it's a good starting point. It would be nice to require at least one non-trivial PR or feature PR but it's not easy determining how to distinguish that.
Secondly, we think that having certain people manage Github permissions make sense. First order of business would be to also clean up the teams and permissions that are currently in Github and then keep it clean over time. Any volunteers for this?
There was some small support or mixed support for other ideas like teams with write access to certain repos and having ACKers merge PRs. I think we'll table these ideas for now, think them over, and maybe readdress them later.
Thanks.
David
···
----- Original Message -----
> From: "David Davis"
> To: foreman-dev@googlegroups.com
> Sent: Saturday, May 3, 2014 4:37:20 PM
> Subject: Re: [foreman-dev] Github access for Katello repos
>
> Sorry, I emailed the wrong list. Anyway, I'll just use this public etherpad
> now.
>
> http://pad-katello.rhcloud.com/p/katello-github-access-proposal
>
> David
>
> ----- Original Message -----
> > From: "David Davis"
> > To: "foreman-dev"
> > Sent: Saturday, May 3, 2014 4:05:16 PM
> > Subject: [foreman-dev] Github access for Katello repos
> >
> > Later this month, we'll have interns and a potential new hire starting on
> > Katello so I figure it's worth talking about how we handle Github
> > permissions. For those not familiar, this is a topic we've talked about
> > quite a bit as we've run into some problems over the past year. I've start
> > an etherpad with a bunch of different ideas I've heard over time.
> >
> > http://pad.engineering.redhat.com/katello-github-access-proposal
> >
> > Feel free to add any ideas you have. Or indicate which ideas you like/hate
> > with a +/- 1.
> >
> > David
> >
> > --
> > You received this message because you are subscribed to the Google Groups
> > "foreman-dev" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> > email to foreman-dev+unsubscribe@googlegroups.com.
> > For more options, visit https://groups.google.com/d/optout.
> >
>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
> Thanks everyone for the feedback on the etherpad and via email. Got some
> good responses!
>
> Mike and I went through the etherpad and tried to sum up all the feedback
> and proposals. I'll try to create a developer document as well to outline
> our proposal.
>
> It looks like there was overwhelming support for not giving contributors
> write access right away but rather waiting a period of time so they can
> work with a team member in learning our process. I think this is a good
> idea and will mitigate our problem. There was some debate about how to do
> this but we think the checklist idea makes sense. I think the checklist
> though should give all contributors a fair way to get write access.
>
> We'd like to propose that a contributor would have to meet all three
> criteria.
>
> 1. One month since first pull request
> 2. Must have 3 merged pull requests
> 3. Must have reviewed 3 pull requests
>
> We can tweak this over time but I think it's a good starting point. It
> would be nice to require at least one non-trivial PR or feature PR but it's
> not easy determining how to distinguish that.
>
> Secondly, we think that having certain people manage Github permissions
> make sense. First order of business would be to also clean up the teams and
> permissions that are currently in Github and then keep it clean over time.
> Any volunteers for this?
>
I can tackle this for us. Spring cleaning!
Eric
···
On Mon, May 5, 2014 at 11:45 AM, David Davis wrote:
There was some small support or mixed support for other ideas like teams
with write access to certain repos and having ACKers merge PRs. I think
we’ll table these ideas for now, think them over, and maybe readdress them
later.
Thanks.
David
----- Original Message -----
From: “David Davis” daviddavis@redhat.com
To: foreman-dev@googlegroups.com
Sent: Saturday, May 3, 2014 4:37:20 PM
Subject: Re: [foreman-dev] Github access for Katello repos
Sorry, I emailed the wrong list. Anyway, I’ll just use this public
etherpad
now.
http://pad-katello.rhcloud.com/p/katello-github-access-proposal
David
----- Original Message -----
From: “David Davis” daviddavis@redhat.com
To: “foreman-dev” foreman-dev@googlegroups.com
Sent: Saturday, May 3, 2014 4:05:16 PM
Subject: [foreman-dev] Github access for Katello repos
Later this month, we’ll have interns and a potential new hire starting
on
Katello so I figure it’s worth talking about how we handle Github
permissions. For those not familiar, this is a topic we’ve talked about
quite a bit as we’ve run into some problems over the past year. I’ve
start
an etherpad with a bunch of different ideas I’ve heard over time.
http://pad.engineering.redhat.com/katello-github-access-proposal
Feel free to add any ideas you have. Or indicate which ideas you
like/hate
with a +/- 1.
David
–
You received this message because you are subscribed to the Google
Groups
“foreman-dev” group.
To unsubscribe from this group and stop receiving emails from it, send
an
email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
–
You received this message because you are subscribed to the Google Groups
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
–
You received this message because you are subscribed to the Google Groups
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
