Github Review Culture, update #1

Hi all,

So some while ago we had a long discussion about code reviews on
GitHub[1], which lead to an action plan[2]. Part of that action plan
was some form of dashboard where we could easily see the status of
code reviews across all repos, filtering out ones which were not
ready for review (such as having the waiting-on-contributor flag, or
similar)

I'm happy to present the first cut of that dashboard. Eric has been
graciously helping me out on the UI side, and together we've built

http://dashboard-ehelms.rhcloud.com/dashboard/reviews

Usage:

  • Load the page. Reviews from all repos are sorted by "review age"
    which is calculated from the time the PR was opened (if no comments)
    or from the last author comment if a review is in progress.
  • You can filter out repos using the filter dropdown at the top, if
    there are specific repos you dont wish to see right now
    • These filters will reset on page reload - this is intentional, as
      otherwise we do not make any progress on curing "repo blindness" where
      a particular repo is forgotten about for some time.
  • If a review has a reviewer assigned, you can see that in the right column.

Data is refreshed every 15mins - evetually we may be able to improve
this to be auto-updated when a PR is updated (thanks to GitHub hooks
and PR-Processor). In the meantime, 15mins is the best we can do with
API rate limiting.

Bonus - Personal review dashboard

If you go to the Login link (top right) and supply just your GitHub
ID, you'll be presented with a list of all your open PRs, and all your
active reviews (this only works if you set yourself as the Assignee on
the PR).

This is a first cut, so we're looking for feedback on whether it's
useful or not. Suggestions are welcome here or at the code repo [3],
as are bug reports and patches :slight_smile:

Next Steps

If you're finding this useful, please do start using the Assignee
field on reviews you're leading. I'll try to add some functionality to
PR-Processor for setting it automatically. Also, hopefully soon I can
add the "reviewer scoreboard" to this UI too, but it's not done yet.

Looking forward to your comments!
Greg

[1] https://groups.google.com/d/topic/foreman-dev/jiOx3_WeGmg/discussion
[2] Foreman :: Tackling review culture
[3] https://github.com/ehelms/prprocessor/tree/reviews

Great start. Some thoughts:

  • Add a page title
  • Add more links (owner, repo, author and reviewer can be linked to GH)
  • Sortable and searchable columns (datatables?)
··· On Mon, Dec 21, 2015 at 04:20:16PM +0000, Greg Sutcliffe wrote: > So some while ago we had a long discussion about code reviews on > GitHub[1], which lead to an action plan[2]. Part of that action plan > was some form of dashboard where we could easily see the status of > code reviews across *all* repos, filtering out ones which were not > ready for review (such as having the waiting-on-contributor flag, or > similar) > > I'm happy to present the first cut of that dashboard. Eric has been > graciously helping me out on the UI side, and together we've built > > http://dashboard-ehelms.rhcloud.com/dashboard/reviews

Thanks, that looks awesome. I've been checking it out for a few mins,
my initial feedback:

Pros -

  • It allows me to see at a first glance all my open PRs
  • It encourages me to set the 'assignee' field on PRs I review
  • It gives me better visibility of open PRs on projects I might not
    check out that often
  • Finally a shared place for reviews & bugzillas

To be improved -

  • Smart proxy missing from the filtering list? puppetdb-foreman is also
    missing.
  • The reviews filter list works in a strange way IMO, it removes the projects
    I select? I think it should work the opposite way, only show the
    projects I select.
  • 'features' should have a link to Redmine.
  • Show a spinner or something when waiting, I wrote my Github username
    and waited for at least 30s until anything showed up on the screen.
    I thought it was broken and reloaded the page a few times.
  • Under 'my PRs', I see PRs from repos unrelated to Foreman. Perhaps a
    global filter to show PRs/issues/reviews from certain repo or repo
    owners would work best.

Questions -

  • What is the criteria for the search filter 'show PRs that don't need
    review'? PRs that need rebasing? Waiting on contributor?

  • What exactly are features? Redmine trackers?

  • Is it open source/published anywhere?

  • It makes me wonder if we need a tool like this because our issues
    live on Redmine (or Bugzilla), and our reviews happen on Github. If
    we go to /issues or /pulls on Github, we get more or less the same
    functionality this dashboard provides (except the feature tracker).

    Out of the fields in Redmine, the only ones we 'need' are 'Release',
    'Status', 'Priority', and we can substitute that with Milestones
    and Labels. Does that sound sensible to anyone else or there are too
    many caveats?

I'll keep on using it for the whole day today, and will give more
feedback if I find any problems with it or I think I'd like something
else.

Thanks again!

··· On 12/21, Greg Sutcliffe wrote: > http://dashboard-ehelms.rhcloud.com/dashboard/reviews >


Daniel Lobato Garcia

@dLobatog
blog.daniellobato.me
daniellobato.me

GPG: http://keys.gnupg.net/pks/lookup?op=get&search=0x7A92D6DD38D6DE30
Keybase: https://keybase.io/elobato

> This is a first cut, so we're looking for feedback on whether it's
> useful or not. Suggestions are welcome here or at the code repo [3],
> as are bug reports and patches :slight_smile:

Great job.

It is worth mentioning that the BZ password is sent unencrypted and
stored in the session. Just as a warning.

I can't store my github username without providing BZ credentials.

But Reviews is far enough for me for starters.

··· -- Later, Lukas #lzap Zapletal

>
> Great start. Some thoughts:
>
> * Add a page title

I see you sent a PR :slight_smile:

> * Add more links (owner, repo, author and reviewer can be linked to GH)
> * Sortable and searchable columns (datatables?)

+1, feel free to add issues to the repo.

>
> Thanks, that looks awesome. I've been checking it out for a few mins,
> my initial feedback:
>
> Pros -
> - It allows me to see at a first glance all my open PRs
> - It encourages me to set the 'assignee' field on PRs I review
> - It gives me better visibility of open PRs on projects I might not
> check out that often
> - Finally a shared place for reviews & bugzillas

I'm particularly keen to see the Assignee field used as I will likely based
the Reviewer metrics on it :wink:

> To be improved -
> - Smart proxy missing from the filtering list? puppetdb-foreman is also
> missing.

Yeah there is something odd with how the Octokit client is retreiving
repos. I'm using

(client.repos('theforeman').map(&:full_name) +
client.repos('katello').map(&:full_name)).sort

But it doesn't seem to return all repos. I'll take a look at it today and
see what's up.

> - The reviews filter list works in a strange way IMO, it removes the
projects
> I select? I think it should work the opposite way, only show the
> projects I select.

The idea in my head is that we're trying to solve the issue of forgetting
about a particular repo (such as the smart-proxy repo which started all
this). I feel that if we allow you to filter to a single repo, we don't
solve that issue - you'll just look at repos you know about. It's fair to
say "I can't help with anything in that repo, hide it for now" but then
something might be at the top of the pile in a repo you'd forgotten.

I'm happy to be overruled by everyone on this, I'm just asking that we give
it a chance - it's not an arbitrary decision :slight_smile:

> - 'features' should have a link to Redmine.
> - Show a spinner or something when waiting, I wrote my Github username
> and waited for at least 30s until anything showed up on the screen.
> I thought it was broken and reloaded the page a few times.

+1 to these

> - Under 'my PRs', I see PRs from repos unrelated to Foreman. Perhaps a
> global filter to show PRs/issues/reviews from certain repo or repo
> owners would work best.

IIRC it's just using the public GitHub API to query your username. We can
filter it easy enough, I guess, but lets do it optionally & in-page, as I'm
already starting to use it to get an overview of my personal work :slight_smile:

> Questions -
> - What is the criteria for the search filter 'show PRs that don't need
> review'? PRs that need rebasing? Waiting on contributor?

This relates to the "flow chart" in my blog post, about deciding if a
review needs to be done or not. If the PR has no comments, or the last
comment is from the author, it's marked as :review=>true. If it's
WaitingOnContributor or the last comment is from someone else than the
author (excluding theforeman-bot) then the assumption is that we're waiting
on the author, :review => false. See the post for more details on my
thinking, and I'm sure that algorithm can be improved.

> - What exactly are features? Redmine trackers?

I don't actually know, that was something Eric added - can you elaborate
Eric?

> - Is it open source/published anywhere?

Yes, link is in the original post (see [3])

> - It makes me wonder if we need a tool like this because our issues
> live on Redmine (or Bugzilla), and our reviews happen on Github. If
> we go to /issues or /pulls on Github, we get more or less the same
> functionality this dashboard provides (except the feature tracker).
>
> Out of the fields in Redmine, the only ones we 'need' are 'Release',
> 'Status', 'Priority', and we can substitute that with Milestones
> and Labels. Does that sound sensible to anyone else or there are too
> many caveats?

Potentially. Downside is having all our stufff in a proprietary system
(plus the headache of migrating 12k bugs :P). I think we looked at it in
the past and decided not to, but that could be revisited.

> I'll keep on using it for the whole day today, and will give more
> feedback if I find any problems with it or I think I'd like something
> else.

Epic, thanks! I'm glad its useful already.

Greg

··· On 21 December 2015 at 17:14, Ewoud Kohl van Wijngaarden < ewoud@kohlvanwijngaarden.nl> wrote: On 22 December 2015 at 09:48, Daniel Lobato Garcia wrote:

> > http://dashboard-ehelms.rhcloud.com/dashboard/reviews
> >
>
> Thanks, that looks awesome. I've been checking it out for a few mins,
> my initial feedback:
>
> Pros -
> - It allows me to see at a first glance all my open PRs
> - It encourages me to set the 'assignee' field on PRs I review
> - It gives me better visibility of open PRs on projects I might not
> check out that often
> - Finally a shared place for reviews & bugzillas
>
> To be improved -
> - Smart proxy missing from the filtering list? puppetdb-foreman is also
> missing.
> - The reviews filter list works in a strange way IMO, it removes the
> projects
> I select? I think it should work the opposite way, only show the
> projects I select.
> - 'features' should have a link to Redmine.
>

What are you referring to here ?

> - Show a spinner or something when waiting, I wrote my Github username
> and waited for at least 30s until anything showed up on the screen.
> I thought it was broken and reloaded the page a few times.
> - Under 'my PRs', I see PRs from repos unrelated to Foreman. Perhaps a
> global filter to show PRs/issues/reviews from certain repo or repo
> owners would work best.
>
>
> Questions -
> - What is the criteria for the search filter 'show PRs that don't need
> review'? PRs that need rebasing? Waiting on contributor?
> - What exactly are features? Redmine trackers?
>

Correct - that page was something I built quite a few months back when I
wanted to try tracking a feature across multiple releases.

> - Is it open source/published anywhere?
> - It makes me wonder if we need a tool like this because our issues
> live on Redmine (or Bugzilla), and our reviews happen on Github. If
> we go to /issues or /pulls on Github, we get more or less the same
> functionality this dashboard provides (except the feature tracker).
>

I don't disagree; however, those have existed for years now and we seem to
still be having the conversation. I am of the opinion those things work
well for power users, but for the majority having a single place that
distills it all down is useful. The proof is in the pudding though and like
any tool our goal is to do a little, see if their is feedback and usage and
iterate on it. If it turns out this isn't useful we throw it away.

··· On Tue, Dec 22, 2015 at 4:48 AM, Daniel Lobato Garcia wrote: > On 12/21, Greg Sutcliffe wrote:
Out of the fields in Redmine, the only ones we 'need' are 'Release',
'Status', 'Priority', and we can substitute that with Milestones
and Labels. Does that sound sensible to anyone else or there are too
many caveats?

I’ll keep on using it for the whole day today, and will give more
feedback if I find any problems with it or I think I’d like something
else.

Thanks again!


Daniel Lobato Garcia

@dLobatog
blog.daniellobato.me
daniellobato.me

GPG: http://keys.gnupg.net/pks/lookup?op=get&search=0x7A92D6DD38D6DE30
Keybase: https://keybase.io/elobato


You received this message because you are subscribed to the Google Groups
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Eric D. Helms
Red Hat Engineering
Ph.D. Student - North Carolina State University

> > To be improved -
> > - Smart proxy missing from the filtering list? puppetdb-foreman is
also
> > missing.
>
> Yeah there is something odd with how the Octokit client is retreiving
repos. I'm using
>
> (client.repos('theforeman').map(&:full_name) +
client.repos('katello').map(&:full_name)).sort
>
> But it doesn't seem to return all repos. I'll take a look at it today and
see what's up.

Quick update, this was due to GitHub silently paginating it's API, both for
the repo list and the issue list. Both cases have been fixed, and the dash
has much more data now :stuck_out_tongue:

Greg

··· On 22 December 2015 at 10:13, Greg Sutcliffe wrote:

Following up on this thread - how are people finding the review board? Is
it useful?

Hopefully you've noticed that we added the ability to quickly filter out
repos you don't want to review by clicking on the repo name - this makes it
much faster to find reviews you can do.

I still need to implement the reviewer stats, but this will likely be after
the conferences now. Do continue to use the "assignee" field in the PR if
you're interested in this - I can cuess the reviewer with some heuristics
on the comments, but it's more accurate if I just take the value of that
field.

Thanks
Greg

>
>
>
>> > http://dashboard-ehelms.rhcloud.com/dashboard/reviews
>> >
>>
>> Thanks, that looks awesome. I've been checking it out for a few mins,
>> my initial feedback:
>>
>> Pros -
>> - It allows me to see at a first glance all my open PRs
>> - It encourages me to set the 'assignee' field on PRs I review
>> - It gives me better visibility of open PRs on projects I might not
>> check out that often
>> - Finally a shared place for reviews & bugzillas
>>
>> To be improved -
>> - Smart proxy missing from the filtering list? puppetdb-foreman is also
>> missing.
>> - The reviews filter list works in a strange way IMO, it removes the
>> projects
>> I select? I think it should work the opposite way, only show the
>> projects I select.
>> - 'features' should have a link to Redmine.
>>
>
> What are you referring to here ?
>
>
>> - Show a spinner or something when waiting, I wrote my Github username
>> and waited for at least 30s until anything showed up on the screen.
>> I thought it was broken and reloaded the page a few times.
>> - Under 'my PRs', I see PRs from repos unrelated to Foreman. Perhaps a
>> global filter to show PRs/issues/reviews from certain repo or repo
>> owners would work best.
>>
>>
>> Questions -
>> - What is the criteria for the search filter 'show PRs that don't need
>> review'? PRs that need rebasing? Waiting on contributor?
>> - What exactly are features? Redmine trackers?
>>
>
> Correct - that page was something I built quite a few months back when I
> wanted to try tracking a feature across multiple releases.
>
>
>> - Is it open source/published anywhere?
>> - It makes me wonder if we need a tool like this because our issues
>> live on Redmine (or Bugzilla), and our reviews happen on Github. If
>> we go to /issues or /pulls on Github, we get more or less the same
>> functionality this dashboard provides (except the feature tracker).
>>
>
> I don't disagree; however, those have existed for years now and we seem to
> still be having the conversation. I am of the opinion those things work
> well for power users, but for the majority having a single place that
> distills it all down is useful. The proof is in the pudding though and like
> any tool our goal is to do a little, see if their is feedback and usage and
> iterate on it. If it turns out this isn't useful we throw it away.
>
>
>>
>> Out of the fields in Redmine, the only ones we 'need' are 'Release',
>> 'Status', 'Priority', and we can substitute that with Milestones
>> and Labels. Does that sound sensible to anyone else or there are too
>> many caveats?
>>
>> I'll keep on using it for the whole day today, and will give more
>> feedback if I find any problems with it or I think I'd like something
>> else.
>>
>> Thanks again!
>>
>
can you filter/highlight based on jenkins test status and if the PR needs
merge?

thanks,
Ohad

··· On Tue, Dec 22, 2015 at 9:49 PM, Eric D Helms wrote: > On Tue, Dec 22, 2015 at 4:48 AM, Daniel Lobato Garcia > wrote: >> On 12/21, Greg Sutcliffe wrote:


Daniel Lobato Garcia

@dLobatog
blog.daniellobato.me
daniellobato.me

GPG: http://keys.gnupg.net/pks/lookup?op=get&search=0x7A92D6DD38D6DE30
Keybase: https://keybase.io/elobato


You received this message because you are subscribed to the Google Groups
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Eric D. Helms
Red Hat Engineering
Ph.D. Student - North Carolina State University


You received this message because you are subscribed to the Google Groups
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

My biggest problem is that I forget it exists and then have to remember
where it was again. The latter can be solved with an easier URL / links
on the website, not sure how to solve the former.

··· On Fri, Jan 22, 2016 at 10:07:15AM +0000, Greg Sutcliffe wrote: > Following up on this thread - how are people finding the review board? Is > it useful?

I find it useful, but I often forget to click on the assignee field.
It's more administrative work and it doesn't work when more than 1
person reviews a PR, so I'd prefer to rely on automatic detection.

··· On 01/22, Greg Sutcliffe wrote: > Following up on this thread - how are people finding the review board? Is > it useful?


Daniel Lobato Garcia

@dLobatog
blog.daniellobato.me
daniellobato.me

GPG: http://keys.gnupg.net/pks/lookup?op=get&search=0x7A92D6DD38D6DE30
Keybase: https://keybase.io/elobato

>
>
>
>>
>>
>>
>>>
>>> > http://dashboard-ehelms.rhcloud.com/dashboard/reviews
>>> >
>>>
>>> Thanks, that looks awesome. I've been checking it out for a few mins,
>>> my initial feedback:
>>>
>>> Pros -
>>> - It allows me to see at a first glance all my open PRs
>>> - It encourages me to set the 'assignee' field on PRs I review
>>> - It gives me better visibility of open PRs on projects I might not
>>> check out that often
>>> - Finally a shared place for reviews & bugzillas
>>>
>>> To be improved -
>>> - Smart proxy missing from the filtering list? puppetdb-foreman is
also
>>> missing.
>>> - The reviews filter list works in a strange way IMO, it removes the
projects
>>> I select? I think it should work the opposite way, only show the
>>> projects I select.
>>> - 'features' should have a link to Redmine.
>>
>>
>> What are you referring to here ?
>>
>>>
>>> - Show a spinner or something when waiting, I wrote my Github username
>>> and waited for at least 30s until anything showed up on the screen.
>>> I thought it was broken and reloaded the page a few times.
>>> - Under 'my PRs', I see PRs from repos unrelated to Foreman. Perhaps a
>>> global filter to show PRs/issues/reviews from certain repo or repo
>>> owners would work best.
>>>
>>>
>>> Questions -
>>> - What is the criteria for the search filter 'show PRs that don't need
>>> review'? PRs that need rebasing? Waiting on contributor?
>>> - What exactly are features? Redmine trackers?
>>
>>
>> Correct - that page was something I built quite a few months back when I
wanted to try tracking a feature across multiple releases.
>>
>>>
>>> - Is it open source/published anywhere?
>>> - It makes me wonder if we need a tool like this because our issues
>>> live on Redmine (or Bugzilla), and our reviews happen on Github. If
>>> we go to /issues or /pulls on Github, we get more or less the same
>>> functionality this dashboard provides (except the feature tracker).
>>
>>
>> I don't disagree; however, those have existed for years now and we seem
to still be having the conversation. I am of the opinion those things work
well for power users, but for the majority having a single place that
distills it all down is useful. The proof is in the pudding though and like
any tool our goal is to do a little, see if their is feedback and usage and
iterate on it. If it turns out this isn't useful we throw it away.
>>
>>>
>>>
>>> Out of the fields in Redmine, the only ones we 'need' are 'Release',
>>> 'Status', 'Priority', and we can substitute that with Milestones
>>> and Labels. Does that sound sensible to anyone else or there are too
>>> many caveats?
>>>
>>> I'll keep on using it for the whole day today, and will give more
>>> feedback if I find any problems with it or I think I'd like something
>>> else.
>>>
>>> Thanks again!
>
>
> can you filter/highlight based on jenkins test status and if the PR needs
merge?

We could retrieve the status as part of our data caching and present it in
the table.

Can you clarify what you mean by if PR needs merge? What "state" represents
that ?

Eric

>
> thanks,
> Ohad
>>>
>>>
>>> –
>>> Daniel Lobato Garcia
>>>
>>> @dLobatog
>>> blog.daniellobato.me
>>> daniellobato.me
>>>
>>> GPG: http://keys.gnupg.net/pks/lookup?op=get&search=0x7A92D6DD38D6DE30
>>> Keybase: https://keybase.io/elobato
>>>
>>> –
>>> You received this message because you are subscribed to the Google
Groups "foreman-dev" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
an email to foreman-dev+unsubscribe@googlegroups.com.
>>> For more options, visit https://groups.google.com/d/optout.
>>
>>
>>
>>
>> –
>> Eric D. Helms
>> Red Hat Engineering
>> Ph.D. Student - North Carolina State University
>>
>> –
>> You received this message because you are subscribed to the Google
Groups "foreman-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send
an email to foreman-dev+unsubscribe@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>
>
> –
> You received this message because you are subscribed to the Google Groups
"foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscribe@googlegroups.com.

··· On Dec 24, 2015 10:28 AM, "Ohad Levy" wrote: > On Tue, Dec 22, 2015 at 9:49 PM, Eric D Helms wrote: >> On Tue, Dec 22, 2015 at 4:48 AM, Daniel Lobato Garcia < elobatocs@gmail.com> wrote: >>> On 12/21, Greg Sutcliffe wrote: > For more options, visit https://groups.google.com/d/optout.

>
>
> >
> >
> >
> >>
> >>
> >>
> >>>
> >>> > http://dashboard-ehelms.rhcloud.com/dashboard/reviews
> >>> >
> >>>
> >>> Thanks, that looks awesome. I've been checking it out for a few mins,
> >>> my initial feedback:
> >>>
> >>> Pros -
> >>> - It allows me to see at a first glance all my open PRs
> >>> - It encourages me to set the 'assignee' field on PRs I review
> >>> - It gives me better visibility of open PRs on projects I might not
> >>> check out that often
> >>> - Finally a shared place for reviews & bugzillas
> >>>
> >>> To be improved -
> >>> - Smart proxy missing from the filtering list? puppetdb-foreman is
also
> >>> missing.
> >>> - The reviews filter list works in a strange way IMO, it removes
the projects
> >>> I select? I think it should work the opposite way, only show the
> >>> projects I select.
> >>> - 'features' should have a link to Redmine.
> >>
> >>
> >> What are you referring to here ?
> >>
> >>>
> >>> - Show a spinner or something when waiting, I wrote my Github
username
> >>> and waited for at least 30s until anything showed up on the
screen.
> >>> I thought it was broken and reloaded the page a few times.
> >>> - Under 'my PRs', I see PRs from repos unrelated to Foreman.
Perhaps a
> >>> global filter to show PRs/issues/reviews from certain repo or repo
> >>> owners would work best.
> >>>
> >>>
> >>> Questions -
> >>> - What is the criteria for the search filter 'show PRs that don't
need
> >>> review'? PRs that need rebasing? Waiting on contributor?
> >>> - What exactly are features? Redmine trackers?
> >>
> >>
> >> Correct - that page was something I built quite a few months back when
I wanted to try tracking a feature across multiple releases.
> >>
> >>>
> >>> - Is it open source/published anywhere?
> >>> - It makes me wonder if we need a tool like this because our issues
> >>> live on Redmine (or Bugzilla), and our reviews happen on Github.
If
> >>> we go to /issues or /pulls on Github, we get more or less the same
> >>> functionality this dashboard provides (except the feature
tracker).
> >>
> >>
> >> I don't disagree; however, those have existed for years now and we
seem to still be having the conversation. I am of the opinion those things
work well for power users, but for the majority having a single place that
distills it all down is useful. The proof is in the pudding though and like
any tool our goal is to do a little, see if their is feedback and usage and
iterate on it. If it turns out this isn't useful we throw it away.
> >>
> >>>
> >>>
> >>> Out of the fields in Redmine, the only ones we 'need' are
'Release',
> >>> 'Status', 'Priority', and we can substitute that with Milestones
> >>> and Labels. Does that sound sensible to anyone else or there are
too
> >>> many caveats?
> >>>
> >>> I'll keep on using it for the whole day today, and will give more
> >>> feedback if I find any problems with it or I think I'd like something
> >>> else.
> >>>
> >>> Thanks again!
> >
> >
> > can you filter/highlight based on jenkins test status and if the PR
needs merge?
>
> We could retrieve the status as part of our data caching and present it
in the table.
>
> Can you clarify what you mean by if PR needs merge? What "state"
represents that ?

Sorry, I meant rebase.

Ohad
>
> Eric
>
> >
> > thanks,
> > Ohad
> >>>
> >>>
> >>> –
> >>> Daniel Lobato Garcia
> >>>
> >>> @dLobatog
> >>> blog.daniellobato.me
> >>> daniellobato.me
> >>>
> >>> GPG: http://keys.gnupg.net/pks/lookup?op=get&search=0x7A92D6DD38D6DE30
> >>> Keybase: https://keybase.io/elobato
> >>>
> >>> –
> >>> You received this message because you are subscribed to the Google
Groups "foreman-dev" group.
> >>> To unsubscribe from this group and stop receiving emails from it,
send an email to foreman-dev+unsubscribe@googlegroups.com.
> >>> For more options, visit https://groups.google.com/d/optout.
> >>
> >>
> >>
> >>
> >> –
> >> Eric D. Helms
> >> Red Hat Engineering
> >> Ph.D. Student - North Carolina State University
> >>
> >> –
> >> You received this message because you are subscribed to the Google
Groups "foreman-dev" group.
> >> To unsubscribe from this group and stop receiving emails from it, send
an email to foreman-dev+unsubscribe@googlegroups.com.
> >> For more options, visit https://groups.google.com/d/optout.
> >
> >
> > –
> > You received this message because you are subscribed to the Google
Groups "foreman-dev" group.
> > To unsubscribe from this group and stop receiving emails from it, send
an email to foreman-dev+unsubscribe@googlegroups.com.
> > For more options, visit https://groups.google.com/d/optout.
>
> –
> You received this message because you are subscribed to the Google Groups
"foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscribe@googlegroups.com.

··· On Dec 24, 2015 18:06, "Eric D Helms" wrote: > On Dec 24, 2015 10:28 AM, "Ohad Levy" wrote: > > On Tue, Dec 22, 2015 at 9:49 PM, Eric D Helms wrote: > >> On Tue, Dec 22, 2015 at 4:48 AM, Daniel Lobato Garcia < elobatocs@gmail.com> wrote: > >>> On 12/21, Greg Sutcliffe wrote: > For more options, visit https://groups.google.com/d/optout.

Interesting to hear, thanks. I'l see if I can patch pr-processor to set
that field automatically to the first commenter.

··· On 26 January 2016 at 09:45, Daniel Lobato Garcia wrote:

On 01/22, Greg Sutcliffe wrote:

Following up on this thread - how are people finding the review board? Is
it useful?

I find it useful, but I often forget to click on the assignee field.
It’s more administrative work and it doesn’t work when more than 1
person reviews a PR, so I’d prefer to rely on automatic detection.