Hi all,
So some while ago we had a long discussion about code reviews on
GitHub[1], which lead to an action plan[2]. Part of that action plan
was some form of dashboard where we could easily see the status of
code reviews across all repos, filtering out ones which were not
ready for review (such as having the waiting-on-contributor flag, or
similar)
I'm happy to present the first cut of that dashboard. Eric has been
graciously helping me out on the UI side, and together we've built
http://dashboard-ehelms.rhcloud.com/dashboard/reviews
Usage:
- Load the page. Reviews from all repos are sorted by "review age"
which is calculated from the time the PR was opened (if no comments)
or from the last author comment if a review is in progress. - You can filter out repos using the filter dropdown at the top, if
there are specific repos you dont wish to see right now- These filters will reset on page reload - this is intentional, as
otherwise we do not make any progress on curing "repo blindness" where
a particular repo is forgotten about for some time.
- These filters will reset on page reload - this is intentional, as
- If a review has a reviewer assigned, you can see that in the right column.
Data is refreshed every 15mins - evetually we may be able to improve
this to be auto-updated when a PR is updated (thanks to GitHub hooks
and PR-Processor). In the meantime, 15mins is the best we can do with
API rate limiting.
Bonus - Personal review dashboard
If you go to the Login link (top right) and supply just your GitHub
ID, you'll be presented with a list of all your open PRs, and all your
active reviews (this only works if you set yourself as the Assignee on
the PR).
This is a first cut, so we're looking for feedback on whether it's
useful or not. Suggestions are welcome here or at the code repo [3],
as are bug reports and patches
Next Steps
If you're finding this useful, please do start using the Assignee
field on reviews you're leading. I'll try to add some functionality to
PR-Processor for setting it automatically. Also, hopefully soon I can
add the "reviewer scoreboard" to this UI too, but it's not done yet.
Looking forward to your comments!
Greg
[1] https://groups.google.com/d/topic/foreman-dev/jiOx3_WeGmg/discussion
[2] Foreman :: Tackling review culture
[3] https://github.com/ehelms/prprocessor/tree/reviews