Hi,
Hound have updated their version of rubocop to 0.51 which includes some
rule name changes. I have opened a PR [1] to foreman-core to upgrade to the
latest version and updated the todo file.
All plugins using rubocop should make sure their .rubocop.yaml is
compatible with the new version.
Hound ignores the rubocop version specified in the gemfile, which means
that it will start barking on every PR in repos that use it if the settings
are incompatible, and once the PR is merged into foreman core, those
plugins depending on core and running rubocop on jenkins will start failing.
The changes to rubocop's rule names can be foun in their changelog [2], or
by manually running rubocop version 0.51 with your current configuration
and looking out for errors. In case the errors are in the
.rubocop_todo.yaml file, it can be automatically regenerated by running
rubucop --auto-gen-config (but keep in mind this will disable any
currently failing cops).
[1] https://github.com/theforeman/foreman/pull/4949
[2] https://github.com/bbatsov/rubocop/blob/master/CHANGELOG.md
···
--
Have a nice day,
Tomer Brisker
Red Hat Engineering
I created an issue in Katello [1] to track the changes there. We may assign
someone [who isn't there] during today's triage.
[1] Bug #21468: Upgrade rubocop to 0.51 - Katello - Foreman
···
On Wed, Oct 25, 2017 at 7:32 AM, Tomer Brisker wrote:
Hi,
Hound have updated their version of rubocop to 0.51 which includes some
rule name changes. I have opened a PR [1] to foreman-core to upgrade to the
latest version and updated the todo file.
All plugins using rubocop should make sure their .rubocop.yaml is
compatible with the new version.
Hound ignores the rubocop version specified in the gemfile, which means
that it will start barking on every PR in repos that use it if the settings
are incompatible, and once the PR is merged into foreman core, those
plugins depending on core and running rubocop on jenkins will start failing.
The changes to rubocop’s rule names can be foun in their changelog [2],
or by manually running rubocop version 0.51 with your current configuration
and looking out for errors. In case the errors are in the
.rubocop_todo.yaml file, it can be automatically regenerated by running
rubucop --auto-gen-config (but keep in mind this will disable any
currently failing cops).
[1] https://github.com/theforeman/foreman/pull/4949
[2] https://github.com/bbatsov/rubocop/blob/master/CHANGELOG.md
–
Have a nice day,
Tomer Brisker
Red Hat Engineering
–
You received this message because you are subscribed to the Google Groups
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
–
Andrew Kofink
akofink@redhat.com
IRC: akofink
Software Engineer
Red Hat Satellite
This was fixed on katello by https://github.com/Katello/katello/pull/7036
If you have an open PR on katello, you may want to re-kick off Jenkins
-John
John Mitsch
Red Hat Engineering
(860)-967-7285
irc: jomitsch
···
On Wed, Oct 25, 2017 at 1:18 PM, Andrew Kofink wrote:
I created an issue in Katello [1] to track the changes there. We may
assign someone [who isn’t there] during today’s triage.
[1] Bug #21468: Upgrade rubocop to 0.51 - Katello - Foreman
On Wed, Oct 25, 2017 at 7:32 AM, Tomer Brisker tbrisker@redhat.com > wrote:
Hi,
Hound have updated their version of rubocop to 0.51 which includes some
rule name changes. I have opened a PR [1] to foreman-core to upgrade to the
latest version and updated the todo file.
All plugins using rubocop should make sure their .rubocop.yaml is
compatible with the new version.
Hound ignores the rubocop version specified in the gemfile, which means
that it will start barking on every PR in repos that use it if the settings
are incompatible, and once the PR is merged into foreman core, those
plugins depending on core and running rubocop on jenkins will start failing.
The changes to rubocop’s rule names can be foun in their changelog [2],
or by manually running rubocop version 0.51 with your current configuration
and looking out for errors. In case the errors are in the
.rubocop_todo.yaml file, it can be automatically regenerated by running
rubucop --auto-gen-config (but keep in mind this will disable any
currently failing cops).
[1] https://github.com/theforeman/foreman/pull/4949
[2] https://github.com/bbatsov/rubocop/blob/master/CHANGELOG.md
–
Have a nice day,
Tomer Brisker
Red Hat Engineering
–
You received this message because you are subscribed to the Google Groups
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
–
Andrew Kofink
akofink@redhat.com
IRC: akofink
Software Engineer
Red Hat Satellite
–
You received this message because you are subscribed to the Google Groups
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
