just a heads up - I have recently found that Foreman Proxy (HEAD) does
not work with the latest and greatest Sinatra 1.4.2 release. It ignores
Accept: JSON and only does return HTML which breaks Foreman of course.
The fix is pending, just to prevent you from W-T-H-I-G-O-H-?
TL;DR Don't want problems? Do not run bundle update sinatra…
···
***
Moving on. I did found out that rake test does not work when using
rbenv, because of broken library require statement in rubyipmi. Fix is
also pending:
I guess the workaround would be to ignore or turn off IPMI tests.
You also hit an issue with OpenStruct for settings, did you solve that?
My concern was that the fix might have fixed it too well, so that
method_missing was correctly called on Settings and then the spec_helper
wouldn't be able to force certain settings "on" for the purposes of the
unit tests.
It should be possible to copy the settings.yml.example to settings.yml
and it just work. I think it only does by accident at the moment, as
the method_missing in Settings doesn't get run. Maybe there are
different implementations of OpenStruct or something?
···
On 02/04/13 09:28, Lukas Zapletal wrote:
> Guys,
>
> just a heads up - I have recently found that Foreman Proxy (HEAD) does
> not work with the latest and greatest Sinatra 1.4.2 release. It ignores
> Accept: JSON and only does return HTML which breaks Foreman of course.
>
> The fix is pending, just to prevent you from W-T-H-I-G-O-H-? ;-)
This OpenStruct issue was due to misconfiguration. I had to delete my
gem environment twice for some reason, something was still there (maybe
an environment variable) and I was using bad version of something.
It works now smooth.
···
On Tue, Apr 02, 2013 at 09:44:31AM +0100, Dominic Cleal wrote:
> On 02/04/13 09:28, Lukas Zapletal wrote:
> > Guys,
> >
> > just a heads up - I have recently found that Foreman Proxy (HEAD) does
> > not work with the latest and greatest Sinatra 1.4.2 release. It ignores
> > Accept: JSON and only does return HTML which breaks Foreman of course.
> >
> > The fix is pending, just to prevent you from W-T-H-I-G-O-H-? ;-)
>
> You also hit an issue with OpenStruct for settings, did you solve that?
>
> My concern was that the fix might have fixed it too well, so that
> method_missing was correctly called on Settings and then the spec_helper
> wouldn't be able to force certain settings "on" for the purposes of the
> unit tests.
>
> It should be possible to copy the settings.yml.example to settings.yml
> and it just work. I think it only does by accident at the moment, as
> the method_missing in Settings doesn't get run. Maybe there are
> different implementations of OpenStruct or something?
just a heads up - I have recently found that Foreman Proxy (HEAD) does
not work with the latest and greatest Sinatra 1.4.2 release. It ignores
Accept: JSON and only does return HTML which breaks Foreman of course.
> > just a heads up - I have recently found that Foreman Proxy (HEAD) does
> > not work with the latest and greatest Sinatra 1.4.2 release. It ignores
> > Accept: JSON and only does return HTML which breaks Foreman of course.
>
> I'm running 1.4.2 with no apparent issues…
I can confirm the same behavior now on Fedora 18 and RHEL 6 (both with
Ruby 1.9.3 with rbenv - clean setup).
Can somebody help me reproducing it and confirm that my
patch does solve the issue?
We had a user (Karim) confirm the issue on 1.4.2 the other day, but he
downgraded to avoid it (successfully) rather than applying the patch.
···
On 05/04/13 14:16, Lukas Zapletal wrote:
>>> just a heads up - I have recently found that Foreman Proxy (HEAD) does
>>> not work with the latest and greatest Sinatra 1.4.2 release. It ignores
>>> Accept: JSON and only does return HTML which breaks Foreman of course.
>>
>> I'm running 1.4.2 with no apparent issues....
>
> I can confirm the same behavior now on Fedora 18 and RHEL 6 (both with
> Ruby 1.9.3 with rbenv - clean setup).
>
> Can somebody help me reproducing it and confirm that my
> patch does solve the issue?
