https://github.com/Katello/katello/pull/3865

Mike, Eric, Dom, Ohad… you guys wanna jump in here? I can see Eric's
point about not swtiching roots, and I can see Dom's about being
consistent across plugins. I really not have have a horse in the race
other than correct strings :slight_smile:

https://github.com/Katello/katello/pull/3865

– bk

I wouldn't mind Foreman's extraction task being changed to work from the
Foreman checkout direction if it's possible, seems a better idea.

My only hunch is that it's this way because our first plugins would run
tests this way (using Foreman checked out inside the plugin) so it may
have been built on top of this assumption.

The model attribute extraction (#3023) was a good deal harder I think
because it was running in a combined Foreman + plugin context, so it was
difficult to tell the source apart. Hopefully changing it won't make
this problem any harder.

Lukas will likely know more about the design.

··· On 21/03/14 18:40, Bryan Kearney wrote: > Mike, Eric, Dom, Ohad.. you guys wanna jump in here? I can see Eric's > point about not swtiching roots, and I can see Dom's about being > consistent across plugins. I really not have have a horse in the race > other than correct strings :) > > https://github.com/Katello/katello/pull/3865


Dominic Cleal
Red Hat Engineering

> I wouldn't mind Foreman's extraction task being changed to work from the
> Foreman checkout direction if it's possible, seems a better idea.
>
> My only hunch is that it's this way because our first plugins would run
> tests this way (using Foreman checked out inside the plugin) so it may
> have been built on top of this assumption.

I second that.

We can still require foreman checkout for test running and for i18n we
can do it the other way. If deal, let's create a feature task for that.

> The model attribute extraction (#3023) was a good deal harder I think
> because it was running in a combined Foreman + plugin context, so it was
> difficult to tell the source apart. Hopefully changing it won't make
> this problem any harder.

Yeah, this task is still outstanding.

In Rails, lots of things depend on correct model names. We need to
extract those guys.

Currently, there is no support for plugins. Model (table) names are
simply not extracted, thus not translated. The same for Javascripts.

It looks like it would be better approach if a Katello dev could work on
this task, because Katello is the biggest plugin and once it is well
designed for Katello, it will definitely work on others.

··· -- Later,

Lukas “lzap” Zapletal
irc: lzap #theforeman