Issue with foreman tests

ekohl · October 23, 2017, 3:59pm

Hello all,

On Friday a PR was merged1 that was intended to verify seeding worked.
It turns out that you can't run rake db:migrate db:seed in one command
which resulted in failing tests. An issue has been created2 and a
workaround implemented3. Please rerun tests that failed on

NOT NULL constraint failed: architectures.name: INSERT INTO "architectures" ("created_at", "updated_at") VALUES (?, ?)

If tests are still broken after that please do report back.

ehelms · October 23, 2017, 4:04pm

In hindsight, I should caught this on the PR. This scratched an itch in the
back of mind and there was the reminder:

github.com

Katello/katello/blob/master/lib/katello/tasks/reset.rake#L52


end


task :reset => ['environment'] do
  ENV['SEED_ADMIN_PASSWORD'] ||= 'changeme'
  ENV['SEED_ORGANIZATION'] ||= 'Default Organization'
  ENV['SEED_LOCATION'] ||= 'Default Location'
  Rake::Task['katello:reset_backends'].invoke
  Rake::Task['db:drop'].invoke
  Rake::Task['db:create'].invoke


  # Otherwise migration and seeds fail because they require a reloaded environment
  system('rake db:migrate')
  system('rake db:seed')
  Rake::Task['katello:reset_default_smart_proxy'].invoke
end
end

···

On Mon, Oct 23, 2017 at 11:59 AM, Ewoud Kohl van Wijngaarden < ewoud@kohlvanwijngaarden.nl> wrote:

Hello all,

On Friday a PR was merged1 that was intended to verify seeding worked.
It turns out that you can’t run rake db:migrate db:seed in one command
which resulted in failing tests. An issue has been created[2] and a
workaround implemented[3]. Please rerun tests that failed on

NOT NULL constraint failed: architectures.name: INSERT INTO
"architectures" (“created_at”, “updated_at”) VALUES (?, ?)

If tests are still broken after that please do report back.

8e2a60306a13154a7727e638bb4a874
[2]: Bug #21431: Seeding architectures triggers a NOT NULL contstraint error - Foreman
[3]: https://github.com/theforeman/foreman-infra/commit/5099902d7
1e79ce7a0b2ec80239d942b92373ecf

–
You received this message because you are subscribed to the Google Groups
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

–
Eric D. Helms
Red Hat Engineering

evgeni · October 26, 2017, 6:30am

Ugh, sorry for making such a mess. Seems I did not test the final
version of that PR well enough.

Thanks Ewoud for fixing this!

···

On Mon, Oct 23, 2017 at 6:04 PM, Eric D Helms wrote: > In hindsight, I should caught this on the PR. This scratched an itch in the > back of mind and there was the reminder: > > https://github.com/Katello/katello/blob/master/lib/katello/tasks/reset.rake#L52 > > On Mon, Oct 23, 2017 at 11:59 AM, Ewoud Kohl van Wijngaarden > wrote: >> >> Hello all, >> >> On Friday a PR was merged[1] that was intended to verify seeding worked. >> It turns out that you can't run rake db:migrate db:seed in one command which >> resulted in failing tests. An issue has been created[2] and a workaround >> implemented[3]. Please rerun tests that failed on >> >> NOT NULL constraint failed: architectures.name: INSERT INTO >> "architectures" ("created_at", "updated_at") VALUES (?, ?) >> >> If tests are still broken after that please do report back. >> >> [1]: >> https://github.com/theforeman/foreman-infra/commit/b275d94f88e2a60306a13154a7727e638bb4a874 >> [2]: https://projects.theforeman.org/issues/21431 >> [3]: >> https://github.com/theforeman/foreman-infra/commit/5099902d71e79ce7a0b2ec80239d942b92373ecf >> >> -- >> You received this message because you are subscribed to the Google Groups >> "foreman-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to foreman-dev+unsubscribe@googlegroups.com. >> For more options, visit https://groups.google.com/d/optout. > > > > > -- > Eric D. Helms > Red Hat Engineering > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscribe@googlegroups.com. > For more options, visit https://groups.google.com/d/optout.

–
Beste Grüße/Kind regards,

Evgeni Golov
Software Engineer

Red Hat GmbH, http://www.de.redhat.com/, Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Michael Cunningham, Michael
O’Neill, Eric Shander