Ohad,
The integration testing on the 3.2 pull request shows JS errors for compute_resources#new and users#new. Certain fields on the form are not becoming visible after a dropbox selection. Amos says that it has to do with ComputeResource STI and User STI handling in Rails 3.2
Joseph
Amos,
I fixed the JS errors for compute_resources#new and users#new on my branch, and now the integration tests pass
https://github.com/isratrade/foreman/pull/new/rails32_amos2
Do you want to include this comments in your pull request or should I send a new one.
There are still serveral link_to_functions that apparently there is no test coverage.
Joseph
Ohad,
The integration testing on the 3.2 pull request shows JS errors for compute_resources#new and users#new. Certain fields on the form are not becoming visible after a dropbox selection. Amos says that it has to do with ComputeResource STI and User STI handling in Rails 3.2
Joseph
–
You received this message because you are subscribed to the Google Groups “foreman-dev” group.
To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
Ohad, Amos,
I am running the rails 3.2 test.rb environment like production.rb with the following
config.assets.compress = true
config.assets.compile = false
config.assets.digest = true
Before running rake assets:precompile, I needed to add the following line to compile js files that are not in application.js (and thus not compiled by default). Btw, the same is true for css, if there are files that are included just on a particular page.
config.assets.precompile += %w(compute_resource.js
charts.js
config_template.js
host_checkbox.js
host_edit.js
jrails.js
lookup_keys.js
nfs_visiblity.js
noVNC.js
reports.js
spice.js
taxonomy.js
trends.js
vendor.js
)
This copies all the files into public/assets. Afaik, they are still separate files and not all minified into one file. That is the case for js included in application.js
Regards,
Joseph
Amos,
I fixed the JS errors for compute_resources#new and users#new on my branch, and now the integration tests pass
https://github.com/isratrade/foreman/pull/new/rails32_amos2
Do you want to include this comments in your pull request or should I send a new one.
There are still serveral link_to_functions that apparently there is no test coverage.
Joseph
----- Original Message -----
From: “Joseph Magen” jmagen@redhat.com
To: “foreman-dev” foreman-dev@googlegroups.com
Sent: Tuesday, March 19, 2013 6:40:39 PM
Subject: [foreman-dev] js errors on 3.2 branch
Ohad,
The integration testing on the 3.2 pull request shows JS errors for compute_resources#new and users#new. Certain fields on the form are not becoming visible after a dropbox selection. Amos says that it has to do with ComputeResource STI and User STI handling in Rails 3.2
Joseph
–
You received this message because you are subscribed to the Google Groups “foreman-dev” group.
To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
–
You received this message because you are subscribed to the Google Groups “foreman-dev” group.
To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.