Need assistance from foreman pull-request reviewers

Work on SAM, the Red Hat subscription managment product that is a subset of Satellite6 functionality, has begun in earnest. Although I hope to reduce the UI presentation layer through roles and permissions as much as possible, there is going to be a lot that will need to be done through 'deface' as well. It is my goal to be as unobtrusive as possible and not ask foreman itself to go out of the way to accommodate SAM. This means, however, that any changes to erb files, no matter how small, in the areas that SAM is defacing run the very likely chance of breaking the plugin. Because of this, I would like to ask code reviewers to please assist me in @mentioning me, thomasmckay, in any P-Rs that touch the erb files so I can stay ahead of the breakage. The common areas of foreman are the "core" features: Organizations (taxonomies), context selector, menus, audits, tasks, LDAP authentication, users, user groups, roles, settings, and about page.

Thanks for understanding.

··· -- @thomasmckay


“The leader must aim high, see big, judge widely, thus setting himself apart form the ordinary people who debate in narrow confines.” ~ Charles De Gaulle

“Leadership is about making others better as a result of your presence and making sure that impact lasts in your absence.” ~ Harvard Business School

I'm guessing this can be added to https://github.com/theforeman/prprocessor
?
I'll mention you for the time being, but if it's not automated at some
point me or someone else will forget…

··· On Tue, Oct 14, 2014 at 2:32 AM, Tom McKay wrote:

Work on SAM, the Red Hat subscription managment product that is a subset
of Satellite6 functionality, has begun in earnest. Although I hope to
reduce the UI presentation layer through roles and permissions as much as
possible, there is going to be a lot that will need to be done through
’deface’ as well. It is my goal to be as unobtrusive as possible and not
ask foreman itself to go out of the way to accommodate SAM. This means,
however, that any changes to erb files, no matter how small, in the areas
that SAM is defacing run the very likely chance of breaking the plugin.
Because of this, I would like to ask code reviewers to please assist me in
@mentioning me, thomasmckay, in any P-Rs that touch the erb files so I can
stay ahead of the breakage. The common areas of foreman are the "core"
features: Organizations (taxonomies), context selector, menus, audits,
tasks, LDAP authentication, users, user groups, roles, settings, and about
page.

Thanks for understanding.


@thomasmckay


“The leader must aim high, see big, judge widely, thus setting himself
apart form the ordinary people who debate in narrow confines.” ~ Charles De
Gaulle

“Leadership is about making others better as a result of your presence and
making sure that impact lasts in your absence.” ~ Harvard Business School


You received this message because you are subscribed to the Google Groups
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Daniel Lobato

@elobatoss
blog.daniellobato.me
daniellobato.me

GPG: http://keys.gnupg.net/pks/lookup?op=get&search=0x7A92D6DD38D6DE30