New Jenkins integration test failures

Hi Foreman devs,

I took some time yesterday to look at the test failures on Jenkins. A
while ago Dominic opened Bug #13293: Intermittent host#edit parameter integration test failures after timeout - Foreman to
keep track of the intermittent integration test failures.

Since then, we have not fixed any of these and they show up randomly.
However, new ones that are not documented in the ticket show up too:

http://ci.theforeman.org/job/test_develop_pr_core/8122/
http://ci.theforeman.org/job/test_develop_pr_core/8119/
http://ci.theforeman.org/job/test_develop_pr_core/8091/

Please exercise caution before merging new PRs and look at that ticket
to ensure new intermittent failures are not being introduced.

Aside from that, if you can offer help fixing these I'd very much
appreciate it. Even if you can find a reliable way of reproducing the
issues that'd be great, as I don't have one yet.

Have a good day!

··· -- Daniel Lobato Garcia

@dLobatog
blog.daniellobato.me
daniellobato.me

GPG: http://keys.gnupg.net/pks/lookup?op=get&search=0x7A92D6DD38D6DE30
Keybase: https://keybase.io/elobato

> Hi Foreman devs,
>
> I took some time yesterday to look at the test failures on Jenkins.
> A while ago Dominic opened
> Bug #13293: Intermittent host#edit parameter integration test failures after timeout - Foreman to keep track of the
> intermittent integration test failures.
>
> Since then, we have not fixed any of these and they show up
> randomly. However, new ones that are not documented in the ticket
> show up too:
>
> http://ci.theforeman.org/job/test_develop_pr_core/8122/

The common theme of all of these failures is that they're under the JS
driver which is only used in a few test files, e.g. in HostsController.

> http://ci.theforeman.org/job/test_develop_pr_core/8119/

The second error here is different. It looks like the same error I
was hitting when enabling capybara-screenshot, but I couldn't figure
out why it happened.

NoMethodError: undefined method minutes' for nil:NilClass app/controllers/concerns/foreman/controller/session.rb:25:inupdate_activity_time'
app/controllers/concerns/application_shared.rb:13:in set_timezone' app/models/concerns/foreman/thread_session.rb:32:inclear_thread'
lib/middleware/catch_json_parse_errors.rb:9:in `call' (NoMethodError)
/var/lib/workspace/workspace/test_develop_pr_core/database/postgresql/label/fast/ruby/2.1/app/controllers/concerns/foreman/controller/session.rb:25

> http://ci.theforeman.org/job/test_develop_pr_core/8091/

This is on 1.10-stable, so I'd discount it for now as #13111 (the
previous round of fixes) are only on develop.

> Please exercise caution before merging new PRs and look at that
> ticket to ensure new intermittent failures are not being
> introduced.

Indeed, and please avoid re-running the whole test suite if it is an
unrelated intermittent error as it delays tests on other PRs and plugins.

··· On 17/02/16 07:07, Daniel Lobato Garcia wrote:


Dominic Cleal
dominic@cleal.org