Hello,
As many of you may have noticed, foreman-core open PR count has been in
the area of 100-110 for most of the last few months. There are only a few
people with merge access that actively review PRs, so that the time it
takes for changes to be accepted can take long. I would like to propose
granting merge access to two more members of the community:
Shimon Shtein - has 75 merged commits [1] and has taken part in the reviews
of 64 merged commits[2].
Michael Moll - has 71 merged commits [3] and has taken part in the reviews
of 130 merged commits[4]. He is also already a long time maintainer of
several of our other repos and has proven to be a responsible maintainer.
Please send +1/-1 either to the list or to me in private if you prefer.
Per our process, unless I receive any objections within a week, I will
request one of the organization owners to grant them access.
[1]
https://github.com/theforeman/foreman/pulls?q=is%3Apr+author%3Ashimshtein+is%3Aclosed
[2]
https://github.com/theforeman/foreman/pulls?utf8=%E2%9C%93&q=is%3Apr+-author%3Ashimshtein+commenter%3Ashimshtein+is%3Aclosed+
[3]
https://github.com/theforeman/foreman/pulls?utf8=%E2%9C%93&q=is%3Apr+author%3Ammoll+is%3Aclosed+
[4]
https://github.com/theforeman/foreman/pulls?utf8=%E2%9C%93&q=is%3Apr+-author%3Ammoll+commenter%3Ammoll+is%3Aclosed+
···
--
Have a nice day,
Tomer Brisker
Red Hat Engineering
Hello,
As many of you may have noticed, foreman-core open PR count has been in
the area of 100-110 for most of the last few months. There are only a few
people with merge access that actively review PRs, so that the time it
takes for changes to be accepted can take long. I would like to propose
granting merge access to two more members of the community:
Shimon Shtein - has 75 merged commits [1] and has taken part in the reviews
of 64 merged commits[2].
Michael Moll - has 71 merged commits [3] and has taken part in the reviews
of 130 merged commits[4]. He is also already a long time maintainer of
several of our other repos and has proven to be a responsible maintainer.
Please send +1/-1 either to the list or to me in private if you prefer.
Per our process, unless I receive any objections within a week, I will
request one of the organization owners to grant them access.
+1 to both :)
[1]
https://github.com/theforeman/foreman/pulls?q=is%3Apr+
author%3Ashimshtein+is%3Aclosed
[2]
https://github.com/theforeman/foreman/pulls?utf8=%E2%9C%93&
q=is%3Apr+-author%3Ashimshtein+commenter%3Ashimshtein+is%3Aclosed+
[3]
https://github.com/theforeman/foreman/pulls?utf8=%E2%9C%93&
q=is%3Apr+author%3Ammoll+is%3Aclosed+
[4]
https://github.com/theforeman/foreman/pulls?utf8=%E2%9C%93&
q=is%3Apr+-author%3Ammoll+commenter%3Ammoll+is%3Aclosed+
···
On Dec 6, 2017 7:41 AM, "Tomer Brisker" <tbrisker@redhat.com> wrote:
--
Have a nice day,
Tomer Brisker
Red Hat Engineering
--
You received this message because you are subscribed to the Google Groups
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Yes, please. We can use all the help we can get and both Shimon and Michael are doing great work.
Thanks Tomer for bringing this up.
···
On 7. Dec 2017, at 09:23, Ondrej Prazak <oprazak@redhat.com> wrote:
+1 to both
On Wed, Dec 6, 2017 at 5:19 PM, Ivan Necas <inecas@redhat.com> wrote:
+2
-- Ivan
On Wed, 6 Dec 2017 at 16:51, Lukas Zapletal <lzap@redhat.com> wrote:
+1 +1 beer time!
LZ
On Wed, Dec 6, 2017 at 1:40 PM, Tomer Brisker <tbrisker@redhat.com> wrote:
Hello,
As many of you may have noticed, foreman-core open PR count has been in the
area of 100-110 for most of the last few months. There are only a few people
with merge access that actively review PRs, so that the time it takes for
changes to be accepted can take long. I would like to propose granting merge
access to two more members of the community:
Shimon Shtein - has 75 merged commits [1] and has taken part in the reviews
of 64 merged commits[2].
Michael Moll - has 71 merged commits [3] and has taken part in the reviews
of 130 merged commits[4]. He is also already a long time maintainer of
several of our other repos and has proven to be a responsible maintainer.
Please send +1/-1 either to the list or to me in private if you prefer.
Per our process, unless I receive any objections within a week, I will
request one of the organization owners to grant them access.
[1]
https://github.com/theforeman/foreman/pulls?q=is%3Apr+author%3Ashimshtein+is%3Aclosed
[2]
https://github.com/theforeman/foreman/pulls?utf8=%E2%9C%93&q=is%3Apr+-author%3Ashimshtein+commenter%3Ashimshtein+is%3Aclosed+
[3]
https://github.com/theforeman/foreman/pulls?utf8=%E2%9C%93&q=is%3Apr+author%3Ammoll+is%3Aclosed+
[4]
https://github.com/theforeman/foreman/pulls?utf8=%E2%9C%93&q=is%3Apr+-author%3Ammoll+commenter%3Ammoll+is%3Aclosed+
--
Have a nice day,
Tomer Brisker
Red Hat Engineering
--
You received this message because you are subscribed to the Google Groups
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--
Later,
Lukas @lzap Zapletal
--
You received this message because you are subscribed to the Google Groups "foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups "foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups "foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Hello,
A week has passed with multiple +1's and no objections. Congrats Shimon and
Michael!
Can one of the organization owners please do the honors?
Tomer
···
On Thu, Dec 7, 2017 at 5:03 PM, Daniel Lobato Garcia <elobatocs@gmail.com> wrote:
On 12/06, Ewoud Kohl van Wijngaarden wrote:
> On Wed, Dec 06, 2017 at 02:40:36PM +0200, Tomer Brisker wrote:
> > Shimon Shtein - has 75 merged commits [1] and has taken part in the
reviews
> > of 64 merged commits[2].
>
> +1
+1
>
> > Michael Moll - has 71 merged commits [3] and has taken part in the
reviews
> > of 130 merged commits[4]. He is also already a long time maintainer of
> > several of our other repos and has proven to be a responsible
maintainer.
>
> +1
+1
>
> --
> You received this message because you are subscribed to the Google
Groups "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send
an email to foreman-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout\.
--
Daniel Lobato Garcia
@dLobatog
blog.daniellobato.me
daniellobato.me
GPG: http://keys.gnupg.net/pks/lookup?op=get&search=0x7A92D6DD38D6DE30
Keybase: elobato (Daniel Lobato Garcia) | Keybase
--
You received this message because you are subscribed to the Google Groups
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout\.
--
Have a nice day,
Tomer Brisker
Red Hat Engineering
Added to the Core team, congrats both.
Greg
···
On 13/12/17 17:28, Tomer Brisker wrote:
Hello,
A week has passed with multiple +1's and no objections. Congrats Shimon and
Michael!
Can one of the organization owners please do the honors?
