You may notice some repositories with multiple build badges. That's
because puppet-foreman_proxy has an oldstable branch1 and
puppet-concat has oldmaster2. Do these still serve any purpose or can
we delete them?
This was required to keep the older submodule reference in the main
foreman-installer project working when we did a force push over the top
of master. e.g. a stable branch in foreman-installer refers to a SHA
that isn't in the current "master" branch, so checkout would fail if
there wasn't a head/branch in this module containing the SHA.
···
On 14/10/13 14:55, Ewoud Kohl van Wijngaarden wrote:
That was me. When I did the initial work to parameterize the installer, I
kept a version that would work with puppet<2.6.5 for people on older
systems. We made the decision to not support these old versions in the
installer a while ago, so it can be deleted now I think.
···
On 15 October 2013 10:32, Dominic Cleal wrote:
On 14/10/13 14:55, Ewoud Kohl van Wijngaarden wrote:
You may notice some repositories with multiple build badges. That’s
because puppet-foreman_proxy has an oldstable branch1 and
puppet-concat has oldmaster[2]. Do these still serve any purpose or can
we delete them?
You say was, so is it's no longer needed? Can we just make a tag
instead? And speaking of tags, I've noticed we haven't pushed any.
···
On Tue, Oct 15, 2013 at 10:32:41AM +0100, Dominic Cleal wrote:
> On 14/10/13 14:55, Ewoud Kohl van Wijngaarden wrote:
> > Hello all,
> >
> > I was working on a small dashboard overview for myself (similar to
> > https://github.com/organizations/theforeman/dashboard/issues, but I
> > intend to add other sources as well). See http://ekohl.nl/dashboard.png.
> >
> > You may notice some repositories with multiple build badges. That's
> > because puppet-foreman_proxy has an oldstable branch[1] and
> > puppet-concat has oldmaster[2]. Do these still serve any purpose or can
> > we delete them?
> >
> > [1]: https://github.com/theforeman/puppet-foreman_proxy/tree/oldstable
>
> I don't know the history of this.
>
> > [2]: https://github.com/theforeman/puppet-concat/tree/oldmaster
>
> This was required to keep the older submodule reference in the main
> foreman-installer project working when we did a force push over the top
> of master. e.g. a stable branch in foreman-installer refers to a SHA
> that isn't in the current "master" branch, so checkout would fail if
> there wasn't a head/branch in this module containing the SHA.
Probably no longer needed, IIRC it was from Foreman 1.1. A tag might
work too, I haven't tried.
···
On 15/10/13 11:04, Ewoud Kohl van Wijngaarden wrote:
> On Tue, Oct 15, 2013 at 10:32:41AM +0100, Dominic Cleal wrote:
>> On 14/10/13 14:55, Ewoud Kohl van Wijngaarden wrote:
>>> Hello all,
>>>
>>> I was working on a small dashboard overview for myself (similar to
>>> https://github.com/organizations/theforeman/dashboard/issues, but I
>>> intend to add other sources as well). See http://ekohl.nl/dashboard.png.
>>>
>>> You may notice some repositories with multiple build badges. That's
>>> because puppet-foreman_proxy has an oldstable branch[1] and
>>> puppet-concat has oldmaster[2]. Do these still serve any purpose or can
>>> we delete them?
>>>
>>> [1]: https://github.com/theforeman/puppet-foreman_proxy/tree/oldstable
>>
>> I don't know the history of this.
>>
>>> [2]: https://github.com/theforeman/puppet-concat/tree/oldmaster
>>
>> This was required to keep the older submodule reference in the main
>> foreman-installer project working when we did a force push over the top
>> of master. e.g. a stable branch in foreman-installer refers to a SHA
>> that isn't in the current "master" branch, so checkout would fail if
>> there wasn't a head/branch in this module containing the SHA.
>
> You say was, so is it's no longer needed? Can we just make a tag
> instead? And speaking of tags, I've noticed we haven't pushed any.
