http://theforeman.org/issues/1567
Been thinking about fixing this one long enough that I finally made an
attempt at it:
https://github.com/frimik/smart-proxy/commit/5f606f62975fc4dcd597c28e3773dd2f051c0545
Would be nice if someone could verify or give feedback on how to
improve it further if needed.
The include parsing is rather simple, because I believe ISC dhcp is
rather stringent on the format here…
and does not accept single quotes at all so the above should be fairly
correct.
···
From my testing it requires filename string enclosed in double quotes
–
Mikael Fridh
Marin Software
I can test this tonight - looks really handy, as I can probably drop
the concat dependency from the dhcp module.
Greg
OpenPGP -> KeyID: CA0AEB93
···
On 12/06/12 19:17, Mikael Fridh wrote:
> http://theforeman.org/issues/1567
>
> Been thinking about fixing this one long enough that I finally made
> an attempt at it:
>
> https://github.com/frimik/smart-proxy/commit/5f606f62975fc4dcd597c28e3773dd2f051c0545
>
> Would be nice if someone could verify or give feedback on how to
> improve it further if needed.
>
> The include parsing is rather simple, because I believe ISC dhcp
> is rather stringent on the format here.. + if
> /^include\s+"(.*)"\s*;/ =~ line.strip
>
> From my testing it requires filename string enclosed in double
> quotes and does not accept single quotes at all so the above should
> be fairly correct.
This has been merged into theforeman:develop now. Thanks Ohad.
well, you can still test it regardless 
···
On Wed, Jun 13, 2012 at 3:06 PM, Mikael Fridh wrote:
This has been merged into theforeman:develop now. Thanks Ohad.
Yes indeed, please do! I meant so Greg will test from the theforeman
repo instead of mine!
···
On Wed, Jun 13, 2012 at 2:08 PM, Ohad Levy wrote:
> On Wed, Jun 13, 2012 at 3:06 PM, Mikael Fridh wrote:
>>
>> This has been merged into theforeman:develop now. Thanks Ohad.
>
>
> well, you can still test it regardless ;)
