[PATCH/foreman 1/1] fixes #1374 - Overwriting of valid IP when subnet selected

Development
#1

Signed-off-by: Paul Kelly <paul.ian.kelly@googlemail.com>

··· --- public/javascripts/host_edit.js | 23 +++++++++++++++++++++++ 1 files changed, 23 insertions(+), 0 deletions(-)

diff --git a/public/javascripts/host_edit.js b/public/javascripts/host_edit.js
index d299b6a…d375ac4 100644
— a/public/javascripts/host_edit.js
+++ b/public/javascripts/host_edit.js
@@ -81,6 +81,13 @@ function hypervisor_selected(element){
function subnet_selected(element){
var subnet_id = $(element).val();
if (subnet_id == ‘’ || $(’#host_ip’).size() == 0) return false;

  • // We do not query the proxy if the host_ip field is filled in and contains an
  • // IP that is in the selected subnet
  • var drop_text = $(element).text().split("\n")[subnet_id]
  • if (drop_text.length !=0 && drop_text.search(/^.+ ([0-9./]+)/) != -1) {
  • var details = $(element).text().split("\n")[subnet_id].replace(/^[^(]+(/, “”).replace(")","").split("/");
  • if (subnet_contains(details[0], details[1], $(’#host_ip’).val())) return false;
  • }
    $(’#subnet_indicator’).show();
    $.ajax({
    data:‘subnet_id=’ + subnet_id,
    @@ -90,6 +97,22 @@ function subnet_selected(element){
    })
    }

+function subnet_contains(number, cidr, ip){

  • var int_ip = _to_int(ip);
  • var int_number = _to_int(number);
  • var shift = 32 - parseInt(cidr);
  • return (int_ip >> shift == int_number >> shift);
    +}

+function _to_int(str){

  • var nibble = str.split(".");
  • var integer = 0;
  • for(i=0;i<=3;i++){
  • integer = (integer * 256) + parseInt(nibble[i]);
  • }
  • return integer
    +}

function domain_selected(element){
var domain_id = $(element).val();
$.ajax({

1.7.5.4