Plugins: upgrading deface to 1.x

Development
#1

I'd like to begin the process of updating the deface gem in our plugin
packages to 1.x, so we get the latest bug fixes etc and also to fix some
confusion for plugin authors who we ask to pin it to < 1.0 for
compatibility with other plugins.

This needs action from anybody who is willing to contribute to, or
maintains these plugins:

  1. ovirt_provision_plugin
  2. foreman_discovery
  3. foreman_setup
  4. foreman_salt
  5. foreman_simplify
  6. foreman_mco
  7. foreman_openscap
  8. foreman_chef
  9. foreman_dhcp_browser
  10. foreman_xen
  11. foreman_column_view
  12. katello

There is one incompatible change, so if you have any defacing in a
plugin that uses "code", e.g. code[erb-loud] or code[erb-silent] etc,
then skip further down this message.

If you do not have this, i.e. your deface is compatible with 1.x, then
please relax the deface dependency in the plugin. I'd suggest removing
the version constraint or setting it to &lt; 2.0.

If you do use "code", you can either keep compatibility with both, or
only support 1.x.

To be compatible with both, have two defaces, one for 1.x and one for
0.x - see
https://github.com/theforeman/foreman-xen/tree/master/app/overrides/hosts/show
for an example. As long as your master branch is used with 1.9 or
older, then you'll need to keep them.

Or you can require deface >= 1.0, and only push that version of the
plugin to the nightly/1.10 plugin users/repositories - as I don't intend
on trying to put deface 1.x into the 1.9 plugin repos.

Please let me know here if a plugin is known to be OK or has been
updated. Some of the plugins above I know aren't actively maintained,
so I'll go through them and check and fix them if required and possible,
or we'll remove them from the repos.

Once the packages that depend on deface are known to be updated or OK,
then we can try and push the new version out.

Thanks for your co-operation.

··· -- Dominic Cleal Red Hat Engineering
#2

> I'd like to begin the process of updating the deface gem in our plugin
> packages to 1.x, so we get the latest bug fixes etc and also to fix some
> confusion for plugin authors who we ask to pin it to < 1.0 for
> compatibility with other plugins.
>
> This needs action from anybody who is willing to contribute to, or
> maintains these plugins:
>
> 1. ovirt_provision_plugin
> 2. foreman_discovery
> 3. foreman_setup
> 4. foreman_salt
> 5. foreman_simplify
> 6. foreman_mco
> 7. foreman_openscap
> 9. foreman_chef
> 10. foreman_dhcp_browser
> 11. foreman_xen
> 12. foreman_column_view
> 13. katello
>
> There is one incompatible change, so if you have any defacing in a
> plugin that uses "code", e.g. code[erb-loud] or code[erb-silent] etc,
> then skip further down this message.
>
> If you do not have this, i.e. your deface is compatible with 1.x, then
> please relax the deface dependency in the plugin. I'd suggest removing
> the version constraint or setting it to &lt; 2.0.
>
> If you do use "code", you can either keep compatibility with both, or
> only support 1.x.
>
> To be compatible with both, have two defaces, one for 1.x and one for
> 0.x - see
>
> https://github.com/theforeman/foreman-xen/tree/master/app/overrides/hosts/show
> for an example. As long as your master branch is used with 1.9 or
> older, then you'll need to keep them.
>
> Or you can require deface >= 1.0, and only push that version of the
> plugin to the nightly/1.10 plugin users/repositories - as I don't intend
> on trying to put deface 1.x into the 1.9 plugin repos.
>
> Please let me know here if a plugin is known to be OK or has been
> updated. Some of the plugins above I know aren't actively maintained,
> so I'll go through them and check and fix them if required and possible,
> or we'll remove them from the repos.
>

foreman_dhcp_browser has been updated at
https://github.com/theforeman/foreman_dhcp_browser/pull/16

Ohad

··· On Thu, Jul 9, 2015 at 10:49 AM, Dominic Cleal wrote:

Once the packages that depend on deface are known to be updated or OK,
then we can try and push the new version out.

Thanks for your co-operation.

–
Dominic Cleal
Red Hat Engineering

–
You received this message because you are subscribed to the Google Groups
“foreman-dev” group.
To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

#3

I've made a note to update column_view when I have a few minutes.
Hopefully within the next week.

Greg

··· On 9 July 2015 at 08:49, Dominic Cleal wrote: > 12. foreman_column_view
#4

> 2. foreman_discovery

Discovery deps relaxed:

https://github.com/theforeman/foreman_discovery/pull/196

··· -- Later, Lukas #lzap Zapletal
#5

I've opened a PR for katello: https://github.com/Katello/katello/pull/5355

··· On 07/09/2015 03:49 AM, Dominic Cleal wrote: > I'd like to begin the process of updating the deface gem in our plugin > packages to 1.x, so we get the latest bug fixes etc and also to fix some > confusion for plugin authors who we ask to pin it to < 1.0 for > compatibility with other plugins. > > This needs action from anybody who is willing to contribute to, or > maintains these plugins: > > 1. ovirt_provision_plugin > 2. foreman_discovery > 3. foreman_setup > 4. foreman_salt > 5. foreman_simplify > 6. foreman_mco > 7. foreman_openscap > 9. foreman_chef > 10. foreman_dhcp_browser > 11. foreman_xen > 12. foreman_column_view > 13. katello > > There is one incompatible change, so if you have any defacing in a > plugin that uses "code", e.g. code[erb-loud] or code[erb-silent] etc, > then skip further down this message. > > If you do not have this, i.e. your deface is compatible with 1.x, then > please relax the deface dependency in the plugin. I'd suggest removing > the version constraint or setting it to `< 2.0`. > > If you do use "code", you can either keep compatibility with both, or > only support 1.x. > > To be compatible with both, have two defaces, one for 1.x and one for > 0.x - see > https://github.com/theforeman/foreman-xen/tree/master/app/overrides/hosts/show > for an example. As long as your master branch is used with 1.9 or > older, then you'll need to keep them. > > Or you can require deface >= 1.0, and only push that version of the > plugin to the nightly/1.10 plugin users/repositories - as I don't intend > on trying to put deface 1.x into the 1.9 plugin repos. > > Please let me know here if a plugin is known to be OK or has been > updated. Some of the plugins above I know aren't actively maintained, > so I'll go through them and check and fix them if required and possible, > or we'll remove them from the repos. > > Once the packages that depend on deface are known to be updated or OK, > then we can try and push the new version out. > > Thanks for your co-operation. >
#6

Hello

> 9. foreman_chef
foreman_chef 0.1.6 contains the fix, built rpm and deb into nightlies

··· -- Marek

On Thursday 09 of July 2015 08:49:12 Dominic Cleal wrote:

I’d like to begin the process of updating the deface gem in our plugin
packages to 1.x, so we get the latest bug fixes etc and also to fix some
confusion for plugin authors who we ask to pin it to < 1.0 for
compatibility with other plugins.

This needs action from anybody who is willing to contribute to, or
maintains these plugins:

  1. ovirt_provision_plugin
  2. foreman_discovery
  3. foreman_setup
  4. foreman_salt
  5. foreman_simplify
  6. foreman_mco
  7. foreman_openscap
  8. foreman_chef
  9. foreman_dhcp_browser
  10. foreman_xen
  11. foreman_column_view
  12. katello

There is one incompatible change, so if you have any defacing in a
plugin that uses “code”, e.g. code[erb-loud] or code[erb-silent] etc,
then skip further down this message.

If you do not have this, i.e. your deface is compatible with 1.x, then
please relax the deface dependency in the plugin. I’d suggest removing
the version constraint or setting it to < 2.0.

If you do use “code”, you can either keep compatibility with both, or
only support 1.x.

To be compatible with both, have two defaces, one for 1.x and one for
0.x - see
https://github.com/theforeman/foreman-xen/tree/master/app/overrides/hosts/sh
ow for an example. As long as your master branch is used with 1.9 or older,
then you’ll need to keep them.

Or you can require deface >= 1.0, and only push that version of the
plugin to the nightly/1.10 plugin users/repositories - as I don’t intend
on trying to put deface 1.x into the 1.9 plugin repos.

Please let me know here if a plugin is known to be OK or has been
updated. Some of the plugins above I know aren’t actively maintained,
so I’ll go through them and check and fix them if required and possible,
or we’ll remove them from the repos.

Once the packages that depend on deface are known to be updated or OK,
then we can try and push the new version out.

Thanks for your co-operation.

–
Marek

#7

Just a small status update - it looks like we're mostly waiting for
plugins to be released. No major urgency, just please try to do it by
early-mid September so there's time before 1.10 to update deface.

> 1. ovirt_provision_plugin

Not pinned or affected.

> 2. foreman_discovery

Relaxed, pending release.

> 3. foreman_setup

Dependency removed, pending release.

> 4. foreman_salt

Relaxed, pending release.

> 5. foreman_simplify

Not pinned, but is affected. Will remove this as it's a dead project.

> 6. foreman_mco

Not pinned or affected, I'll remove it at some point as it's unmaintained.

> 7. foreman_openscap

Relaxed, pending release.

> 9. foreman_chef

Relaxed and released in 0.1.6.

> 10. foreman_dhcp_browser

Relaxed, pending release.

> 11. foreman_xen

Needs to be relaxed and released, already supports both.

> 12. foreman_column_view

PR opened: https://github.com/GregSutcliffe/foreman_column_view/pull/16.

> 13. katello

PR open: https://github.com/Katello/katello/pull/5355

··· On 09/07/15 08:49, Dominic Cleal wrote:

–
Dominic Cleal
Red Hat Engineering

#8

> I'd like to begin the process of updating the deface gem in our plugin
> packages to 1.x, so we get the latest bug fixes etc and also to fix some
> confusion for plugin authors who we ask to pin it to < 1.0 for
> compatibility with other plugins.
>
[…]
> Once the packages that depend on deface are known to be updated or OK,
> then we can try and push the new version out.

Thanks to all the plugin maintainers for their updates. The Debian
deface packages was updated a few days ago, and I'm now building the
corresponding RPMs.

Deface 1.x will only be available in the nightly and 1.10 or higher
repositories, so maintainers can now specify 1.0 as a minimum version if
using its new ERB style in an override, provided the plugin only needs
to be made available to 1.10+ users.

Regards,

··· On 09/07/15 08:49, Dominic Cleal wrote:

–
Dominic Cleal
Red Hat Engineering

#9

foreman_openscap has beeb updated at
https://github.com/theforeman/foreman_openscap/pull/114

··· 2015-07-09 11:07 GMT+03:00 Ohad Levy :

On Thu, Jul 9, 2015 at 10:49 AM, Dominic Cleal dcleal+g@redhat.com > wrote:

I’d like to begin the process of updating the deface gem in our plugin
packages to 1.x, so we get the latest bug fixes etc and also to fix some
confusion for plugin authors who we ask to pin it to < 1.0 for
compatibility with other plugins.

This needs action from anybody who is willing to contribute to, or
maintains these plugins:

  1. ovirt_provision_plugin
  2. foreman_discovery
  3. foreman_setup
  4. foreman_salt
  5. foreman_simplify
  6. foreman_mco
  7. foreman_openscap
  8. foreman_chef
  9. foreman_dhcp_browser
  10. foreman_xen
  11. foreman_column_view
  12. katello

There is one incompatible change, so if you have any defacing in a
plugin that uses “code”, e.g. code[erb-loud] or code[erb-silent] etc,
then skip further down this message.

If you do not have this, i.e. your deface is compatible with 1.x, then
please relax the deface dependency in the plugin. I’d suggest removing
the version constraint or setting it to < 2.0.

If you do use “code”, you can either keep compatibility with both, or
only support 1.x.

To be compatible with both, have two defaces, one for 1.x and one for
0.x - see

https://github.com/theforeman/foreman-xen/tree/master/app/overrides/hosts/show
for an example. As long as your master branch is used with 1.9 or
older, then you’ll need to keep them.

Or you can require deface >= 1.0, and only push that version of the
plugin to the nightly/1.10 plugin users/repositories - as I don’t intend
on trying to put deface 1.x into the 1.9 plugin repos.

Please let me know here if a plugin is known to be OK or has been
updated. Some of the plugins above I know aren’t actively maintained,
so I’ll go through them and check and fix them if required and possible,
or we’ll remove them from the repos.

foreman_dhcp_browser has been updated at
https://github.com/theforeman/foreman_dhcp_browser/pull/16

Ohad

Once the packages that depend on deface are known to be updated or OK,
then we can try and push the new version out.

Thanks for your co-operation.

–
Dominic Cleal
Red Hat Engineering

–
You received this message because you are subscribed to the Google Groups
“foreman-dev” group.
To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

–
You received this message because you are subscribed to the Google Groups
“foreman-dev” group.
To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

#10

PR opened: https://github.com/theforeman/foreman-xen/pull/25

··· On 30/07/15 14:42, Dominic Cleal wrote: >> > 11. foreman_xen > Needs to be relaxed and released, already supports both.

–
Dominic Cleal
Red Hat Engineering

#11

Merged and a gem released as 0.2.1 - thanks for your help Dominic!

Greg

··· On 30 July 2015 at 14:42, Dominic Cleal wrote: >> 12. foreman_column_view > > PR opened: https://github.com/GregSutcliffe/foreman_column_view/pull/16.
#12

> Just a small status update - it looks like we're mostly waiting for
> plugins to be released. No major urgency, just please try to do it by
> early-mid September so there's time before 1.10 to update deface.

Thanks to discovery, salt, chef, xen and column_view maintainers for the
releases.

>> 5. foreman_simplify
>
> Not pinned, but is affected. Will remove this as it's a dead project.

I'm unsure whether to remove this as it still seems to be downloaded
regularly. If somebody has the time to fix it, I can review a PR, else
I'll get to it soon.

Only three others remaining:

··· On 30/07/15 14:42, Dominic Cleal wrote: > On 09/07/15 08:49, Dominic Cleal wrote:
  1. foreman_openscap

Relaxed, pending release.

  1. foreman_dhcp_browser

Relaxed, pending release.

  1. katello

PR open: https://github.com/Katello/katello/pull/5355

–
Dominic Cleal
Red Hat Engineering

#13

> > Just a small status update - it looks like we're mostly waiting for
> > plugins to be released. No major urgency, just please try to do it by
> > early-mid September so there's time before 1.10 to update deface.
>
> Thanks to discovery, salt, chef, xen and column_view maintainers for the
> releases.
>
> >> 5. foreman_simplify
> >
> > Not pinned, but is affected. Will remove this as it's a dead project.
>
> I'm unsure whether to remove this as it still seems to be downloaded
> regularly. If somebody has the time to fix it, I can review a PR, else
> I'll get to it soon.
>
> Only three others remaining:
>
> >> 7. foreman_openscap
> >
> > Relaxed, pending release.
> >
> >> 10. foreman_dhcp_browser
> >
> > Relaxed, pending release.
> >
> >> 13. katello
> >
> > PR open: https://github.com/Katello/katello/pull/5355

We'll have to coordinate merging that PR when foreman moves to deface
1.x, as we're using erb-loud, and can't find a non-erb-loud solution for
at least one of the defaces.

··· On Thu, Aug 13, 2015 at 02:43:03PM +0100, Dominic Cleal wrote: > On 30/07/15 14:42, Dominic Cleal wrote: > > On 09/07/15 08:49, Dominic Cleal wrote:

–
Dominic Cleal
Red Hat Engineering

–
You received this message because you are subscribed to the Google Groups “foreman-dev” group.
To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

–
Best Regards,

Stephen Benjamin
Red Hat Engineering

#14

released foreman_openscap v0.4.2 with the required changes

#15

Hello

··· > > On 09/07/15 08:49, Dominic Cleal wrote: > >> 5. foreman_simplify > > > > Not pinned, but is affected. Will remove this as it's a dead project. > > I'm unsure whether to remove this as it still seems to be downloaded > regularly. If somebody has the time to fix it, I can review a PR, else > I'll get to it soon.

I just checked with jistr (author of the plugin), it’s used by staypuft which
won’t be updated to work with newer Foreman (it runs with 1.7). It might be
used by openstack foreman installer which I think also uses older version but
I’ll double check later today. So I think we don’t have to update the plugin,
maybe just adding foreman < 1.9 to spec would be fine.

–
Marek

#16

Assuming you mean you're waiting for the RPM (as Foreman doesn't depend
on it), here it is: https://github.com/theforeman/foreman-packaging/pull/777

Everything else is complete, thanks all.

··· On 13/08/15 15:29, Stephen Benjamin wrote: > On Thu, Aug 13, 2015 at 02:43:03PM +0100, Dominic Cleal wrote: >> On 30/07/15 14:42, Dominic Cleal wrote: >>>> 13. katello >>> >>> PR open: https://github.com/Katello/katello/pull/5355 > > We'll have to coordinate merging that PR when foreman moves to deface > 1.x, as we're using erb-loud, and can't find a non-erb-loud solution for > at least one of the defaces.

–
Dominic Cleal
Red Hat Engineering

#17

In that case we'd just drop it from the nightly repository by removing
it from comps and the spec file in rpm/develop, then it doesn't need
updating.

··· On 17/08/15 09:35, Marek Hulan wrote: > Hello > >>> On 09/07/15 08:49, Dominic Cleal wrote: >>>> 5. foreman_simplify >>> >>> Not pinned, but is affected. Will remove this as it's a dead project. >> >> I'm unsure whether to remove this as it still seems to be downloaded >> regularly. If somebody has the time to fix it, I can review a PR, else >> I'll get to it soon. > > I just checked with jistr (author of the plugin), it's used by staypuft which > won't be updated to work with newer Foreman (it runs with 1.7). It might be > used by openstack foreman installer which I think also uses older version but > I'll double check later today. So I think we don't have to update the plugin, > maybe just adding foreman < 1.9 to spec would be fine.

–
Dominic Cleal
Red Hat Engineering

#18

OFI uses the same Foreman version and there's no plan to update it so I think
we can drop it.

··· On Monday 17 of August 2015 14:30:03 Dominic Cleal wrote: > On 17/08/15 09:35, Marek Hulan wrote: > > Hello > > > >>> On 09/07/15 08:49, Dominic Cleal wrote: > >>>> 5. foreman_simplify > >>> > >>> Not pinned, but is affected. Will remove this as it's a dead project. > >> > >> I'm unsure whether to remove this as it still seems to be downloaded > >> regularly. If somebody has the time to fix it, I can review a PR, else > >> I'll get to it soon. > > > > I just checked with jistr (author of the plugin), it's used by staypuft > > which won't be updated to work with newer Foreman (it runs with 1.7). It > > might be used by openstack foreman installer which I think also uses > > older version but I'll double check later today. So I think we don't have > > to update the plugin, maybe just adding foreman < 1.9 to spec would be > > fine. > > In that case we'd just drop it from the nightly repository by removing > it from comps and the spec file in rpm/develop, then it doesn't need > updating.

–
Marek