Plugins with welcome pages need updating


#1

As the PR for #23191 got merged, any plugins using welcome pages need to add route definitions for these in their plugin routes. If these are not already tested, now would also be a good time to add tests for that. :wink:


#2

Hey, thanks. Is there an example plugin PR so I can blindly repeat the same?


#3

For e.g. discovery it should be something like this:

diff --git a/config/routes.rb b/config/routes.rb
index 772340a..f5119ef 100644
--- a/config/routes.rb
+++ b/config/routes.rb
@@ -6,6 +6,8 @@ Rails.application.routes.draw do
   post 'os_selected_discovered_hosts'           => 'hosts#os_selected'
   post 'medium_selected_discovered_hosts'       => 'hosts#medium_selected'
 
+  get 'discovered_hosts/help', :action => :welcome, :controller => 'discovered_hosts'
+
   constraints(:id => /[^\/]+/) do
     resources :discovered_hosts, :except => [:new, :create] do
       member do

However, in my setup the discovered_hostsโ€™ help page seems to be broken (unrelated to the route change), so Iโ€™m unsure if this is 100% correct.