It looks like Github has redone the PR UI and now you can assign labels to PRs without having to enable Github Issues. Do we want to start using labels in Katello for our PRs? I think it would be nice to see what needs review, needs testing, etc. Maybe we could go off the foreman labels and just start out with:
'Not yet reviewed'
'Needs testing'
'Ready to merge'
'Waiting on contributor'
Thoughts?
David
If we address - https://github.com/theforeman/prprocessor/issues/2 then we
can have it the same across projects. I'll look into adding that
functionality over the next few days unless Dominic tells me he has a half
written branch somewheres already.
Eric
It looks like Github has redone the PR UI and now you can assign labels to
PRs without having to enable Github Issues. Do we want to start using
labels in Katello for our PRs? I think it would be nice to see what needs
review, needs testing, etc. Maybe we could go off the foreman labels and
just start out with:‘Not yet reviewed’
‘Needs testing’
‘Ready to merge’
‘Waiting on contributor’Thoughts?
David
–
You received this message because you are subscribed to the Google Groups
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Starting today (except for any minor hiccups that we may encounter) any
newly opened PRs should have "Not yet reviewed" and "Needs testing" applied
to them on any of our repositories with the prprocessor hooked up for which
the aforementioned labels exist on the repository as well.
If we address - https://github.com/theforeman/prprocessor/issues/2 then
we can have it the same across projects. I’ll look into adding that
functionality over the next few days unless Dominic tells me he has a half
written branch somewheres already.Eric
On Mon, Jul 28, 2014 at 1:25 PM, David Davis daviddavis@redhat.com > wrote:
It looks like Github has redone the PR UI and now you can assign labels
to PRs without having to enable Github Issues. Do we want to start using
labels in Katello for our PRs? I think it would be nice to see what needs
review, needs testing, etc. Maybe we could go off the foreman labels and
just start out with:‘Not yet reviewed’
‘Needs testing’
‘Ready to merge’
‘Waiting on contributor’Thoughts?
David
–
You received this message because you are subscribed to the Google Groups
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Anyone (tom, adam, dustin) mind if we do the same to hammer-cli-katello?
David
> Anyone (tom, adam, dustin) mind if we do the same to hammer-cli-katello?
>
> David
i'm not opposed
----- Original Message -----
From: “Eric D Helms” ericdhelms@gmail.com
To: “foreman-dev” foreman-dev@googlegroups.com
Sent: Tuesday, July 29, 2014 10:36:16 AM
Subject: Re: [foreman-dev] PR labelsStarting today (except for any minor hiccups that we may encounter) any
newly opened PRs should have “Not yet reviewed” and “Needs testing” applied
to them on any of our repositories with the prprocessor hooked up for which
the aforementioned labels exist on the repository as well.On Mon, Jul 28, 2014 at 1:30 PM, Eric D Helms ericdhelms@gmail.com wrote:
If we address - https://github.com/theforeman/prprocessor/issues/2 then
we can have it the same across projects. I’ll look into adding that
functionality over the next few days unless Dominic tells me he has a
half
written branch somewheres already.Eric
On Mon, Jul 28, 2014 at 1:25 PM, David Davis daviddavis@redhat.com > > > wrote:
It looks like Github has redone the PR UI and now you can assign labels
to PRs without having to enable Github Issues. Do we want to start using
labels in Katello for our PRs? I think it would be nice to see what
needs
review, needs testing, etc. Maybe we could go off the foreman labels and
just start out with:‘Not yet reviewed’
‘Needs testing’
‘Ready to merge’
‘Waiting on contributor’Thoughts?
David
–
You received this message because you are subscribed to the Google
Groups
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send
an
email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.–
You received this message because you are subscribed to the Google Groups
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.–
You received this message because you are subscribed to the Google Groups
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
–
sounds good, I like the new labels - dustin
Thank all! The labels have already been useful to me as I have watched my
PRs be assigned and de-assigned the Needs Review labels on the way towards
a merge. It's been very helpful to have this status information at hand.
sounds good, I like the new labels - dustin
On Wednesday, July 30, 2014 10:27:45 AM UTC-7, Adam Price wrote:
----- Original Message -----
Anyone (tom, adam, dustin) mind if we do the same to
hammer-cli-katello?David
i’m not opposed
----- Original Message -----
From: “Eric D Helms” ericd...@gmail.com
To: “foreman-dev” forem...@googlegroups.com
Sent: Tuesday, July 29, 2014 10:36:16 AM
Subject: Re: [foreman-dev] PR labelsStarting today (except for any minor hiccups that we may encounter)
anynewly opened PRs should have “Not yet reviewed” and "Needs testing"
appliedto them on any of our repositories with the prprocessor hooked up for
whichthe aforementioned labels exist on the repository as well.
On Mon, Jul 28, 2014 at 1:30 PM, Eric D Helms ericd...@gmail.com >> wrote:
If we address - https://github.com/theforeman/prprocessor/issues/2
thenwe can have it the same across projects. I’ll look into adding that
functionality over the next few days unless Dominic tells me he has
ahalf
written branch somewheres already.Eric
On Mon, Jul 28, 2014 at 1:25 PM, David Davis david...@redhat.com >> > > > wrote:
It looks like Github has redone the PR UI and now you can assign
labelsto PRs without having to enable Github Issues. Do we want to start
usinglabels in Katello for our PRs? I think it would be nice to see
whatneeds
review, needs testing, etc. Maybe we could go off the foreman
labels andjust start out with:
‘Not yet reviewed’
‘Needs testing’
‘Ready to merge’
‘Waiting on contributor’Thoughts?
David
–
You received this message because you are subscribed to the Google
Groups
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it,
sendan
email to foreman-dev...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.–
You received this message because you are subscribed to the Google
Groups“foreman-dev” group.
To unsubscribe from this group and stop receiving emails from it,
send anemail to foreman-dev...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.–
You received this message because you are subscribed to the Google
Groups
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send
an
email to foreman-dev...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.–
- adam price
–
You received this message because you are subscribed to the Google Groups
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.