I just saw that github has two new features today where PRs can’t be merged
without being green and also branches designated as protected can’t be
force pushed to.
https://github.com/blog/2051-protected-branches-and-required-status-checks
David
I've protected the develop/master branches of Foreman's core projects.
Thanks,
···
On 03/09/15 22:17, David Davis wrote: > I just saw that github has two new features today where PRs can’t be > merged without being green and also branches designated as protected > can’t be force pushed to. > > https://github.com/blog/2051-protected-branches-and-required-status-checks–
Dominic Cleal
dominic@cleal.org
Do note the status check enforcement won't work for any repo that needs
automated tooling to push - like tito and blacksmith. It's not just
PR's, but any commit to the protected branch needs the passed status
check which is unfortunate.
This is what happens:
https://gist.github.com/stbenjam/877b91174e1dc634c219
We'll have to turn it off on puppet-* and katello-packaging.
···
On Thu, Sep 03, 2015 at 05:17:23PM -0400, David Davis wrote: > I just saw that github has two new features today where PRs can’t be merged > without being green and also branches designated as protected can’t be > force pushed to. > > https://github.com/blog/2051-protected-branches-and-required-status-checks > > David >–
Best Regards,
Stephen Benjamin
Red Hat Engineering
Github has an option that allows administrators to bypass the status check
requirement. One option might be to add people who need to use
tito/blacksmith to the administrators group. Although I am not 100% sure if
they can bypass this but it may be worth checking out.
We also turned off the status check requirement for the main katello repo
as it required each PR to be updated with the base branch which is very
hard to do if you have more than a handful of people opening PRs against a
repository.
Since the status check feature is new, I am hoping Github adds more
customization to it in the future.
David
···
On Tue, Sep 8, 2015 at 5:46 PM, Stephen Benjamin wrote:On Thu, Sep 03, 2015 at 05:17:23PM -0400, David Davis wrote:
I just saw that github has two new features today where PRs can’t be
merged
without being green and also branches designated as protected can’t be
force pushed to.https://github.com/blog/2051-protected-branches-and-required-status-checks
David
Do note the status check enforcement won’t work for any repo that needs
automated tooling to push - like tito and blacksmith. It’s not just
PR’s, but any commit to the protected branch needs the passed status
check which is unfortunate.This is what happens:
https://gist.github.com/stbenjam/877b91174e1dc634c219We’ll have to turn it off on puppet-* and katello-packaging.
–
Best Regards,Stephen Benjamin
Red Hat Engineering–
You received this message because you are subscribed to the Google Groups
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.