Provisioning setup Nil error after upgrade to 1.19

Terrence_Martin · October 20, 2020, 8:03pm

Problem:
When under the provisioning setup page I select the current and only item there for provisioning host, the local host for my foreman. I am getting an error.

Should I go back through the provisioning setup? I do see pages after I select set up provisioning button. I just do not want to break anything I have that is working.

Oops, we’re sorry but something went wrong undefined method `’ for nil:NilClass

Expected outcome:
I get a page that is not an error

Foreman and Proxy versions:
1.19

Foreman and Proxy plugin versions:

Distribution and version:
Centos 7

Other relevant data:
NoMethodError
**undefined method []' for nil:NilClass** /opt/theforeman/tfm/root/usr/share/gems/gems/foreman_setup-6.0.0/app/controllers/foreman_setup/provisioners_controller.rb:45:in step2’
/opt/theforeman/tfm-ror51/root/usr/share/gems/gems/actionpack-5.1.6/lib/action_controller/metal/basic_implicit_render.rb:4:in send_action' /opt/theforeman/tfm-ror51/root/usr/share/gems/gems/actionpack-5.1.6/lib/abstract_controller/base.rb:186:in process_action’
/opt/theforeman/tfm-ror51/root/usr/share/gems/gems/actionpack-5.1.6/lib/action_controller/metal/rendering.rb:30:in process_action' /opt/theforeman/tfm-ror51/root/usr/share/gems/gems/actionpack-5.1.6/lib/abstract_controller/callbacks.rb:20:in block in process_action’
/opt/theforeman/tfm-ror51/root/usr/share/gems/gems/activesupport-5.1.6/lib/active_support/callbacks.rb:108:in block in run_callbacks' /usr/share/foreman/app/controllers/concerns/application_shared.rb:15:in set_timezone’
/opt/theforeman/tfm-ror51/root/usr/share/gems/gems/activesupport-5.1.6/lib/active_support/callbacks.rb:117:in block in run_callbacks' /usr/share/foreman/app/models/concerns/foreman/thread_session.rb:32:in clear_thread’
/opt/theforeman/tfm-ror51/root/usr/share/gems/gems/activesupport-5.1.6/lib/active_support/callbacks.rb:117:in block in run_callbacks' /usr/share/foreman/app/controllers/concerns/foreman/controller/topbar_sweeper.rb:12:in set_topbar_sweeper_controller’
/opt/theforeman/tfm-ror51/root/usr/share/gems/gems/activesupport-5.1.6/lib/active_support/callbacks.rb:117:in block in run_callbacks' /opt/theforeman/tfm/root/usr/share/gems/gems/audited-4.7.1/lib/audited/sweeper.rb:14:in around’
/opt/theforeman/tfm-ror51/root/usr/share/gems/gems/activesupport-5.1.6/lib/active_support/callbacks.rb:117:in block in run_callbacks' /opt/theforeman/tfm/root/usr/share/gems/gems/audited-4.7.1/lib/audited/sweeper.rb:14:in around’
/opt/theforeman/tfm-ror51/root/usr/share/gems/gems/activesupport-5.1.6/lib/active_support/callbacks.rb:117:in block in run_callbacks' /opt/theforeman/tfm-ror51/root/usr/share/gems/gems/activesupport-5.1.6/lib/active_support/callbacks.rb:135:in run_callbacks’
/opt/theforeman/tfm-ror51/root/usr/share/gems/gems/actionpack-5.1.6/lib/abstract_controller/callbacks.rb:19:in process_action' /opt/theforeman/tfm-ror51/root/usr/share/gems/gems/actionpack-5.1.6/lib/action_controller/metal/rescue.rb:20:in process_action’
/opt/theforeman/tfm-ror51/root/usr/share/gems/gems/actionpack-5.1.6/lib/action_controller/metal/instrumentation.rb:32:in block in process_action' /opt/theforeman/tfm-ror51/root/usr/share/gems/gems/activesupport-5.1.6/lib/active_support/notifications.rb:166:in block in instrument’
/opt/theforeman/tfm-ror51/root/usr/share/gems/gems/activesupport-5.1.6/lib/active_support/notifications/instrumenter.rb:21:in instrument' /opt/theforeman/tfm-ror51/root/usr/share/gems/gems/activesupport-5.1.6/lib/active_support/notifications.rb:166:in instrument’
/opt/theforeman/tfm-ror51/root/usr/share/gems/gems/actionpack-5.1.6/lib/action_controller/metal/instrumentation.rb:30:in process_action' /opt/theforeman/tfm-ror51/root/usr/share/gems/gems/actionpack-5.1.6/lib/action_controller/metal/params_wrapper.rb:252:in process_action’
/opt/theforeman/tfm-ror51/root/usr/share/gems/gems/activerecord-5.1.6/lib/active_record/railties/controller_runtime.rb:22:in process_action' /opt/theforeman/tfm-ror51/root/usr/share/gems/gems/actionpack-5.1.6/lib/abstract_controller/base.rb:124:in process’
/opt/theforeman/tfm-ror51/root/usr/share/gems/gems/actionview-5.1.6/lib/action_view/rendering.rb:30:in process' /opt/theforeman/tfm-ror51/root/usr/share/gems/gems/actionpack-5.1.6/lib/action_controller/metal.rb:189:in dispatch’
/opt/theforeman/tfm-ror51/root/usr/share/gems/gems/actionpack-5.1.6/lib/action_controller/metal.rb:253:in dispatch' /opt/theforeman/tfm-ror51/root/usr/share/gems/gems/actionpack-5.1.6/lib/action_dispatch/routing/route_set.rb:49:in dispatch’
/opt/theforeman/tfm-ror51/root/usr/share/gems/gems/actionpack-5.1.6/lib/action_dispatch/routing/route_set.rb:31:in serve' /opt/theforeman/tfm-ror51/root/usr/share/gems/gems/actionpack-5.1.6/lib/action_dispatch/journey/router.rb:50:in block in serve’
/opt/theforeman/tfm-ror51/root/usr/share/gems/gems/actionpack-5.1.6/lib/action_dispatch/journey/router.rb:33:in each' /opt/theforeman/tfm-ror51/root/usr/share/gems/gems/actionpack-5.1.6/lib/action_dispatch/journey/router.rb:33:in serve’
/opt/theforeman/tfm-ror51/root/usr/share/gems/gems/actionpack-5.1.6/lib/action_dispatch/routing/route_set.rb:844:in call' /opt/theforeman/tfm/root/usr/share/gems/gems/apipie-rails-0.5.9/lib/apipie/static_dispatcher.rb:65:in call’
/opt/theforeman/tfm/root/usr/share/gems/gems/apipie-rails-0.5.9/lib/apipie/extractor/recorder.rb:136:in call' /usr/share/foreman/lib/middleware/telemetry.rb:9:in call’
/opt/theforeman/tfm/root/usr/share/gems/gems/apipie-rails-0.5.9/lib/apipie/middleware/checksum_in_headers.rb:27:in call' /usr/share/foreman/lib/middleware/catch_json_parse_errors.rb:8:in call’
/opt/theforeman/tfm-ror51/root/usr/share/gems/gems/rack-2.0.3/lib/rack/etag.rb:25:in call' /opt/theforeman/tfm-ror51/root/usr/share/gems/gems/rack-2.0.3/lib/rack/conditional_get.rb:25:in call’
/opt/theforeman/tfm-ror51/root/usr/share/gems/gems/rack-2.0.3/lib/rack/head.rb:12:in call' /usr/share/foreman/lib/middleware/logging_context.rb:23:in call’
/opt/theforeman/tfm-ror51/root/usr/share/gems/gems/rack-2.0.3/lib/rack/session/abstract/id.rb:232:in context' /opt/theforeman/tfm-ror51/root/usr/share/gems/gems/rack-2.0.3/lib/rack/session/abstract/id.rb:226:in call’
/opt/theforeman/tfm-ror51/root/usr/share/gems/gems/actionpack-5.1.6/lib/action_dispatch/middleware/cookies.rb:613:in call' /opt/theforeman/tfm-ror51/root/usr/share/gems/gems/actionpack-5.1.6/lib/action_dispatch/middleware/callbacks.rb:26:in block in call’
/opt/theforeman/tfm-ror51/root/usr/share/gems/gems/activesupport-5.1.6/lib/active_support/callbacks.rb:97:in run_callbacks' /opt/theforeman/tfm-ror51/root/usr/share/gems/gems/actionpack-5.1.6/lib/action_dispatch/middleware/callbacks.rb:24:in call’
/opt/theforeman/tfm-ror51/root/usr/share/gems/gems/actionpack-5.1.6/lib/action_dispatch/middleware/debug_exceptions.rb:59:in call' /opt/theforeman/tfm-ror51/root/usr/share/gems/gems/actionpack-5.1.6/lib/action_dispatch/middleware/show_exceptions.rb:31:in call’
/opt/theforeman/tfm-ror51/root/usr/share/gems/gems/railties-5.1.6/lib/rails/rack/logger.rb:36:in call_app' /opt/theforeman/tfm-ror51/root/usr/share/gems/gems/railties-5.1.6/lib/rails/rack/logger.rb:26:in call’
/opt/theforeman/tfm-ror51/root/usr/share/gems/gems/sprockets-rails-3.2.1/lib/sprockets/rails/quiet_assets.rb:13:in call' /opt/theforeman/tfm-ror51/root/usr/share/gems/gems/actionpack-5.1.6/lib/action_dispatch/middleware/remote_ip.rb:79:in call’
/opt/theforeman/tfm-ror51/root/usr/share/gems/gems/actionpack-5.1.6/lib/action_dispatch/middleware/request_id.rb:25:in call' /opt/theforeman/tfm-ror51/root/usr/share/gems/gems/rack-2.0.3/lib/rack/method_override.rb:22:in call’
/opt/theforeman/tfm-ror51/root/usr/share/gems/gems/rack-2.0.3/lib/rack/runtime.rb:22:in call' /opt/theforeman/tfm-ror51/root/usr/share/gems/gems/activesupport-5.1.6/lib/active_support/cache/strategy/local_cache_middleware.rb:27:in call’
/opt/theforeman/tfm-ror51/root/usr/share/gems/gems/actionpack-5.1.6/lib/action_dispatch/middleware/executor.rb:12:in call' /opt/theforeman/tfm-ror51/root/usr/share/gems/gems/actionpack-5.1.6/lib/action_dispatch/middleware/static.rb:125:in call’
/opt/theforeman/tfm-ror51/root/usr/share/gems/gems/rack-2.0.3/lib/rack/sendfile.rb:111:in call' /opt/theforeman/tfm/root/usr/share/gems/gems/secure_headers-5.0.5/lib/secure_headers/middleware.rb:13:in call’
/opt/theforeman/tfm-ror51/root/usr/share/gems/gems/railties-5.1.6/lib/rails/engine.rb:522:in call' /opt/theforeman/tfm-ror51/root/usr/share/gems/gems/railties-5.1.6/lib/rails/railtie.rb:185:in public_send’
/opt/theforeman/tfm-ror51/root/usr/share/gems/gems/railties-5.1.6/lib/rails/railtie.rb:185:in method_missing' /opt/theforeman/tfm-ror51/root/usr/share/gems/gems/rack-2.0.3/lib/rack/urlmap.rb:68:in block in call’
/opt/theforeman/tfm-ror51/root/usr/share/gems/gems/rack-2.0.3/lib/rack/urlmap.rb:53:in each' /opt/theforeman/tfm-ror51/root/usr/share/gems/gems/rack-2.0.3/lib/rack/urlmap.rb:53:in call’
/usr/share/gems/gems/passenger-4.0.18/lib/phusion_passenger/rack/thread_handler_extension.rb:77:in process_request' /usr/share/gems/gems/passenger-4.0.18/lib/phusion_passenger/request_handler/thread_handler.rb:140:in accept_and_process_next_request’
/usr/share/gems/gems/passenger-4.0.18/lib/phusion_passenger/request_handler/thread_handler.rb:108:in main_loop' /usr/share/gems/gems/passenger-4.0.18/lib/phusion_passenger/request_handler.rb:441:in block (3 levels) in start_threads’
/opt/theforeman/tfm/root/usr/share/gems/gems/logging-2.2.2/lib/logging/diagnostic_context.rb:474:in `block in create_with_logging_context’

Terrence_Martin · October 20, 2020, 10:35pm

Replying to myself, fixed by moving to 1.20. It took me a bit to figure out that yes the locked templates are updated on upgrade.

lzap · October 21, 2020, 10:29am

Yeah, Foreman Setup plugin was broken in 1.19. I am not huge fan of this plugin as I prefer to have a good documentation rather than such plugin and we don’t do good job in maintaining this plugin.

I wonder if we should deprecate the plugin @ekohl because I am not interested in maintaining it to be honest and it’s been broken multiple times.

ekohl · October 21, 2020, 11:42am

Perhaps that’s better than giving the impression that it works.

lzap · October 21, 2020, 11:57am

Agreed, what do I need to do in order to remove the plugin from the default installation profiles? I think this is getting installed in katello/satellite scenarios by default, not sure about foreman core. That could be a good first step so users don’t get confused.

ekohl · October 21, 2020, 12:18pm

It’s not on by default:

github.com

theforeman/foreman-installer/blob/46932eb404753cebaf0563c29d40ec7457fddc89/config/foreman-answers.yaml#L51


      
          foreman::plugin::leapp: false
          foreman::plugin::memcache: false
          foreman::plugin::monitoring: false
          foreman::plugin::omaha: false
          foreman::plugin::openscap: false
          foreman::plugin::ovirt_provision: false
          foreman::plugin::puppetdb: false
          foreman::plugin::remote_execution: false
          foreman::plugin::remote_execution::cockpit: false
          foreman::plugin::salt: false
          foreman::plugin::setup: false
          foreman::plugin::snapshot_management: false
          foreman::plugin::statistics: false
          foreman::plugin::tasks: false
          foreman::plugin::templates: false
          foreman_proxy: {}
          foreman_proxy::plugin::ansible: false
          foreman_proxy::plugin::chef: false
          foreman_proxy::plugin::dhcp::infoblox: false
          foreman_proxy::plugin::dhcp::remote_isc: false
          foreman_proxy::plugin::discovery: false

github.com

theforeman/foreman-installer/blob/46932eb404753cebaf0563c29d40ec7457fddc89/config/katello-answers.yaml#L65


      
          foreman::plugin::kubevirt: false
          foreman::plugin::leapp: false
          foreman::plugin::memcache: false
          foreman::plugin::monitoring: false
          foreman::plugin::openscap: false
          foreman::plugin::puppetdb: false
          foreman::plugin::remote_execution: false
          foreman::plugin::remote_execution::cockpit: false
          foreman::plugin::rh_cloud: false
          foreman::plugin::salt: false
          foreman::plugin::setup: false
          foreman::plugin::snapshot_management: false
          foreman::plugin::statistics: false
          foreman::plugin::tasks: true
          foreman::plugin::templates: false
          foreman::plugin::virt_who_configure: false
          foreman_proxy:
            foreman_ssl_ca: /etc/foreman-proxy/foreman_ssl_ca.pem
            foreman_ssl_cert: /etc/foreman-proxy/foreman_ssl_cert.pem
            foreman_ssl_key: /etc/foreman-proxy/foreman_ssl_key.pem
            manage_puppet_group: false

A quick git blame tells me we made that change in 1.17: