PrProcessor now closes inactive PRs

lzap · April 15, 2016, 11:58am

Hello,

we have merged a change to our PrProcessor [1] which adds one step in
our PR worflow as described at [2]:

When a PR is not updated for six months with Waiting on contributor
label, it:

Adds a comment
Sets Inactive label
Closes the PR

Every week, maximum of five inactive pull requests are closed.

[1] https://github.com/theforeman/prprocessor/pull/38
[2] PrProcessor - Foreman

···

-- Later, Lukas #lzap Zapletal

thomasmckay · April 15, 2016, 12:29pm

Will the redmine issue be returned to New?

···

----- Original Message ----- > Hello, > > we have merged a change to our PrProcessor [1] which adds one step in > our PR worflow as described at [2]: > > When a PR is not updated for six months with Waiting on contributor > label, it: > > * Adds a comment > * Sets Inactive label > * Closes the PR > > Every week, maximum of five inactive pull requests are closed. > > [1] https://github.com/theforeman/prprocessor/pull/38 > [2] http://projects.theforeman.org/projects/foreman/wiki/PrProcessor > > -- > Later, > Lukas #lzap Zapletal > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscribe@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. >

lzap · April 20, 2016, 3:11pm

> Will the redmine issue be returned to New?

It looks like it stays in Ready for testing.

I can't find the code which closes our Issues, I can only see:

github.com

theforeman/prprocessor/blob/master/app.rb#L46


halt if event == 'pull_request' && ['closed', 'labeled', 'unlabeled'].include?(action)
# also trigger for new PullRequestReviewCommentEvent containing [test]
halt if event_act == 'pull_request_review_comment/created' && (!payload['comment'] || !payload['comment']['body'].include?('[test]'))


if ENV['REDMINE_API_KEY'] && !repo.redmine_project.nil?
  users = YAML.load_file('config/users.yaml')


  pull_request.issue_numbers.each do |issue_number|
    issue = Issue.new(issue_number)
    project = Project.new(issue.project)


    user_id = users[pull_request.author] if users.key?(pull_request.author)


    if !([repo.redmine_project] + repo.permitted_refs).include?(project.identifier)
      if ENV['GITHUB_OAUTH_TOKEN']
        correct_project = Project.new(repo.redmine_project)
        message = <<EOM
@#{pull_request.author}, the Redmine ticket used is for a different project than the one associated with this GitHub repository. Please either:


* check [##{issue_number}: #{issue.subject}](http://projects.theforeman.org/issues/#{issue_number}) is the correct one
* move [ticket ##{issue_number}](http://projects.theforeman.org/issues/#{issue_number}) from #{project.name} to the #{correct_project.name} project

Someone help me with this?

···

-- Later, Lukas #lzap Zapletal

Dominic_Cleal2 · April 20, 2016, 3:25pm

Redmine closes issues itself when a commit is merged to the configured
repos, it isn't prprocessor.

···

On 20/04/16 16:11, Lukas Zapletal wrote: >> Will the redmine issue be returned to New? > > It looks like it stays in Ready for testing. > > I can't find the code which closes our Issues, I can only see:

–
Dominic Cleal
dominic@cleal.org