PRs related to search by name in Hammer

Development
1

Hello,
I've finally created pull requests that solve issues around searching
resources by name in Hammer. They are all marked as "do not merge"
because there's still work that needs to be done in fixing and
completing unit tests. But this shouldn't block you in looking into the
principles and testing it live.

The PRs contain:

  • organizations searchable by name in both foreman and katello
  • organizations searchable by numeric id in both foreman and katello
  • all resources can be searched/associated by their name (or other
    searchables such as login etc.)
  • merge of read and write commands (they really were the same)
  • new mechanism of option builders that offer more flexible option
    definition

Please check it out and test. Feedback will be appreciated.

Cheers
Tomas

2

> Hello,
> I've finally created pull requests that solve issues around searching
> resources by name in Hammer. They are all marked as "do not merge"
> because there's still work that needs to be done in fixing and
> completing unit tests. But this shouldn't block you in looking into the
> principles and testing it live.
>
> https://github.com/theforeman/hammer-cli/pull/105
> https://github.com/theforeman/hammer-cli-foreman/pull/112
> https://github.com/Katello/hammer-cli-katello/pull/144

i had to make this small change to hammer-cli-foreman-tasks before cli-katello would load happily.

https://github.com/theforeman/hammer-cli-foreman-tasks/pull/8

··· ----- Original Message -----

The PRs contain:

  • organizations searchable by name in both foreman and katello
  • organizations searchable by numeric id in both foreman and katello
  • all resources can be searched/associated by their name (or other
    searchables such as login etc.)
  • merge of read and write commands (they really were the same)
  • new mechanism of option builders that offer more flexible option
    definition

Please check it out and test. Feedback will be appreciated.

Cheers
Tomas

–
You received this message because you are subscribed to the Google Groups
“foreman-dev” group.
To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

–

  • adam price
3

The pull requests got merged into the master today.
Thanks everybody who participated in the testing!

Cheers
Tomas

··· On 04/16/2014 10:11 AM, Tomas Strachota wrote: > Hello, > I've finally created pull requests that solve issues around searching > resources by name in Hammer. They are all marked as "do not merge" > because there's still work that needs to be done in fixing and > completing unit tests. But this shouldn't block you in looking into the > principles and testing it live. > > https://github.com/theforeman/hammer-cli/pull/105 > https://github.com/theforeman/hammer-cli-foreman/pull/112 > https://github.com/Katello/hammer-cli-katello/pull/144 > > The PRs contain: > - organizations searchable by name in both foreman and katello > - organizations searchable by numeric id in both foreman and katello > - all resources can be searched/associated by their name (or other > searchables such as login etc.) > - merge of read and write commands (they really were the same) > - new mechanism of option builders that offer more flexible option > definition > > Please check it out and test. Feedback will be appreciated. > > Cheers > Tomas >
4

>> Hello,
>> I've finally created pull requests that solve issues around searching
>> resources by name in Hammer. They are all marked as "do not merge"
>> because there's still work that needs to be done in fixing and
>> completing unit tests. But this shouldn't block you in looking into the
>> principles and testing it live.
>>
>> https://github.com/theforeman/hammer-cli/pull/105
>> https://github.com/theforeman/hammer-cli-foreman/pull/112
>> https://github.com/Katello/hammer-cli-katello/pull/144
>
> i had to make this small change to hammer-cli-foreman-tasks before cli-katello would load happily.
>
> https://github.com/theforeman/hammer-cli-foreman-tasks/pull/8

Ah, thanks! I did fix it locally but forgot to send the PR there:/

··· On 04/16/2014 09:52 PM, Adam Price wrote: > ----- Original Message -----

The PRs contain:

  • organizations searchable by name in both foreman and katello
  • organizations searchable by numeric id in both foreman and katello
  • all resources can be searched/associated by their name (or other
    searchables such as login etc.)
  • merge of read and write commands (they really were the same)
  • new mechanism of option builders that offer more flexible option
    definition

Please check it out and test. Feedback will be appreciated.

Cheers
Tomas

–
You received this message because you are subscribed to the Google Groups
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.