We've had a stale - yet active - PR on Rails 4 for a long time. Rails 3 EOL is soon, so
the sooner we can merge this, the better. My one cent:
unorthodoxgeek:rails4 is huge. The whole review can take a week. theforeman:develop
changes every day, which means unorthodoxgeek has to catch up on changes all the time.
This is unsustainable, as reviewers cannot keep up, and a single person
takes care of updating the PR. It has been open for nearly half a year.
Move unorthodoxgeek:rails4 to theforeman:rails4, and open a new PR from theforeman:rails4
to theforeman:develop. Let everyone involved (Ori, Walden, Tom) commit there, so that not
one but several people get acquainted with the code changes. This would also require us to
actually document what is going on in each commit, rather than 'fixes thing' commits, so I
hope we can review that properly.
Try to get this branch as small as possible first, introducing all retrocompatible changes
on Foreman, including strong_params. This would get these changes well tested before we
merge rails4 in develop.
I would prefer if this branch was merged exactly after 1.9 is branched out, to allow for
as much testing as possible. Whenever it's merged, I would expect any plugin that has
not been following this branch to break.
Any thoughts on how to proceed? There's a lot of work put into the current PR that I hope
we can materialize in Foreman as soon as possible.