Regarding Gnome OPW

Hi everyone,

I am Vanya Jauhal, a Junior year student at International Institute of
Information Technology Hyderabad. I recently came to know about GNOME OPW,
and Foreman looked like an interesting project to work for.
I spent some time getting used to Foreman. I managed to write patches for
the following issues :

I am pretty new to opensource contribution so it would be great if you can
review the patches and guide me on how I should have had made them better.
As a part of OPW, I was really interested in the Puppet Forge and Foreman
project. For the last two months, I had been helping out a very small start
up with their systems administration tasks, and I hence got to use puppet
quite a bit, and I am comfortable enough in finding my way around in Rails
and web technologies in general, so I believe it would be great if someone
could help me out with how I should go about preparing my application for
the OPW programme. Also can you please let me know if there are any minimum
number of patches to be eligible for participation, and also it would be
great if you can suggest some more beginner issues that I can try solving.

Looking forward to all the help and any advice the mentors can provide.

Regards,

··· -------- Vanya Jauhal Junior Year, Electronics and Communications Engineering, International Institute of Information Technology-Hyderabad India LinkedIn

Hi Vanya,

It's really good to see someone interested in OPW on here! I'm also
considering submitting an application to work with Foreman, and I was
really excited to see your post here. You're way ahead of me in the process
and you've done a ton of work so you're setting a great example.

I'm a systems admin intern in Ankara, Turkey primarily using Puppet to
automate tasks. I was really excited to read about Foreman on OPW's
website. I'm reading through the manual right now and setting up Foreman
and thinking of a way to make my first contribution. Any ideas would be
welcome!

Dilek Genc
@dlkgenc

··· On Thursday, October 9, 2014 4:39:17 AM UTC+3, Vanya Jauhal wrote: > > Hi everyone, > > I am Vanya Jauhal, a Junior year student at International Institute of > Information Technology Hyderabad. I recently came to know about GNOME OPW, > and Foreman looked like an interesting project to work for. > I spent some time getting used to Foreman. I managed to write patches for > the following issues : > > - #7537 : Add a "Test" button to test LDAP connections > > Link to pull request : https://github.com/theforeman/foreman/pull/1829 > This exposes a new route which lets users with correct permissions > test the credentials of any LDAP connection, before saving the results in > LDAP Auth Source forms > - #6536 : LDAP: Trying to create an LDAP instance with the name > 'Internal' returns confusing message > > Link to pull request : https://github.com/theforeman/foreman/pull/1830 > This issue would inherently also repeat with the name "Hidden", as > these were the indexes being used to save AuthSourceInternal and > AuthSourceHidden, and replacing the individual index by name_MD5(name) > released the commonly used keywords to be used by administrators > - #3662 : Define default role for 'first-time log in' ldap users > > Link to pull request : https://github.com/theforeman/foreman/pull/1831 > This patch, lets users add a list of default roles for any > AuthSourceLdap instance, and whenever a new user is created either > automatically by login or manually, these default roles get added to their > roles > - #7587 : Javascript validation of passwords on Edit User screen > > Link to pull request : https://github.com/theforeman/foreman/pull/1832 > This patch gives user a client-side feedback about the quality of > password chosen, along with signalling if both the passwords match. As > Dominic suggested on IRC to avoid using the source of external libraries > directly, or referring to git repositories in the Gemfile, I wrote a > small gem > > exposing the jquery.pwstrength.bootstrap library > , and had it published > on RubyGems , > which lets us reference it directly in our Gemfile. Writing a gem > encapsulating the javascript library, also means, we can extend it to > expose server side validators at a later time for password checking. > > I am pretty new to opensource contribution so it would be great if you can > review the patches and guide me on how I should have had made them better. > As a part of OPW, I was really interested in the Puppet Forge and Foreman > project. For the last two months, I had been helping out a very small start > up with their systems administration tasks, and I hence got to use puppet > quite a bit, and I am comfortable enough in finding my way around in Rails > and web technologies in general, so I believe it would be great if someone > could help me out with how I should go about preparing my application for > the OPW programme. Also can you please let me know if there are any minimum > number of patches to be eligible for participation, and also it would be > great if you can suggest some more beginner issues that I can try solving. > > Looking forward to all the help and any advice the mentors can provide. > > Regards, > > -------- > Vanya Jauhal > Junior Year, > Electronics and Communications Engineering, > International Institute of Information Technology-Hyderabad > India > LinkedIn > > > > >

First of all, an excellent preparation. The fact you know how to submit
PRs that fix real issues and discussed it on IRC is awesome. It shows
you already understand how the project works and communicates.

Just a general remark about commit messages that I personally have
strong opinions on, but don't know if the project feels just as strongly
about. There's a general git commit messages convention that helps
keeping git log readable. I recommend at least reading it.
http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html is
the classic blog post about it. The OpenStack project has
https://wiki.openstack.org/wiki/GitCommitMessages with lots of examples.
You can also see that Github loosely follows the convention and cuts off
your subject after a certain amount of characters.

··· On Wed, Oct 08, 2014 at 06:39:17PM -0700, Vanya Jauhal wrote: > Hi everyone, > > I am Vanya Jauhal, a Junior year student at International Institute of > Information Technology Hyderabad. I recently came to know about GNOME OPW, > and Foreman looked like an interesting project to work for. > I spent some time getting used to Foreman. I managed to write patches for > the following issues : > > - #7537 : Add a "Test" button to test LDAP connections > > Link to pull request : https://github.com/theforeman/foreman/pull/1829 > This exposes a new route which lets users with correct permissions test > the credentials of any LDAP connection, before saving the results in LDAP > Auth Source forms > - #6536 : LDAP: Trying to create an LDAP instance with the name > 'Internal' returns confusing message > > Link to pull request : https://github.com/theforeman/foreman/pull/1830 > This issue would inherently also repeat with the name "Hidden", as these > were the indexes being used to save AuthSourceInternal and > AuthSourceHidden, and replacing the individual index by name_MD5(name) > released the commonly used keywords to be used by administrators > - #3662 : Define default role for 'first-time log in' ldap users > > Link to pull request : https://github.com/theforeman/foreman/pull/1831 > This patch, lets users add a list of default roles for any > AuthSourceLdap instance, and whenever a new user is created either > automatically by login or manually, these default roles get added to their > roles > - #7587 : Javascript validation of passwords on Edit User screen > > Link to pull request : https://github.com/theforeman/foreman/pull/1832 > This patch gives user a client-side feedback about the quality of > password chosen, along with signalling if both the passwords match. As > Dominic suggested on IRC to avoid using the source of external libraries > directly, or referring to git repositories in the Gemfile, I wrote a > small gem > > exposing the jquery.pwstrength.bootstrap library > , and had it published > on RubyGems , > which lets us reference it directly in our Gemfile. Writing a gem > encapsulating the javascript library, also means, we can extend it to > expose server side validators at a later time for password checking. > > I am pretty new to opensource contribution so it would be great if you can > review the patches and guide me on how I should have had made them better. > As a part of OPW, I was really interested in the Puppet Forge and Foreman > project. For the last two months, I had been helping out a very small start > up with their systems administration tasks, and I hence got to use puppet > quite a bit, and I am comfortable enough in finding my way around in Rails > and web technologies in general, so I believe it would be great if someone > could help me out with how I should go about preparing my application for > the OPW programme. Also can you please let me know if there are any minimum > number of patches to be eligible for participation, and also it would be > great if you can suggest some more beginner issues that I can try solving. > > Looking forward to all the help and any advice the mentors can provide.

Hi Ewoud,

Thanks for the encouragement and all the valuable inputs.
I will surely try to keep the conventions in mind from now on.

Regards,
Vanya

··· On Thursday, October 9, 2014 5:37:08 PM UTC+5:30, Ewoud Kohl van Wijngaarden wrote: > > On Wed, Oct 08, 2014 at 06:39:17PM -0700, Vanya Jauhal wrote: > > Hi everyone, > > > > I am Vanya Jauhal, a Junior year student at International Institute of > > Information Technology Hyderabad. I recently came to know about GNOME > OPW, > > and Foreman looked like an interesting project to work for. > > I spent some time getting used to Foreman. I managed to write patches > for > > the following issues : > > > > - #7537 : Add a "Test" button to test LDAP connections > > > > Link to pull request : > https://github.com/theforeman/foreman/pull/1829 > > This exposes a new route which lets users with correct permissions > test > > the credentials of any LDAP connection, before saving the results in > LDAP > > Auth Source forms > > - #6536 : LDAP: Trying to create an LDAP instance with the name > > 'Internal' returns confusing message > > > > Link to pull request : > https://github.com/theforeman/foreman/pull/1830 > > This issue would inherently also repeat with the name "Hidden", as > these > > were the indexes being used to save AuthSourceInternal and > > AuthSourceHidden, and replacing the individual index by > name_MD5(name) > > released the commonly used keywords to be used by administrators > > - #3662 : Define default role for 'first-time log in' ldap users > > > > Link to pull request : > https://github.com/theforeman/foreman/pull/1831 > > This patch, lets users add a list of default roles for any > > AuthSourceLdap instance, and whenever a new user is created either > > automatically by login or manually, these default roles get added to > their > > roles > > - #7587 : Javascript validation of passwords on Edit User screen > > > > Link to pull request : > https://github.com/theforeman/foreman/pull/1832 > > This patch gives user a client-side feedback about the quality of > > password chosen, along with signalling if both the passwords match. > As > > Dominic suggested on IRC to avoid using the source of external > libraries > > directly, or referring to git repositories in the Gemfile, I wrote a > > small gem > > > > exposing the jquery.pwstrength.bootstrap library > > , and had it > published > > on RubyGems , > > which lets us reference it directly in our Gemfile. Writing a gem > > encapsulating the javascript library, also means, we can extend it to > > expose server side validators at a later time for password checking. > > > > I am pretty new to opensource contribution so it would be great if you > can > > review the patches and guide me on how I should have had made them > better. > > As a part of OPW, I was really interested in the Puppet Forge and > Foreman > > project. For the last two months, I had been helping out a very small > start > > up with their systems administration tasks, and I hence got to use > puppet > > quite a bit, and I am comfortable enough in finding my way around in > Rails > > and web technologies in general, so I believe it would be great if > someone > > could help me out with how I should go about preparing my application > for > > the OPW programme. Also can you please let me know if there are any > minimum > > number of patches to be eligible for participation, and also it would be > > great if you can suggest some more beginner issues that I can try > solving. > > > > Looking forward to all the help and any advice the mentors can provide. > > First of all, an excellent preparation. The fact you know how to submit > PRs that fix real issues and discussed it on IRC is awesome. It shows > you already understand how the project works and communicates. > > Just a general remark about commit messages that I personally have > strong opinions on, but don't know if the project feels just as strongly > about. There's a general git commit messages convention that helps > keeping git log readable. I recommend at least reading it. > http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html is > the classic blog post about it. The OpenStack project has > https://wiki.openstack.org/wiki/GitCommitMessages with lots of examples. > You can also see that Github loosely follows the convention and cuts off > your subject after a certain amount of characters. >