Request logging fail in smart-proxy 1.6.2

David_Schmitt · February 11, 2015, 1:36pm

Hi,

This request works:
$ wget --no-check-certificate
–private-key=/var/lib/puppet/ssl/private_keys/puppet.example.com.pem
–certificate=/var/lib/puppet/ssl/certs/puppet.example.com.pem
https://puppet.example.com:8443/bmc/providers

 // foreman-proxy.log:
 10.183.161.129 - - [11/Feb/2015 08:19:53] &quot;GET /providers HTTP/1.1&quot;

200 18 0.0225

This request fails:
$ wget --no-check-certificate
–private-key=/var/lib/puppet/ssl/private_keys/puppet.example.com.pem
–certificate=/var/lib/puppet/ssl/certs/puppet.example.com.pem
https://puppet.example.com:8443/providers

 // foreman-proxy.log:
 10.183.161.129 - - [11/Feb/2015 08:20:01] &quot;GET /providers HTTP/1.1&quot;

404 418 0.0211

Please note the subtle differences in the actually requested URL which
cause one of those requests to fail, but which are not reflected in the
log file: adding the '/bmc' prefix to the URL makes the request work,
but is not reflected in the log file, making debugging really hard.
Also, from the source code, the connection between proxy resources and
URLs is very thin, as this is hidden in the ProxyAPI::Resource
initialization at [1], far away from any hope of finding/noticing it
quickly. I have not invested even more time in exploring the sinatra
stuff on the proxy side, where the routes in [2] also helpfully elide
the '/bmc' prefix.

This is happening on foreman-proxy-1.6.2-1.el6 from the 1.6 repo
running on Scientific Linux release 6.5 (Carbon).

Regards, David

[1]

github.com

theforeman/foreman/blob/develop/lib/proxy_api/resource.rb#L33


  # Required in order to ability to mock the resource
  @resource ||= RestClient::Resource.new(url, connect_params)
end


# Sets the credentials in the connection parameters, creates new resource when called
# Since there is now other way to set the credential
def set_credentials(username, password)
  @connect_params[:user]     = username
  @connect_params[:password] = password
  @resource                  = nil
end


def logger
  Foreman::Logging.logger('proxy')
end


private


# Decodes the JSON response if no HTTP error has been detected
# If an HTTP error is received then the error message is saves into @error
# Returns: Response, if the operation is GET, or true for POST, PUT and DELETE.

[2]

github.com

theforeman/smart-proxy/blob/develop/modules/bmc/bmc_api.rb

require 'bmc/ipmi'

module Proxy::BMC
  class Api < ::Sinatra::Base
    helpers ::Proxy::Helpers
    authorize_with_trusted_hosts
    authorize_with_ssl_client
    # All GET requests will only read ipmi data, no changes
    # All PUT requests will update information on the bmc device

    before do
      content_type :json
    end

    # return list of available options
    get "/" do
      res = ['providers', 'providers/installed', 'host']
      { :available_resources => res}.to_json
    end

This file has been truncated. show original

Dominic_Cleal · February 11, 2015, 1:40pm

Yeah, I noticed this on EL6 recently too, but not on my source
installation or EL7. I suspect it's a bug in sinatra (1.0.2 vs 1.3.5)
or rack?

···

On 11/02/15 13:36, David Schmitt wrote: > This request works: > $ wget --no-check-certificate > --private-key=/var/lib/puppet/ssl/private_keys/puppet.example.com.pem > --certificate=/var/lib/puppet/ssl/certs/puppet.example.com.pem > https://puppet.example.com:8443/bmc/providers > > // foreman-proxy.log: > 10.183.161.129 - - [11/Feb/2015 08:19:53] "GET /providers HTTP/1.1" > 200 18 0.0225 > > This request fails: > $ wget --no-check-certificate > --private-key=/var/lib/puppet/ssl/private_keys/puppet.example.com.pem > --certificate=/var/lib/puppet/ssl/certs/puppet.example.com.pem > https://puppet.example.com:8443/providers > > // foreman-proxy.log: > 10.183.161.129 - - [11/Feb/2015 08:20:01] "GET /providers HTTP/1.1" > 404 418 0.0211 > > > Please note the subtle differences in the actually requested URL which > cause one of those requests to fail, but which are not reflected in the > log file: adding the '/bmc' prefix to the URL makes the request work, > but is not reflected in the log file, making debugging really hard.

–
Dominic Cleal
Red Hat Engineering