Rubocop cops

We're going to try to turn on some Rubocop Cops in Katello next sprint to check our Ruby code. Some of them were formerly enabled but had to be disabled as the detection was improved or we had to disable them temporarily. I've started making a list of the cops–ones I think we should probably turn on and ones we should maybe consider/discuss.

I'm looking for feedback from Katello as well as Foreman as which cops we should be using as I'd like to converge on a single set of cops we use between projects. Please review the list if you have some time.

Also, please make sure you fill out your name in case I need to follow up with you.

http://katello.pad.engineering.redhat.com/rubocop-24-cops

Thanks.

David

David,

This pad does not seem to be externally accessible. Mind reposting on one
that is?

-Justin

··· On Friday, August 22, 2014 12:44:43 PM UTC-4, David Davis wrote: > > We're going to try to turn on some Rubocop Cops in Katello next sprint to > check our Ruby code. Some of them were formerly enabled but had to be > disabled as the detection was improved or we had to disable them > temporarily. I've started making a list of the cops--ones I think we should > probably turn on and ones we should maybe consider/discuss. > > I'm looking for feedback from Katello as well as Foreman as which cops we > should be using as I'd like to converge on a single set of cops we use > between projects. Please review the list if you have some time. > > Also, please make sure you fill out your name in case I need to follow up > with you. > > http://katello.pad.engineering.redhat.com/rubocop-24-cops > > Thanks. > > David >

Yea, here we go:

https://public.pad.fsfe.org/p/kt-rubocop-24

David

··· ----- Original Message ----- > From: "Justin Sherrill" > To: foreman-dev@googlegroups.com > Cc: daviddavis@redhat.com > Sent: Sunday, August 24, 2014 6:23:06 PM > Subject: [foreman-dev] Re: Rubocop cops > > David, > > This pad does not seem to be externally accessible. Mind reposting on one > that is? > > -Justin > > On Friday, August 22, 2014 12:44:43 PM UTC-4, David Davis wrote: > > > > We're going to try to turn on some Rubocop Cops in Katello next sprint to > > check our Ruby code. Some of them were formerly enabled but had to be > > disabled as the detection was improved or we had to disable them > > temporarily. I've started making a list of the cops--ones I think we should > > probably turn on and ones we should maybe consider/discuss. > > > > I'm looking for feedback from Katello as well as Foreman as which cops we > > should be using as I'd like to converge on a single set of cops we use > > between projects. Please review the list if you have some time. > > > > Also, please make sure you fill out your name in case I need to follow up > > with you. > > > > http://katello.pad.engineering.redhat.com/rubocop-24-cops > > > > Thanks. > > > > David > > > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscribe@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. >