Running puppet-foreman overwrote provisioning templates


Yesterday Puppet ran on my foreman server and one of the resources triggered was Exec[foreman-rake-db:seed]. This appears to have downloaded the stock provisioning templates and overwrote my custom templates. We got to great lengths to overload the Local Boot templates to do non-standard things like support NFS root booting.

It looks like setting foreman::db_manage_rake will prevent the rake tasks from running. Are there any negative consequences to setting foreman::db_manage_rake to false? Is running the rake tasks during manual upgrades sufficient?

Expected outcome:

Foreman’s rake task or puppet code would not overwrite imported provisioning templates.

Foreman and Proxy versions:

Foreman and Proxy - 1.15.6
puppet-foreman - 8.1.1 + PR 604, ref 9d91ce8

Foreman and Proxy plugin versions:

foreman_templates 5.0.1

Other relevant data:
[e.g. logs from Foreman and/or the Proxy, modified templates, commands issued, etc]

This was actually intentional change made in 1.15 (Bug #18639: All templates that are shipped with Foreman should be locked by default - Foreman) after previous discussions we had regarding this topic.

To prevent overwrites to the templates, one should clone the original templates, so that he/she can make sure it will not get affected by the future versions.