Smart-proxy fails to start after upgrade from 1.19 to 1.20

Problem:
Smart-proxy fails to start after upgrade 1.19 to 1.20 on my salt-master even though the smart-proxy is working on another server that runs Foreman. That’s why I’d assume that the smart-proxy salt plugin might be the culprit. I am not sure if salt is still supported, because the docs only say for Foreman >= 1.17 you should use gem version 10.1.0 (which I have installed). I haven’t received an answer yet on the smart_proxy_salt repo so I just a gave it a go.

I followed the instructions on the Foreman upgrade guide

deb http://deb.theforeman.org/ stretch 1.20
deb http://deb.theforeman.org/ plugins 1.20

apt-get update
apt-get --only-upgrade install ruby\* foreman\*

Note: The upgrade to 1.19 worked just fine.

Does anyone use Salt plugin as well?

Foreman and Proxy plugin versions:

$ apt list --installed foreman-proxy
foreman-proxy/xenial,xenial,now 1.20.1-1 all [installed]
$ apt list --installed ruby-foreman-salt
Listing… Done
ruby-foreman-salt/plugins,plugins,now 10.1.0-1 all [installed]
$ apt list --installed ruby-smart-proxy-salt
Listing… Done
ruby-smart-proxy-salt/plugins,plugins,now 2.1.9-1 all [installed]

In /var/log/syslog I can see that during startup some file cant be read that throws the error.

Feb  5 14:10:47 server0141 systemd[1]: Starting Foreman Proxy...
Feb  5 14:10:47 server0141 smart-proxy[28861]: /usr/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require': cannot load such file -- logging (LoadError)
Feb  5 14:10:47 server0141 smart-proxy[28861]: #011from /usr/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
Feb  5 14:10:47 server0141 smart-proxy[28861]: #011from /usr/share/foreman-proxy/lib/proxy/log.rb:1:in `<top (required)>'
Feb  5 14:10:47 server0141 smart-proxy[28861]: #011from /usr/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
Feb  5 14:10:47 server0141 smart-proxy[28861]: #011from /usr/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
Feb  5 14:10:47 server0141 smart-proxy[28861]: #011from /usr/share/foreman-proxy/lib/launcher.rb:1:in `<top (required)>'
Feb  5 14:10:47 server0141 smart-proxy[28861]: #011from /usr/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
Feb  5 14:10:47 server0141 smart-proxy[28861]: #011from /usr/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
Feb  5 14:10:47 server0141 smart-proxy[28861]: #011from /usr/share/foreman-proxy/lib/smart_proxy_main.rb:4:in `<top (required)>'
Feb  5 14:10:47 server0141 smart-proxy[28861]: #011from /usr/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
Feb  5 14:10:47 server0141 smart-proxy[28861]: #011from /usr/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
Feb  5 14:10:47 server0141 smart-proxy[28861]: #011from /usr/share/foreman-proxy/bin/smart-proxy:5:in `<main>'
Feb  5 14:10:47 server0141 systemd[1]: foreman-proxy.service: Main process exited, code=exited, status=1/FAILURE
Feb  5 14:10:47 server0141 systemd[1]: Failed to start Foreman Proxy.
Feb  5 14:10:47 server0141 systemd[1]: foreman-proxy.service: Unit entered failed state.
Feb  5 14:10:47 server0141 systemd[1]: foreman-proxy.service: Failed with result 'exit-code'.

@Gwmngilfen I saw that you updated the compatibility table in July. Would you happen to know if foreman_salt is still supported in V1.20?

I haven’t tried it, I’m afraid. The logs you show suggest it’s the logging feature that’s the problem, have you tried disabling it?

Interesting, on the Foreman instance that /etc/foreman-proxy/settings.d/log.yml is set to

´´´
:enabled: https

#To configure log buffer capacity, go to settings.yml
´´´

and on the salt-master (foreman-proxy):
´´´´
#Can be true, false, or http/https to enable just one of the protocols
:enabled: false

#Log buffer configuration is in core file (settings.yml)
´´´´

I rolled back the salt-master to V1.19 though. I’ll give it another go with different log options.