Test_katello_core broken on latest foreman-tasks

ehelms · January 29, 2015, 9:13pm

All,

I am investigating a breakage to test_katello_core by the newest
foreman-tasks. Ivan pushed a fix that was blocking our release pipeline
yesterday that included authorization updates to foreman-tasks.

I suspect those updates include a change that assumes an existing Foreman
migrated database by the way the plugin registration works. Since we deploy
Foreman, Katello and plugins and migrate the entire database at once this
leads to test and deployment breakages. I am still investigating and
looking toward a fix but will be AFK for a few. If anyone is curious, or
has time to look into before me, I believe that the lines below need to be
moved into proper seeds:

github.com

theforeman/foreman-tasks/blob/master/lib/foreman_tasks/engine.rb#L24


                                                                                                    end
end


# Precompile any JS or CSS files under app/assets/
# If requiring files from each other, list them explicitly here to avoid precompiling the same
# content twice.
assets_to_precompile =
  Dir.chdir(root) do
    Dir['app/assets/javascripts/**/*', 'app/assets/stylesheets/**/*'].map do |f|
      f.split(File::SEPARATOR, 4).last
    end
  end


initializer 'foreman_tasks.assets.precompile' do |app|
  app.config.assets.precompile += assets_to_precompile
end


initializer 'foreman_tasks.configure_assets', group: :assets do
  SETTINGS[:foreman_tasks] = { :assets => { :precompile => assets_to_precompile } }
end

Eric

ehelms · January 29, 2015, 11:41pm

I opened the following pull request to foreman_tasks to address the
breakage: If you review and test, please do so in the context of Katello to
ensure that the breakage is resolved.

https://github.com/theforeman/foreman-tasks/pull/97

Thanks,
Eric

···

On Thu, Jan 29, 2015 at 4:13 PM, Eric D Helms wrote:

All,

I am investigating a breakage to test_katello_core by the newest
foreman-tasks. Ivan pushed a fix that was blocking our release pipeline
yesterday that included authorization updates to foreman-tasks.

I suspect those updates include a change that assumes an existing Foreman
migrated database by the way the plugin registration works. Since we deploy
Foreman, Katello and plugins and migrate the entire database at once this
leads to test and deployment breakages. I am still investigating and
looking toward a fix but will be AFK for a few. If anyone is curious, or
has time to look into before me, I believe that the lines below need to be
moved into proper seeds:

https://github.com/theforeman/foreman-tasks/blob/master/lib/foreman_tasks/engine.rb#L24

Eric

iNecas · January 30, 2015, 8:53am

I will try look into that today.

– Ivan

···

----- Original Message ----- > I opened the following pull request to foreman_tasks to address the > breakage: If you review and test, please do so in the context of Katello to > ensure that the breakage is resolved. > > https://github.com/theforeman/foreman-tasks/pull/97 > > Thanks, > Eric > > On Thu, Jan 29, 2015 at 4:13 PM, Eric D Helms wrote: > > > All, > > > > I am investigating a breakage to test_katello_core by the newest > > foreman-tasks. Ivan pushed a fix that was blocking our release pipeline > > yesterday that included authorization updates to foreman-tasks. > > > > I suspect those updates include a change that assumes an existing Foreman > > migrated database by the way the plugin registration works. Since we deploy > > Foreman, Katello and plugins and migrate the entire database at once this > > leads to test and deployment breakages. I am still investigating and > > looking toward a fix but will be AFK for a few. If anyone is curious, or > > has time to look into before me, I believe that the lines below need to be > > moved into proper seeds: > > > > > > https://github.com/theforeman/foreman-tasks/blob/master/lib/foreman_tasks/engine.rb#L24 > > > > Eric > > > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscribe@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. >

iNecas · January 30, 2015, 10:07am

I've added one small commit to the original PR to fix the CI https://github.com/theforeman/foreman-tasks/pull/98

Still not sure how it's possible that the CI was green when adding the authorization rules in the first place.

– Ivan

···

----- Original Message ----- > I will try look into that today. > > -- Ivan > > ----- Original Message ----- > > I opened the following pull request to foreman_tasks to address the > > breakage: If you review and test, please do so in the context of Katello to > > ensure that the breakage is resolved. > > > > https://github.com/theforeman/foreman-tasks/pull/97 > > > > Thanks, > > Eric > > > > On Thu, Jan 29, 2015 at 4:13 PM, Eric D Helms wrote: > > > > > All, > > > > > > I am investigating a breakage to test_katello_core by the newest > > > foreman-tasks. Ivan pushed a fix that was blocking our release pipeline > > > yesterday that included authorization updates to foreman-tasks. > > > > > > I suspect those updates include a change that assumes an existing Foreman > > > migrated database by the way the plugin registration works. Since we > > > deploy > > > Foreman, Katello and plugins and migrate the entire database at once this > > > leads to test and deployment breakages. I am still investigating and > > > looking toward a fix but will be AFK for a few. If anyone is curious, or > > > has time to look into before me, I believe that the lines below need to > > > be > > > moved into proper seeds: > > > > > > > > > https://github.com/theforeman/foreman-tasks/blob/master/lib/foreman_tasks/engine.rb#L24 > > > > > > Eric > > > > > > > -- > > You received this message because you are subscribed to the Google Groups > > "foreman-dev" group. > > To unsubscribe from this group and stop receiving emails from it, send an > > email to foreman-dev+unsubscribe@googlegroups.com. > > For more options, visit https://groups.google.com/d/optout. > > > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscribe@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. >

iNecas · January 30, 2015, 10:41am

After a small fix regarding the CI tests fix, I've released
new version of foreman-tasks: waiting for ACK to
get new version out https://github.com/theforeman/foreman-packaging/pull/514.

Also, the rpm build was broken due to missing uuidtools builddep (this issue
started showing after we removed this dependency from foreman-tasks and dynflow).
The fix is here https://github.com/Katello/katello/pull/4966 (as in foreman-tasks
and dynflow, we can replace uuidtools with built-in securenumber one by one)

– Ivan

···

----- Original Message ----- > I've added one small commit to the original PR to fix the CI > https://github.com/theforeman/foreman-tasks/pull/98 > > Still not sure how it's possible that the CI was green when adding the > authorization rules in the first place. > > -- Ivan > > ----- Original Message ----- > > I will try look into that today. > > > > -- Ivan > > > > ----- Original Message ----- > > > I opened the following pull request to foreman_tasks to address the > > > breakage: If you review and test, please do so in the context of Katello > > > to > > > ensure that the breakage is resolved. > > > > > > https://github.com/theforeman/foreman-tasks/pull/97 > > > > > > Thanks, > > > Eric > > > > > > On Thu, Jan 29, 2015 at 4:13 PM, Eric D Helms > > > wrote: > > > > > > > All, > > > > > > > > I am investigating a breakage to test_katello_core by the newest > > > > foreman-tasks. Ivan pushed a fix that was blocking our release pipeline > > > > yesterday that included authorization updates to foreman-tasks. > > > > > > > > I suspect those updates include a change that assumes an existing > > > > Foreman > > > > migrated database by the way the plugin registration works. Since we > > > > deploy > > > > Foreman, Katello and plugins and migrate the entire database at once > > > > this > > > > leads to test and deployment breakages. I am still investigating and > > > > looking toward a fix but will be AFK for a few. If anyone is curious, > > > > or > > > > has time to look into before me, I believe that the lines below need to > > > > be > > > > moved into proper seeds: > > > > > > > > > > > > https://github.com/theforeman/foreman-tasks/blob/master/lib/foreman_tasks/engine.rb#L24 > > > > > > > > Eric > > > > > > > > > > -- > > > You received this message because you are subscribed to the Google Groups > > > "foreman-dev" group. > > > To unsubscribe from this group and stop receiving emails from it, send an > > > email to foreman-dev+unsubscribe@googlegroups.com. > > > For more options, visit https://groups.google.com/d/optout. > > > > > > > -- > > You received this message because you are subscribed to the Google Groups > > "foreman-dev" group. > > To unsubscribe from this group and stop receiving emails from it, send an > > email to foreman-dev+unsubscribe@googlegroups.com. > > For more options, visit https://groups.google.com/d/optout. > > > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscribe@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. >

ehelms · January 30, 2015, 12:53pm

All,

Ivan's PRs have been merged and a new foreman-tasks released. The
test_katello jobs should be green so PRs to Katello may need to be re-run.
If you encounter any further issues please let us know.

Thanks Ivan!

Eric